I've made issue describing critical bug in
Maybe my issue language wasn't nice, but there were no personal insults, just description of problem.
I was a bit upset, as it's the same bug that I've fixed year ago. Someone added it again after 6 months.
Now I'm BANNED on opentibiabr project on GitHub. I cannot create new Issues or comment
I don't see any repost of this issue or PR related to it on opentibiabr GitHub.
Do admins of opentibiabr project try to hide that bug? Do they plan to sell fix for it to opentibiabr server owners?
When I saw otservbr code for first time, I was pretty sure it was made by big-ots-owners to lure newbies and crash their servers, when they get popular.
It's just impossible to do so many so dumb mistakes in code.
For anyone interested. These lines:
are executed in network thread and modify player/map/tile. You cannot do it safely in network thread.
It results in random crash reports from
You can remove that code or move it to 'dispatcher thread', as I did with all packet parsing year ago:
canary
.. it was deleted opentibiabr/canary
Canary Server 13.x for OpenTibia community. . Contribute to opentibiabr/canary development by creating an account on GitHub.
github.com
Maybe my issue language wasn't nice, but there were no personal insults, just description of problem.
I was a bit upset, as it's the same bug that I've fixed year ago. Someone added it again after 6 months.
Now I'm BANNED on opentibiabr project on GitHub. I cannot create new Issues or comment
I don't see any repost of this issue or PR related to it on opentibiabr GitHub.
Do admins of opentibiabr project try to hide that bug? Do they plan to sell fix for it to opentibiabr server owners?
When I saw otservbr code for first time, I was pretty sure it was made by big-ots-owners to lure newbies and crash their servers, when they get popular.
It's just impossible to do so many so dumb mistakes in code.
For anyone interested. These lines:
are executed in network thread and modify player/map/tile. You cannot do it safely in network thread.
It results in random crash reports from
gdb
with functions like getSpectators
, checkCreatures
, clearSpectatorCache
and other related to map and movement.You can remove that code or move it to 'dispatcher thread', as I did with all packet parsing year ago: