[HELP] Report C++

[president vankk]

Hello, I want edit the TFS's report. Instead add a .txt file in reports folder it will goes to SQL.

This is the original code

void Game::playerReportBug(uint32_t playerId, const std::string& message, const Position& position, uint8_t category)
{
   Player* player = getPlayerByID(playerId);
   if (!player) {
     return;
   }

   if (player->getAccountType() == ACCOUNT_TYPE_NORMAL) {
     return;
   }

   std::string fileName = "data/reports/" + player->getName() + " report.txt";
   FILE* file = fopen(fileName.c_str(), "a");
   if (!file) {
     player->sendTextMessage(MESSAGE_EVENT_DEFAULT, "There was an error when processing your report, please contact a gamemaster.");
     return;
   }

   const Position& playerPosition = player->getPosition();
   if (category == BUG_CATEGORY_MAP) {
     fprintf(file, "------------------------------\nName: %s [Map Position: %u, %u, %u] [Player Position: %u, %u, %u]\nComment: %s\n", player->getName().c_str(), position.x, position.y, position.z, playerPosition.x, playerPosition.y, playerPosition.z, message.c_str());
   } else {
     fprintf(file, "------------------------------\nName: %s [Player Position: %u, %u, %u]\nComment: %s\n", player->getName().c_str(), playerPosition.x, playerPosition.y, playerPosition.z, message.c_str());
   }
   fclose(file);

   player->sendTextMessage(MESSAGE_EVENT_DEFAULT, "Your report has been sent to " + g_config.getString(ConfigManager::SERVER_NAME) + ".");
}

I don't have any knowledge about C++, so sorry..

I'm trying using this, and it didn't work.

query << "INSERT INTO `player_reports` (`id` ,`name` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES (" << NULL << ',' << player->getName().c_str() << ',' << position.x << ',' << playerPosition.y << ', ' << playerPosition.z << ', '<< message.c_str() <<', ' << date? <<'");

Thanks.

 

[president vankk]

up

 

[SpiderOT]

could be something like this

  Database* db = Database::getInstance();
   DBQuery query;
   query << "INSERT INTO `player_reports` (`id` ,`name` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("
     << NULL << ',' << player->getName().c_str() << ',' << position.x << ',' << playerPosition.y << ', ' << playerPosition.z << ', '<< message.c_str() <<', ' << time(NULL) <<'");";
   db->query(query.str());

 

[president vankk]

@SpiderOT

const Position& playerPosition = player->getPosition();
   Database* db = Database::getInstance();
   DBQuery query;
   if (category == BUG_CATEGORY_MAP) {
     query << "INSERT INTO `player_reports` (`id` ,`name` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("<< NULL << ',' << player->getName().c_str() << ',' << position.x << ',' << position.y << ', ' << position.z << ', '<< message.c_str() <<', ' << time(NULL) <<'");";
     db->query(query.str());
   } else {
     query << "INSERT INTO `player_reports` (`id` ,`name` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("<< NULL << ',' << player->getName().c_str() << ',' << playerPosition.x << ',' << playerPosition.y << ', ' << playerPosition.z << ', '<< message.c_str() <<', ' << time(NULL) <<'");";
     db->query(query.str());
   }

How I set the time at "time(NULL")? Can it?

 

[SpiderOT]

Yes it's the current timestamp

 

[president vankk]

@SpiderOT
Do you know which function to use where it tells the account_id of the player in C++? I need put it in the query.

 

[SpiderOT]

player->getAccount()

 

[president vankk]

@SpiderOT
Then will be it, right?

query << "INSERT INTO `player_reports` (`id` , `name` , `account_id` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("
<< NULL << ',' << player->getName().c_str() << ', '<< player->getAccount().c_str() <<',' << position.x << ',' << position.y << ', ' << position.z << ', '<< message.c_str() <<', ' << time(NULL) <<'");";

 

[SpiderOT]

forget the last one, this is how it should be

void Game::playerReportBug(uint32_t playerId, const std::string& message, const Position& position, uint8_t category)
{
  Player* player = getPlayerByID(playerId);
  if (!player) {
  return;
  }

  if (player->getAccountType() == ACCOUNT_TYPE_NORMAL) {
  return;
  }

  const Position& playerPosition = player->getPosition();
  Database* db = Database::getInstance();
  DBQuery query;
  if (category == BUG_CATEGORY_MAP) {
  query << "INSERT INTO `player_reports` (`id` , `name` , `account_id` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("<< NULL << ',' << db->escapeString(player->getName()) << ', ' << player->getAccount() <<',' << position.x << ',' << position.y << ', ' << position.z << ', '<< db->escapeString(message) <<', ' << time(NULL) <<'");";
  } else {
  query << "INSERT INTO `player_reports` (`id` , `name` , `account_id` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("<< NULL << ',' << db->escapeString(player->getName()) << ', ' << player->getAccount() <<',' << playerPosition.x << ',' << playerPosition.y << ', ' << playerPosition.z << ', '<< db->escapeString(message) <<', ' << time(NULL) <<'");";
  }
  
  if(!db->query(query.str())){
  player->sendTextMessage(MESSAGE_EVENT_DEFAULT, "There was an error when processing your report, please contact a gamemaster.");
  return false;
  }
  player->sendTextMessage(MESSAGE_EVENT_DEFAULT, "Your report has been sent to " + g_config.getString(ConfigManager::SERVER_NAME) + ".");
}

 

[president vankk]

Error at compiling:

Lines:

 

[SpiderOT]

didn't know you're using tfs 1.1
hope it works this time

void Game::playerReportBug(uint32_t playerId, const std::string& message, const Position& position, uint8_t category)
{
  Player* player = getPlayerByID(playerId);
  if (!player) {
  return;
  }

  if (player->getAccountType() == ACCOUNT_TYPE_NORMAL) {
  return;
  }

  const Position& playerPosition = player->getPosition();
   Database* db = Database::getInstance();
   std::ostringstream query;
  
  if (category == BUG_CATEGORY_MAP) {
  query << "INSERT INTO `player_reports` (`id` , `name` , `account_id` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("<< NULL << ',' << db->escapeString(player->getName()) << ', ' << player->getAccount() <<',' << position.x << ',' << position.y << ', ' << position.z << ', '<< db->escapeString(message) <<', ' << time(nullptr) << ')';
  } else {
  query << "INSERT INTO `player_reports` (`id` , `name` , `account_id` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("<< NULL << ',' << db->escapeString(player->getName()) << ', ' << player->getAccount() <<',' << playerPosition.x << ',' << playerPosition.y << ', ' << playerPosition.z << ', '<< db->escapeString(message) <<', ' << time(nullptr) << ')';
  }
  
  if(!db->executeQuery(query.str())){
  player->sendTextMessage(MESSAGE_EVENT_DEFAULT, "There was an error when processing your report, please contact a gamemaster.");
  return false;
  }
  player->sendTextMessage(MESSAGE_EVENT_DEFAULT, "Your report has been sent to " + g_config.getString(ConfigManager::SERVER_NAME) + ".");
}

 

[president vankk]

didn't know you're using tfs 1.1

1.2

 

[SpiderOT]

well i guess change

return false;

to

return;

 

[president vankk]

In-game error:

 

[SpiderOT]

void Game::playerReportBug(uint32_t playerId, const std::string& message, const Position& position, uint8_t category)
{
  Player* player = getPlayerByID(playerId);
  if (!player) {
  return;
  }

  if (player->getAccountType() == ACCOUNT_TYPE_NORMAL) {
  return;
  }

  const Position& playerPosition = player->getPosition();
  Database* db = Database::getInstance();
  std::ostringstream query;
 
  if (category == BUG_CATEGORY_MAP) {
  query << "INSERT INTO `player_reports` (`id` , `name` , `account_id` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("<< NULL << "," << db->escapeString(player->getName()) << ", " << player->getAccount() <<"," << position.x << "," << position.y << ", " << position.z << ", "<< db->escapeString(message) <<", " << time(nullptr) << ")";
  } else {
  query << "INSERT INTO `player_reports` (`id` , `name` , `account_id` ,`posx` ,`posy` ,`posz` ,`report_description` ,`date`) VALUES ("<< NULL << "," << db->escapeString(player->getName()) << ", " << player->getAccount() <<"," << playerPosition.x << "," << playerPosition.y << ", " << playerPosition.z << ", "<< db->escapeString(message) <<", " << time(nullptr) << ")";
  }
 
  if(!db->executeQuery(query.str())){
  player->sendTextMessage(MESSAGE_EVENT_DEFAULT, "There was an error when processing your report, please contact a gamemaster.");
  return;
  }
  player->sendTextMessage(MESSAGE_EVENT_DEFAULT, "Your report has been sent to " + g_config.getString(ConfigManager::SERVER_NAME) + ".");
}

 

[president vankk]

 

[Santi]

Missing semicolons at the end of the queries?

 

[president vankk]

Missing semicolons at the end of the queries?

https://github.com/otland/forgottenserver/issues/1617