Lua How to shorten this script?

[Moj mistrz]

Hello, yes it's again me. I need little help in shortening this script. Thanks for any help.

local combat = Combat()
combat:setParameter(COMBAT_PARAM_TYPE, COMBAT_NONE)

function onCastSpell(creature, var)
    local msg = "<the welter devours his spawn and heals himself>"
    local spectators, spectator = Game.getSpectators(creature:getPosition(), false, false, 10, 10, 10, 10)
    for i = 1, #spectators do
        spectator = spectators[i]
        if spectator:isMonster() and spectator:getName() == "Egg" then
            spectator:getPosition():sendMagicEffect(CONST_ME_HITBYPOISON)
            spectator:remove()
            creature:say(msg, TALKTYPE_ORANGE_1)
            creature:addHealth(25000)
            creature:getPosition():sendMagicEffect(CONST_ME_MAGIC_BLUE)
        elseif spectator:isMonster() and spectator:getName() == "Spawn Of The Welter" then
            spectator:getPosition():sendMagicEffect(CONST_ME_DRAWBLOOD)
            spectator:remove()
            creature:say(msg, TALKTYPE_ORANGE_1)
            creature:addHealth(25000)
            creature:getPosition():sendMagicEffect(CONST_ME_MAGIC_BLUE)
        end
    end
    return combat:execute(creature, var)
end

 

[Santi]

That's fine.. Why make it shorter?

 

[Moj mistrz]

That's fine.. Why make it shorter?

Cause of twice used:

            spectator:remove()
            creature:say(msg, TALKTYPE_ORANGE_1)
            creature:addHealth(25000)
            creature:getPosition():sendMagicEffect(CONST_ME_MAGIC_BLUE)

And my monster removes all of the eggs at once while this spell is executed. Lel

 

[Santi]

Just do if egg then effect = poison elseif spawn~ then effect = drawblood and then simply put
sendmagiceffect(effect)

If you didn't get it then ask again and I'll explain further

 

[Shadow Dan]

local combat = Combat()
combat:setParameter(COMBAT_PARAM_TYPE, COMBAT_NONE)

function onCastSpell(creature, var)
    local msg = "<the welter devours his spawn and heals himself>"
    local spectators, spectator = Game.getSpectators(creature:getPosition(), false, false, 10, 10, 10, 10)
    for i = 1, #spectators do
        spectator = spectators[i]
        if spectator:isMonster() then
            if spectator:getName() == "Egg" then
                spectator:getPosition():sendMagicEffect(CONST_ME_HITBYPOISON)
            elseif spectator:getName() == "Spawn Of The Welter" then
                spectator:getPosition():sendMagicEffect(CONST_ME_DRAWBLOOD)
            end
            spectator:remove()
            creature:say(msg, TALKTYPE_ORANGE_1)
            creature:addHealth(25000)
            creature:getPosition():sendMagicEffect(CONST_ME_MAGIC_BLUE)
        end
    end
    return combat:execute(creature, var)
end