Solved [LUA] Highscore script (onThink)

[Black Dove]

local function getHighestPlayer()
local result = db.getResult("SELECT `name` FROM `players` ORDER BY `level` DESC, `experience` DESC LIMIT 1")
return result.getDataString(result, "name")
function onThink(interval, lastExecution)
if getPlayerName(cid) == getHighestPlayer() then
doSendMagicEffect(getPlayerPosition(cid), 27)
doSendAnimatedText(getPlayerPosition(cid), "Top Score !!", TEXTCOLOR_RED)
end
return true
end
end

I Dunno What Is Wrong With This Highscore Script :/

Hope Anyone help me

 

[Black Dove]

@dominique120 Hope You Help

I Trying To Follow

http://otland.net/threads/scripting-guide.74030/

But i Got Down In My First Try :'(

 

[dominique120]

Any errors? To me it looks like you should close that function at the top before continuing on with the the onThink section and please tab your scripts.

 

[Black Dove]

Mmmmm So
I Should
Close It First Like That

local function getHighestPlayer()
local result = db.getResult("SELECT `name` FROM `players` ORDER BY `level` DESC, `experience` DESC LIMIT 1")
return result.getDataString(result, "name")
end

And Start From

function onThink(interval, lastExecution)

?

 

[Black Dove]

local function getHighestPlayer()
local result = db.getResult("SELECT `name` FROM `players` ORDER BY `level` DESC, `experience` DESC LIMIT 1")
return result.getDataString(result, "name")
end

function onThink(interval, lastExecution)
if getPlayerName(cid) == getHighestPlayer() then
doSendMagicEffect(getPlayerPosition(cid), 27)
doSendAnimatedText(getPlayerPosition(cid), "Top Score !!", TEXTCOLOR_RED)
end
return true
end

I Did That
And Got That ~~~

@dominique120

 

[Evil Puncker]

the onthink doesn't pass any cid so you can't use getPlayerName(cid) in this script unless you declare it somehow

 

[Black Dove]

Ops !!
What Is Solution Now ... ?
Iam Trying alot and alot and always get errors
i want auto animated text above top level player

@Evil Puncker

 

[mattch]

try:

local function getHighestPlayer()
local result = db.getResult("SELECT `name` FROM `players` ORDER BY `level` DESC, `experience` DESC LIMIT 1")
return result.getDataString(result, "name")
end

function onThink(interval, lastExecution)
for _, cid in pairs(getPlayersOnline()) do
if getPlayerName(cid) == getHighestPlayer() then
doSendMagicEffect(getPlayerPosition(cid), 27)
doSendAnimatedText(getPlayerPosition(cid), "Top Score !!", TEXTCOLOR_RED)
break
end
end
return true
end

 

[Black Dove]

Something Wrong In Line 7

 

[Black Dove]

@Flatlander Can U Help Here ?

 

[dominique120]

Something Wrong In Line 7

Post the error.

 

[mattch]

Ops, i forgot the 'cid':

local function getHighestPlayer()
local result = db.getResult("SELECT `name` FROM `players` ORDER BY `level` DESC, `experience` DESC LIMIT 1")
return result.getDataString(result, "name")
end

function onThink(interval, lastExecution)
for _, cid in pairs(getPlayersOnline()) do
if getPlayerName(cid) == getHighestPlayer() then
doSendMagicEffect(getPlayerPosition(cid), 27)
doSendAnimatedText(getPlayerPosition(cid), "Top Score !!", TEXTCOLOR_RED)
break
end
end
return true
end

 

[Black Dove]

Ops, i forgot the 'cid':

OMG Its WORKS !!
ThanQ @mattch

Its Works Without It
Dunno How But Its Was Giving Error
I Rested It And It Works Perfectly

 

[Black Dove]

@dominique120 ThanQ For Your Support It Works Perfectly Dunno How .. Maybe Forgot /reload globalevents

 

[Summ]

I would not recommend running the query n times (where n is amount of players online). Try this one instead, you could also use getCreatureByName depending on your server version.

local function getHighestPlayer()
  local result = db.getResult("SELECT `name` FROM `players` ORDER BY `level` DESC, `experience` DESC LIMIT 1")
  return result.getDataString(result, "name")
end

function onThink(interval, lastExecution)
  local highscoreName = getHighestPlayer()
  for _, cid in pairs(getPlayersOnline()) do
    if getPlayerName(cid) == highscoreName then
      local position = getPlayerPosition(cid)
      doSendMagicEffect(position, CONST_ME_GIFT_WRAPS)
      doSendAnimatedText(position, "Top Score !!", TEXTCOLOR_RED)
      break
    end
  end

  return true
end