TFS 1.X+ Offline Training OnLogin Problem

[Hertus]

Hello,
i have problem with this code. Please help me.

Lua Script Error: [CreatureScript Interface]
data/creaturescripts/scripts/offlinetraining.lua:onLogin
getNumber(). Argument 2 has out-of-range value for j: -1
stack traceback:
        [C]: in function 'setOfflineTrainingSkill'
        data/creaturescripts/scripts/offlinetraining.lua:10: in function <data/creaturescripts/scripts/offlinetraining.lua:1>

 

[Hertus]

Help Please.

 

[mano368]

Help Please.

Try posting your script

 

[Hertus]

My code:

function onLogin(player)
    local lastLogout = player:getLastLogout()
    local offlineTime = lastLogout ~= 0 and math.min(os.time() - lastLogout, 86400 * 21) or 0
    local offlineTrainingSkill = player:getOfflineTrainingSkill()
    if offlineTrainingSkill == -1 then
        player:addOfflineTrainingTime(offlineTime * 1000)
        return true
    end

    player:setOfflineTrainingSkill(-1)

    if offlineTime < 600 then
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You must be logged out for more than 10 minutes to start offline training.")
        return true
    end

    local trainingTime = math.max(0, math.min(offlineTime, math.min(43200, player:getOfflineTrainingTime() / 1000)))
    player:removeOfflineTrainingTime(trainingTime * 1000)

    local remainder = offlineTime - trainingTime
    if remainder > 0 then
        player:addOfflineTrainingTime(remainder * 1000)
    end

    if trainingTime < 60 then
        return true
    end

    local text = "During your absence you trained for"
    local hours = math.floor(trainingTime / 3600)
    if hours > 1 then
        text = string.format("%s %d hours", text, hours)
    elseif hours == 1 then
        text = string.format("%s 1 hour", text)
    end

    local minutes = math.floor((trainingTime % 3600) / 60)
    if minutes ~= 0 then
        if hours ~= 0 then
            text = string.format("%s and", text)
        end

        if minutes > 1 then
            text = string.format("%s %d minutes", text, minutes)
        else
            text = string.format("%s 1 minute", text)
        end
    end

    text = string.format("%s.", text)
    player:sendTextMessage(MESSAGE_EVENT_ADVANCE, text)

    local vocation = player:getVocation()
    local promotion = vocation:getPromotion()
    local topVocation = not promotion and vocation or promotion

    local updateSkills = false
    if table.contains({SKILL_CLUB, SKILL_SWORD, SKILL_AXE, SKILL_DISTANCE}, offlineTrainingSkill) then
        local modifier = topVocation:getAttackSpeed() / 1000
        updateSkills = player:addOfflineTrainingTries(offlineTrainingSkill, (trainingTime / modifier) / (offlineTrainingSkill == SKILL_DISTANCE and 4 or 2))
    elseif offlineTrainingSkill == SKILL_MAGLEVEL then
        local gainTicks = topVocation:getManaGainTicks() * 2
        if gainTicks == 0 then
            gainTicks = 1
        end

        updateSkills = player:addOfflineTrainingTries(SKILL_MAGLEVEL, trainingTime * (vocation:getManaGainAmount() / gainTicks))
    end

    if updateSkills then
        player:addOfflineTrainingTries(SKILL_SHIELD, trainingTime / 4)
    end

    return true
end

 

[Zarosiano]

BUMP

 

[lokolokio]

BUMP, Same here :S TFS 1.4.2

 

[Fjorda]

player:setOfflineTrainingSkill() is expecting an unsigned integer. So it needs to be 0 or more.

 

[lokolokio]

The solution that I found is by put "false" instead of "-1", now the console gives no error and seems to works fine.

player:setOfflineTrainingSkill(false)

 

[Mateus Robeerto]

The solution that I found is by put "false" instead of "-1", now the console gives no error and seems to works fine.

player:setOfflineTrainingSkill(false)

Using player:setOfflineTrainingSkill(0) is correct because 0 is an integer number used to reset or clear the player's offline training skill. On the other hand, player:setOfflineTrainingSkill(false) is incorrect since false is a boolean value that does not match the expected data type for the function.

 

[lokolokio]

Thanks, It works too... I dont know if it works better, but gives no error too, and I'll follow your advice, thank you again

 

[Mateus Robeerto]

Thanks, It works too... I dont know if it works better, but gives no error too, and I'll follow your advice, thank you again

The same error occurred to me in the console, and I entered '0'. It's been a long time, and I haven't had any issues from six months ago until now. Everything is fine; it ran smoothly!

 

[mano368]

The function only adds time when it's -1, if you're going to change it to 0, did you do the same here or was there never a problem unchanging it?

    if offlineTrainingSkill == -1 then
        player:addOfflineTrainingTime(offlineTime * 1000)
        return true
    end