Solved [TFS 1.0] killingInTheNameOfQuest

[Sentinel3]

Hi everyone,

I've got a problem when players want to start the tasks of Grizzly Adams NPC.

Using: Lastest version of TFS 1.0

The problem is when players try to start the task and monsters killed doesn't count in task.

/data/creaturescripts/scripts/killing in the name of quest/killingInTheNameOfQuestKills.lua

dofile('data/lib/killingInTheNameOfQuest.lua')

function onKill(cid, target, lastHit)
    local started = getPlayerStartedTasks(cid)
    if isPlayer(target) or isSummon(target) then return true end
    if started and #started > 0 then
        for _, id in ipairs(started) do
            if isInArray(tasks[id].creatures, getCreatureName(target):lower()) then
                if getPlayerStorageValue(cid, KILLSSTORAGE_BASE + id) < tasks[id].killsRequired then
                    setPlayerStorageValue(cid, KILLSSTORAGE_BASE + id, getPlayerStorageValue(cid, KILLSSTORAGE_BASE + id) + 1)
                end
            end
        end
    end
    return true
end

/data/lib/killingInTheNameOfQuestKills.lua
http://pastebin.com/BuNf1AJ3

 

[Sentinel3]

Bump

 

[Ignazio]

Could you specify the problem? He doesn't respond when you greet him? Do you get errors in the console log?

Ignazio

 

[Sentinel3]

--Edited--

 

[Ignazio]

What task was it that didn't work? All of them?

EDIT:
Could you post the Grizzly Adams NPC as well?

Ignazio

 

[Sentinel3]

All tasks don't work the count of monster.

Sure, here it is.

/data/npc/scripts/Grizzly Adams.lua
http://pastebin.com/NB8yKZ27

 

[Ignazio]

Are you sure that the storage value was changed when killing monsters? You can check this in the database (phpmyadmin) for your player id, and the storage id 65000 + (task id)

Ignazio

 

[Sentinel3]

For example my character, I tested the quest too.

 

[Ignazio]

Good, now we've established that the kills aren't accounted for. Let's make some prints to identify the error.

dofile('data/lib/killingInTheNameOfQuest.lua')

function onKill(cid, target, lastHit)
local started = getPlayerStartedTasks(cid)
print("A: " .. #started)
if isPlayer(target) or isSummon(target) then return true end
if started and #started > 0 then
for _, id in ipairs(started) do
print("B: " .. id)
print("C: " .. getCreatureName(target):lower())
if isInArray(tasks[id].creatures, getCreatureName(target):lower()) then
if getPlayerStorageValue(cid, KILLSSTORAGE_BASE + id) < tasks[id].killsRequired then
setPlayerStorageValue(cid, KILLSSTORAGE_BASE + id, getPlayerStorageValue(cid, KILLSSTORAGE_BASE + id) + 1)
end
end
end
end
return true
end

Try to temporarily replace your code with this, kill a monster that you should and give me a picture of what the console spits out.

Ignazio

 

[Sentinel3]

Nothing happens.
I still have the same error.

 

[Ignazio]

Then the problem may lie in your xml file. How does your creaturescripts.xml look?

Ignazio

 

[Sentinel3]

Creaturescripts.xml

    <!-- Killing In The Name Of Quest -->
    <event type="kill" name="killingInTheNameOfQuestKills" script="killing in the name of quest/killingInTheNameOfQuestKills.lua"/>

 

[Ignazio]

I wonder if it is even read, the file. Is the file really in that folder? You should consider not have whitespaces in folder names. In any case, try to replace the script with this and reload creaturescripts, just for checking.

dofile('data/lib/killingInTheNameOfQuest.lua')

function onKill(cid, target, lastHit)
local started = getPlayerStartedTasks(cid)
print("A: " .. #started)
if isPlayer(target) or isSummon(target) then return true end
if started and #started > 0 then
for _, id in ipairs(started) do
print("B: " .. id)
print("C: " .. getCreatureName(target):lower())
iffffffffffffffff isInArray(tasks[id].creatures, getCreatureName(target):lower()) then
if getPlayerStorageValue(cid, KILLSSTORAGE_BASE + id) < tasks[id].killsRequired then
setPlayerStorageValue(cid, KILLSSTORAGE_BASE + id, getPlayerStorageValue(cid, KILLSSTORAGE_BASE + id) + 1)
end
end
end
end
return true
end

 

[Thaian Citizen]

Did you forget this line:

registerCreatureEvent(cid, "killingInTheNameOfQuestKills")

in your data/creaturescripts/scripts/login.lua ?
If it is not there then add it and try again please

 

[Sentinel3]

Thank you so much @Thaian Citizen, now works perfectly, I just need to add what you say.

<Solved>