[TFS 1.0] Task system not counting kills | instruments won't play in inventory

[EvoSoft]

Title says it all - tell me which scripts you need from Killing in the name of.. quest and I'll post 'em.

Instruments script:

function onUse(cid, item, fromPosition, itemEx, toPosition)
-- TODO: Different music effect for different instruments.
fromPosition:sendMagicEffect(CONST_ME_SOUND_BLUE)

return true
end

 

[EvoSoft]

bump

 

[Limos]

Post the creaturescript with type kill that should count the kills.
Also post errors and how you added it.

 

[Xivin]

Post the creaturescript with type kill that should count the kills.
Also post errors and how you added it.

how did you guys resolve TFS not counting kills?

 

[Limos]

Post the script that should count kills and also errors and how you added it etc.

 

[Xivin]

Post the script that should count kills and also errors and how you added it etc.

here ya go

function onKill(cid, target, lastHit)
   local targetCreature = Creature(target)
   if targetCreature:isPlayer() or targetCreature:getMaster() then
     return true
   end

   local player, targetName = Player(cid), targetCreature:getName():lower()
   for _, taskId in ipairs(player:getStartedTasks()) do
     if isInArray(tasks[taskId].creatures, targetName) then
       local killAmount = player:getStorageValue(KILLSSTORAGE_BASE + taskId)
       if killAmount < tasks[taskId].killsRequired then
         player:setStorageValue(KILLSSTORAGE_BASE + taskId, killAmount + 1)
       end
     end
   end
   return true
end

 

[Limos]

You can add prints in the script to see where the problem is.

print("test1")

print("test2")

Etc.
Add them under function onKill and under if statements and the for loop.
Then look in your console which messages you get and which not, the line above the message you don't get, there is the problem.
If you don't get the message under function onKill, it means the script isn't added correct.

 

[Xivin]

it doesnt print no error any other suggestion?

You can add prints in the script to see where the problem is.

print("test1")

print("test2")

Etc.
Add them under function onKill and under if statements and the for loop.
Then look in your console which messages you get and which not, the line above the message you don't get, there is the problem.
If you don't get the message under function onKill, it means the script isn't added correct.

 

[Limos]

If you don't get the print message you added under function onKill in your console, this means the script isn't added correct, so post how you added it.

 

[Xivin]

You can add prints in the script to see where the problem is.

print("test1")

print("test2")

Etc.
Add them under function onKill and under if statements and the for loop.
Then look in your console which messages you get and which not, the line above the message you don't get, there is the problem.
If you don't get the message under function onKill, it means the script isn't added correct.

If you don't get the print message you added under function onKill in your console, this means the script isn't added correct, so post how you added it.

okay i just retested it i put script like this

function onKill(cid, target, lastHit)
   local targetCreature = Creature(target)
   if targetCreature:isPlayer() or targetCreature:getMaster() then
     return true
   end
print("test1")
   local player, targetName = Player(cid), targetCreature:getName():lower()
   for _, taskId in ipairs(player:getStartedTasks()) do
     if isInArray(tasks[taskId].creatures, targetName) then
       local killAmount = player:getStorageValue(KILLSSTORAGE_BASE + taskId)
       if killAmount < tasks[taskId].killsRequired then
         player:setStorageValue(KILLSSTORAGE_BASE + taskId, killAmount + 1)
       end
     end
   end
   return true
end
print("test2")

it shows test 1 but not test 2

 

[Limos]

That's because it's outside function onKill, so that won't be loaded when you kill something, add them after if statements.
For example under this line

if killAmount < tasks[taskId].killsRequired then

If you get the print from there, it means the script is working properly with the tables and all, so then it's a problem from an other script that makes it look like it's not counting them.

 

[Xivin]

That's becaus it's outside function onKill, so that won't be loaded when you kill something, add them after if statements.
For example under this line

if killAmount < tasks[taskId].killsRequired then

If you get the print from there, it means the script is working properly with the tables and all, then then it's a problem from an other script that makes t look like it's not counting them.

would you have any idea what script it may be>

 

[Limos]

Well, why do you think it's not counting the kills?

 

[Xivin]

Well, why do you think it's not counting the kills?

no idea thats why i ask you lol

 

[Limos]

I mean, why do think that? What happens that makes you think it's not counting the kills? So which script is making it look like it's not counting them?

 

[Xivin]

I mean, why do think that? What happens that makes you think it's not counting the kills? So which script is making it look like it's not counting them?

it will not updated my quest log and when i ask grizzly my status he says ive killed none of them

 

[Limos]

Is the same storage used in the questlog and in the npc?

 

[Xivin]

Is the same storage used in the questlog and in the npc?

where would i find the npc files i checked in grizzly adams but all he has is trade information nothing about the monsters in killing in the name of or storage

 

[Limos]

Look for getStorageValue and if it's the same as in the kill script.

 

[Xivin]

ah im not worried about it thanks for help ive tried and tried neither script give a specific storage

Look for getStorageValue and if it's the same as in the kill script.

Look for getStorageValue and if it's the same as in the kill script.