Lua TFS 1.1 onAddItem

[sircurse]

Hi,

This function was working before upgrade to 1.1, do anyone know if it was removed? (onAddItem)
It was being used for the HOTA quest.

Curse.

 

[RazorBlade]

movement.cpp:

case MOVE_EVENT_ADD_ITEM: return "onAddItem";

data/movements/scripts/dough.lua still uses it. I haven't used it, but it seems to be there still.

Edit: just tested it with the dough. It works for me. I'm using nightly build 739 (latest in TFS 1.2)

 

[sircurse]

I saw the dough script, I think it is because I was using it with a actionid, it may works with item instead actionid, the problem of using a itemid instead a actionid is that will be hard to manage it, since I have a .lua for each quest.

Have you tried with a actionid?

That is how I have it set:

<movevent event="AddItem" tileitem="1" actionid="13101" script="quests/ancient_tombs_quest.lua"/>

Actually the actionid was set on the basin, and was fine till the update.

Curse.

 

[RazorBlade]

I imagine you would just use this in the script:

if tileitem:getAttribute(ITEM_ATTRIBUTE_ACTIONID) == xxxx then

and keep movements.xml the way it is for dough or something:

<movevent event="AddItem" tileitem="1" itemid="1786" script="dough.lua"/>

 

[sircurse]

But that is the problem, the basin can be used for other quests, if I use the itemid of the basin pointing to HOTA quest, it will always call this .lua, if I need another quest to use the coal basin I will have to edit on HOTA quest, or I will need a coalbasin.lua script dedicated, and all the quests that I use it will need that script.

It is not easy to manage, I would like to skip working that way to have every single quest centralized to this own script. better to fix bugs, making upgrades, etc...

Curse.

 

[RazorBlade]

I just tested it using itemid 1787 (oven - off) with actionid 5000 and it worked.

<movevent event="AddItem" tileitem="1" actionid="5000" script="dough.lua"/>

 

[sircurse]

Can you share your function? Mine is that and is not working.

function onAddItem(moveitem, tileitem, position)
local coin = config[tileitem.actionid]
i = getTopCreature(coin.FROMPOS).uid

if tileitem:getAttribute(ITEM_ATTRIBUTE_ACTIONID) >= 13101 and tileitem:getAttribute(ITEM_ATTRIBUTE_ACTIONID) <= 13108 and moveitem.itemid == 2159 then
    if(isPlayer(i) == TRUE) then
        doRemoveItem(moveitem.uid, 1)
        doSendMagicEffect(position, 15)
        doSendMagicEffect(coin.FROMPOS, CONST_ME_TELEPORT)
        doTeleportThing(getPlayer.uid, coin.TOPOS, FALSE)
        doSendMagicEffect(coin.TOPOS, CONST_ME_TELEPORT)
    end
end
    return true
end

 

[RazorBlade]

This works for me with the dough. I am using TFS 1.2 though, and my old TFS 1.1 builds no longer work because I've since updated my datapack. So I don't know if this works the same in TFS 1.1

<movevent event="AddItem" tileitem="1" actionid="5000" script="dough.lua"/>

function onAddItem(moveitem, tileitem, position)
    if moveitem:getId() == 2693 then
        moveitem:transform(2689)
        position:sendMagicEffect(CONST_ME_HITBYFIRE)
    elseif moveitem:getId() == 6277 then
        moveitem:transform(2687, 12)
        position:sendMagicEffect(CONST_ME_HITBYFIRE)
    end
    return true
end

 

[sircurse]

I re-write the code and for some reason it has been fixed.

function onAddItem(moveitem, tileitem, position)
coin = config[tileitem:getActionId()]
player = getTopCreature(coin.FROMPOS).uid

    if tileitem:getActionId() >= 13101 and tileitem:getActionId() <= 13108 then
            if(isPlayer(player) == TRUE) and moveitem:getId() == 2159 then
                doRemoveItem(moveitem.uid, 1)
                position:sendMagicEffect(16)
                doSendMagicEffect(coin.FROMPOS, 11)
                doTeleportThing(player, coin.TOPOS, FALSE)
                doSendMagicEffect(coin.TOPOS, 11)
            end
    end
    return true
end