Solved Vocation Upgrade Potion

[Extrodus]

I am trying to create a script that uses an item for promotion but I am getting an error; and the error doesn't even make sense since everything in the script is the same and using the same function.

Error:

[11/12/2013 01:11:01] [Error - Action Interface]
[11/12/2013 01:11:01] data/actions/scripts/war/donor_potion.lua:onUse
[11/12/2013 01:11:01] Description:
[11/12/2013 01:11:01] (luaDoPlayerRemoveItem) Player not found

Script:

function onUse(cid, item, fromPosition, itemEx, toPosition)
  
   voc = getPlayerVocation(cid)
   if voc == 1 then --Is sorcerer
   doPlayerSetVocation(cid,5) -- new sorcerer vocation
   doCreatureSay(cid, "You feel smarter.", TALKTYPE_ORANGE_1, cid)
   doPlayerRemoveItem(cid, 5080)
   elseif voc == 2 then -- is druid
   doPlayerSetVocation(cid,6) -- new druid vocation
   doCreatureSay(cid, "You feel smarter.", TALKTYPE_ORANGE_1, cid)
   doPlayerRemoveItem(cid, 5080)
   elseif voc == 3 then -- is paladin
   doPlayerSetVocation(cid,7) -- new paladin vocation
   doCreatureSay(cid, "You feel smarter.", TALKTYPE_ORANGE_1, cid)
   doPlayerRemoveItem(cid, 5080)
   elseif voc == 4 then -- is knight
   doPlayerSetVocation(cid,8) -- new knight vocation
   doCreatureSay(cid, "You feel smarter.", TALKTYPE_ORANGE_1, cid)
   doPlayerRemoveItem(cid, 5080)
   else
   doPlayerSendTextMessage(cid,19,"You do not need this potion.")
   end

   return true
end

Not the greatest script, but I am za beginner plix! At least I am trying right? Thanks in advance.


Solved thanks to Ninja (scroll down)

 

[Shinmaru]

"elsif" is incorrect, it is "elseif" change it on all of them.

 

[Extrodus]

@Shinmaru Thank you, I have updated the first post with the new errors! The item is not being removed.

 

[Shinmaru]

function onUse(cid, item, fromPosition, itemEx, toPosition)
local v = {
    [1] = {newVoc = 5, msg = "smarter"}, -- Master Sorcerer
    [2] = {newVoc = 6, msg = "wiser"}, -- Elder Druid
    [3] = {newVoc = 7, msg = "steadier"}, -- Royal Paladin
    [4] = {newVoc = 8, msg = "stronger"} -- Elite Knight
} 
    voc = getPlayerVocation(cid)
    if v[voc] then
        local _v_ = v[voc]
        doPlayerSetVocation(cid,_v_.newVoc)
        doCreatureSay(cid, "You feel " .. _v_.msg .. ".", TALKTYPE_ORANGE_1)
    else
        doPlayerSendTextMessage(cid,19,"You do not need this potion.")
        return false
    end
return true
end

 

[Extrodus]

@Shinmaru - Thank you, but the item does not get removed. -doPlayerRemoveItem(cid, 5080)-

Also, once I relog the vocation is gone ;\

 

[Ninja]

Just add doRemoveItem(item.uid, 1) below doCreatureSay~

I don't have any issue with vocation disappearing, could you try purchasing promotion from an NPC?

 

[Extrodus]

Oh weird, it happens even when buying it from an npc. Do you have any idea why this would happen @Ninja?

Looking at this thread http://otland.net/threads/tfs-0-3-3-super-vocation-problem.29979/

It seems its a problem with Printers Release - http://otland.net/f18/8-60-forgotten-server-0-3-6-crying-damson-v8-147913/

But it should be fixed in 0.3.6, it is widely used and other people have working promotions haha.

 

[Ninja]

Oh, thought this were about TFS 1.0. xd

Well, try with this.

function onUse(cid, item, fromPosition, itemEx, toPosition)
    if getPlayerPromotionLevel(cid) < 1 then
        doPlayerSetPromotionLevel(cid, 1)
        doCreatureSay(cid, "You feel smarter.", TALKTYPE_ORANGE_1)
        doRemoveItem(item.uid, 1)
    else
        doPlayerSendTextMessage(cid, MESSAGE_EVENT_ADVANCE, "You do not need this potion.")
    end
    return true
end

 

[Extrodus]

Haha, got to have multiple projects to keep us going right? Luls, I got projects coming out my butt; just non-stop trying to figure TFS out and build with it. Again, thank you so much - for like the 1000th time; You sir are a gem! It works like a charm now and saves the vocation!

Solved thanks to Ninja!