Solved Why wont this work? Lever teleport

[highclick]

.lua script:

function onUse(cid, item, fromPosition, itemEx, toPosition)
if item.actionid = 102 then
doTeleportThing(cid, {x=1283, y=1084, z=8})
end
return true
end

.xml script:

    <action actionid="102" event="script" value="other/dungeonleverking.lua" />

It's a lever with actionID 102, it's supposte too teleport you when you click on it.

 

[Limos]

Remove

if item.actionid = 102 then

And the end above return true.
If you compare numbers to see if it's the same/equal, use == instead of =
http://otland.net/threads/scripting-guide.74030/#post-758251
But checking for actionid while it's already in actions.xml is just useless so this whole line isn't needed.

Next time, post the errors (and your server version, so people don't have to look at your other threads).

 

[highclick]

i didn't recieve any errors, sorry forgot too post my version. My bad for that, thanks for replyin.

 

[highclick]

Why does it work without

if item.actionid = 102 then

?

Isn't it supposte too be there to compare if im using the correct lever? @Limos

 

[Limos]

It's already added with actionid 102 in actions.xml so it will only execute the script if the item has actionid 102. So if you add such a line it will be just useless code, since it will only be executed if the actionid is 102.

If it should check for actionid in the Lua script (for example when there are more ids used for the same script), then the line should look like this.

if item.actionid == 102 then

 

[highclick]

Ah i see, thanks alot man!

One more question, if i may.

I tried too add another condition, so that the lever teleport only works if the player stands on a specific tile. I added this into my code and it won't work:

function onUse(cid, item, fromPosition, itemEx, toPosition)
if getCreaturePosition(cid) == {x=1277, y=1084, z=8} then
    doTeleportThing(cid, {x=1282, y=1084, z=8})
return true
end

Care too help? @Limos

 

[Limos]

You can't compare tables like that.
You can add this function (data/lib/050-function.lua).

function comparePos(poss, pos)
     return pos.x == poss.x and pos.y == poss.y and pos.z == poss.z
end

Then in that script

if comparePos(getCreaturePosition(cid), {x=1277, y=1084, z=8}) then

Don't forget to close if statements with end.

 

[highclick]

Okay i added the function into data/lib/050-function.lua

and this is my .lua script:

function onUse(cid, item, fromPosition, itemEx, toPosition)
    if comparePos(getCreaturePosition(cid), {x=1277, y=1084, z=8}) then
        doTeleportThing(cid, {x=1282, y=1084, z=8})
    end
return true
end

Still won't work. It feels like I'm missing a vital undertanding of some logic here. @Limos

 

[Limos]

Look if you get errors or if you get this message ingame.

function onUse(cid, item, fromPosition, itemEx, toPosition)
     if comparePos(getCreaturePosition(cid), {x=1277, y=1084, z=8}) then
         doTeleportThing(cid, {x=1282, y=1084, z=8})
     else
         doPlayerSendCancel(cid, "You have to stand on the right position.")
     end
     return true
end

 

[highclick]

Look if you get errors or if you get this message ingame.

function onUse(cid, item, fromPosition, itemEx, toPosition)
     if comparePos(getCreaturePosition(cid), {x=1277, y=1084, z=8}) then
         doTeleportThing(cid, {x=1282, y=1084, z=8})
     else
         doPlayerSendCancel(cid, "You have to stand on the right position.")
     end
     return true
end

No messages in game and no errors in console

 

[Xikini]

Look if you get errors or if you get this message ingame.

function onUse(cid, item, fromPosition, itemEx, toPosition)
     if comparePos(getCreaturePosition(cid), {x=1277, y=1084, z=8}) then
         doTeleportThing(cid, {x=1282, y=1084, z=8})
     else
         doPlayerSendCancel(cid, "You have to stand on the right position.")
     end
     return true
end

Should we be using return false, after the doplayersendcancel?

 

[Limos]

How did you added it? In actions.xml and in the map.

Should we be using return false, after the doplayersendcancel?

No, with return false the player will get a message with "You cannot use this object"

 

[highclick]

It works now with your latest script!