[fixed] Getting players positions

[Doggynub]

so i made this thing

     local players = {}

              for v = frompos.x , topos.x do
                    for k = frompos.y , topos.y do
                       local position = {x=v,y=k,z=7}
	                   local pid = getTopCreature(position).uid
		          
		                   if(pid ~= 0 and isPlayer(pid)) then
                                table.insert(players, pid)
                           end
                    end
              end

But i want it to insert players if there is more than one player on same sqm , i know i have used getTopCreature, but i have tryed to use other and it didnt get any players.

 

[Doggynub]

bumb seems it wasnt fixed [-- i know i cant bumb till 24 hours , but title and request was changed-- ]

 

[Teckman]

Totally dunno wether it works.

local players = {}
for v = frompos.x , topos.x do
	for k = frompos.y , topos.y do
		for i = 1, 255 do
			position = {x = v, y = k, z = 7, stackpos = i}
			pid = getThingfromPos(position).uid
			if(pid ~= nil and isPlayer(pid)) then
				table.insert(players, pid)
			end
		end
	end
end

 

[Doggynub]

I think this will duplicate the insert for each player found.

But this works thanks it needed a little edit

		local players = {}
for v = frompos.x , topos.x do
	for k = frompos.y , topos.y do
		for i = 1, 200 do
			position = {x = v, y = k, z = 7, stackpos = i}
			local pid = getThingfromPos(position).uid
			if(pid ~= nil and isPlayer(pid)) then
				table.insert(players, pid)
			end
		end
	end
end

 

[Teckman]

Just check it, and then we'll see. And btw dont use locals if you're going to use them once and don't store them, becouse it uses more ram, and with f.e. 3 loops it'll use much more.

@EDIT

Yea, I forgot about 255 stackpos, it would duplicate. But now it shouldnt.

 

[Doggynub]

it did duplicate yeh but i made it works needed little fix.Tanks!

 

[Cykotitan]

why would you loop 200 times ? ? =/

 

[Doggynub]

how much i need then?

 

[Teckman]

why would you loop 200 times ? ? =/

To check every stackpos, since there can be like 30 ppl on one sqm.

how much i need then?

exactly 252

 

[Cykotitan]

	local players = {}
	for v = frompos.x , topos.x do
		for k = frompos.y , topos.y do
			for i = 1, 252 do
				local pid = getThingfromPos({x = v, y = k, z = 7, stackpos = i}).uid
				if pid > 0 then
					if isPlayer(pid) then
						table.insert(players, pid)
					end
				else
					break
				end
			end
		end
	end

? ;/

 

[Doggynub]

@up

And you have made how many loops??


Edit : didnt notice the break & btw as i said if you made 252 it will duplicate the inserting of same player.

 

[Cykotitan]

!

no it shouldn't because it's under 253