Lua Outfit Lever?

[XxShallowxX]

Hello, this script is found at : http://otland.net/f81/outfiter-109942/

But, it does not work, whenever I pull the lever, it does nothing, no message or anything, it just pulls the lever.

Script :

function onUse(cid, item, fromPosition, itemEx, toPosition)
	if item.actionid == 5888 then
		doPlayerSendTextMessage(cid,21,"Your outfit has been changed!")
                    doSendMagicEffect(getCreaturePosition(cid), CONST_ME_FIREWORK_RED)
            doCreatureChangeOutfit(cid, {lookType = math.random(2, 333))
 end
    return true
end

I'm also using a script that whenever you kill a certain amount of monsters, your weapon is upgraded : http://otland.net/f82/upgrade-weapon-killing-monsters-v2-0-a-46855/

But with that, Whenever I kill a custom made monster, an error comes up and the monster does not die.. It is just there, with no health, and attacking..

Script :

--[[
	** Monster weapon upgrader by slawkens **
	** Updated to version 2.0 by Shawak **
 
	[ignore_monsters]
	- type "yes" and only by the [monsters] the weapon gain kills
	[monsters]
	• {"..","..",".."} - list of monsters where weapon gain kills
	[ingore_weapons]
	- type "yes" and only the [weapons] can be upgraded
	[weapons]
	•       [2395] = {100, 1, 3},
	   	   |       |   |  |
	    	   |       |   |  •> extraAttackLimit
	    	   |       |   •> extraAttack
	   	   |       •> kills
		   •> id of the weapon
	[default]
	• kills - how much monsters must be killed
	• extraAttack - how much extraAttack points will this weapon get
	• extraAttackLimit - you can set limit of extraAttack points added
]]--
 
 
local ignore_monsters = "yes"
local monsters = {"Rat","Dragon","Dragon Lord"}
 
local ingore_weapons = "yes"
local weapons = {
	[7416] = {100, 100, 10000},
	[7435] = {100, 100, 10000},
	[7427] = {100, 100, 10000}
    [7438] = {100, 25, 10000}
} -- weapon end --
 
local default = {
	100,   -- kills
	100,     -- extraAttack
	10000 -- extraAttackLimit
} -- default end --
 
function onKill(cid, target)
	if(isPlayer(target) == TRUE) then
		return TRUE
	end
 
	if (string.lower(ignore_monsters) == "no" and isInArray(monsters, getCreatureName(target)) == TRUE or string.lower(ignore_monsters) == "yes") then
 
		local playerWeapon = getPlayerWeapon(cid, TRUE)
		if(playerWeapon.itemid == 0) then
			return TRUE
		end
 
		local weapon = weapons[getPlayerWeapon(cid).itemid]
		if string.lower(ingore_weapons) == "yes" then
			weapon = default
		end
 
		if (string.lower(ingore_weapons) == "no" and (not weapon) == FALSE or string.lower(ingore_weapons) == "yes") then
 
			local currentExtraAttack = getItemExtraAttack(playerWeapon.uid)
			if(currentExtraAttack >= weapon[3]) then
				return TRUE
			end
 
			local add = weapon[2]
			if(currentExtraAttack + add > weapon[3]) then
				add = currentExtraAttack - weapon[3]
			end
 
			if(playerWeapon.actionid ~= 0) then
				if(playerWeapon.actionid >= weapon[1]+9999) then
					doSetItemActionId(playerWeapon.uid, 10000)
					setItemExtraAttack(playerWeapon.uid, currentExtraAttack + add)
					doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "Congratulations! Your weapon received +" ..add.. " attack points and now have total extra damage of +" .. getItemExtraAttack(playerWeapon.uid) .. " points!")
					doSetItemSpecialDescription(playerWeapon.uid, "["..(playerWeapon.actionid-9999).."/"..weapon[1].." | ".. getItemExtraAttack(playerWeapon.uid).."/"..weapon[3].."]")
				else
					doSetItemActionId(playerWeapon.uid, playerWeapon.actionid + 1)
					doSetItemSpecialDescription(playerWeapon.uid, "["..(playerWeapon.actionid-9999).."/"..weapon[1].." | ".. getItemExtraAttack(playerWeapon.uid).."/"..weapon[3].."]")
				end
			else
				doSetItemActionId(playerWeapon.uid, 10001)
				doSetItemSpecialDescription(playerWeapon.uid, "[1/"..weapon[1].." | ".. getItemExtraAttack(playerWeapon.uid).."/"..weapon[3].."]")
			end
		end
	end
	return TRUE
end

Rep++
?

 

[Santi]

You were missing a '}'

function onUse(cid, item, fromPosition, itemEx, toPosition)
if item.actionid == 5888 then
   doPlayerSendTextMessage(cid,21,"Your outfit has been changed!")
   doSendMagicEffect(getCreaturePosition(cid), CONST_ME_FIREWORK_RED)
   doCreatureChangeOutfit(cid, {lookType = math.random(2, 333)})
end
return true
end

 

[XxShallowxX]

You were missing a '}'

function onUse(cid, item, fromPosition, itemEx, toPosition)
if item.actionid == 5888 then
   doPlayerSendTextMessage(cid,21,"Your outfit has been changed!")
   doSendMagicEffect(getCreaturePosition(cid), CONST_ME_FIREWORK_RED)
   doCreatureChangeOutfit(cid, {lookType = math.random(2, 333)})
end
return true
end

Okay, thanks
Have any idea with the others?



EDIT : Lever Still Not Working o.0

 

[XxShallowxX]

Bump
Up
My
Post



I'm Using : 0.3.6pl​

 

[XxShallowxX]

Bump
Up
My
Post



I'm Using : 0.3.6pl​

 

[Santi]

Oh I didnt even took a look at the script actually
Please note that doCreatureChangeOutfit will make it so you cannot remove/change the outfit

local outfit = {lookType = 80, lookHead = 0, lookBody = 0, lookLegs = 0, lookFeet = 0, lookAddons = 0}
function onUse(cid, item, fromPosition, itemEx, toPosition)
	if item.actionid == 5888 then
		doPlayerSendTextMessage(cid,21,"Your outfit has been changed!")
        doSendMagicEffect(getPlayerPosition(cid), CONST_ME_FIREWORK_RED)
        doCreatureChangeOutfit(cid, outfit)
 end
 return true
end

 

[XxShallowxX]

Oh I didnt even took a look at the script actually
Please note that doCreatureChangeOutfit will make it so you cannot remove/change the outfit

local outfit = {lookType = 80, lookHead = 0, lookBody = 0, lookLegs = 0, lookFeet = 0, lookAddons = 0}
function onUse(cid, item, fromPosition, itemEx, toPosition)
	if item.actionid == 5888 then
		doPlayerSendTextMessage(cid,21,"Your outfit has been changed!")
        doSendMagicEffect(getPlayerPosition(cid), CONST_ME_FIREWORK_RED)
        doCreatureChangeOutfit(cid, outfit)
 end
 return true
end

Thanks
I found out the problem myself though, I just used the "Search" function and found out that there was a posted problem with that script, but anyways, rep++
<3