Advancing in shielding without a shield

[leonmagmo]

Hello guys, I'm making a server that don't have shields(just weapons) but I want to do something that the players advance in shielding skill as if they were using a shield because the advantage of some vocations is the def.
Anyone know if is possible to do it doing a source edit? I really don't know what to do :s
Thanks!

 

[dchampag]

I believe it would require source edit, considering your shielding skill isn't any good unless you have a shield equipped, you could probably make the weapon as a shield and add it to weapons.xml to work as a weapon...

 

[leonmagmo]

I believe it would require source edit, considering your shielding skill isn't any good unless you have a shield equipped, you could probably make the weapon as a shield and add it to weapons.xml to work as a weapon...

I tried that but it didn't work, I really think that will need a source edit ;s

 

[cbrm]

onUseWeapon script + doPlayerAddSkillTry(cid, skillid, n)

 

[leonmagmo]

onUseWeapon script + doPlayerAddSkillTry(cid, skillid, n)

Ye, maybe this work, but i think that i need to do a source edit because the shielding skill need work without shields
Thanks

 

[Zuma Master]

Ye, maybe this work, but i think that i need to do a source edit because the shielding skill need work without shields
Thanks

*facepalm*.

 

[Colors]

Ye, maybe this work, but i think that i need to do a source edit because the shielding skill need work without shields
Thanks

cbrm gave you the answer and you didn't get it...

 

[leonmagmo]

But cbrm gave me the answer for make the skill grow up without a shield,BUT the skill shielding don't work without a shield, so I need to make other edit for the skill work, right?
(I'm Sorry if I have not understood)

 

[Colors]

You have to add the doPlayerAddSkillTry (of Shield) inside the onUseWeapon function (Weapon script).

 

[Zuma Master]

It would be better to use onStatsChange(), because onUseWeapon() will only work if a player attacks another player.

 

[cbrm]

bad luck then, checking player weapons on hands

function onUseWeapon(cid, var)


    local pid = getCreatureTarget(cid)


    if isPlayer(pid) or isMonster(pid) then
        doPlayerAddSkillTry(cid, SKILL_SHIELD, 1)
    end
    --etc

 

[leonmagmo]

Ye this work, but in Tibia if a player use a two handed sword and have a skill shielding 100 the skill don't change anything in the time to defence, right?
In my server the players will use just a sword, so I'll need to make a source edit for the skill shielding work with weapons( I don't know what to edit)
Thanks!

 

[Evil Hero]

player.cpp

void Player::onBlockHit(BlockType_t)
{
	if(shieldBlockCount > 0)
	{
		--shieldBlockCount;
		if(hasShield())
			addSkillAdvance(SKILL_SHIELD, 1);
	}
}

to:

void Player::onBlockHit(BlockType_t)
{
	if(shieldBlockCount > 0)
	{
		--shieldBlockCount;
		addSkillAdvance(SKILL_SHIELD, 1);
	}
}

kind regards, Evil Hero.

 

[Zuma Master]

bad luck then, checking player weapons on hands

function onUseWeapon(cid, var)


    local pid = getCreatureTarget(cid)


    if isPlayer(pid) or isMonster(pid) then
        doPlayerAddSkillTry(cid, SKILL_SHIELD, 1)
    end
    --etc

That will only work if the player is targeting whoever is attacking him ;p.

 

[leonmagmo]

player.cpp

void Player::onBlockHit(BlockType_t)
{
	if(shieldBlockCount > 0)
	{
		--shieldBlockCount;
		if(hasShield())
			addSkillAdvance(SKILL_SHIELD, 1);
	}
}

to:

void Player::onBlockHit(BlockType_t)
{
	if(shieldBlockCount > 0)
	{
		--shieldBlockCount;
		addSkillAdvance(SKILL_SHIELD, 1);
	}
}

kind regards, Evil Hero.

Thanks!
It worked, but the server is not counting the shielding skill to avoid damage. Shielding 1 or Shielding 200 takes the same damage.

 

[Evil Hero]

Thanks!
It worked, but the server is not counting the shielding skill to avoid damage. Shielding 1 or Shielding 200 takes the same damage.

I'll look into that and tell you how to do it, once I have a bit more time

 

[leonmagmo]

I'll look into that and tell you how to do it, once I have a bit more time

Ok Thaanks

 

[zetto]

Maybe need some changes here, at player.cpp

switch(item->getWeaponType())
		{
			case WEAPON_NONE:
				break;

			case WEAPON_SHIELD:
			{
				if(!shield || (shield && item->getDefense() > shield->getDefense()))
					shield = item;

				break;
			}

			default: //weapons that are not shields
			{
				weapon = item;
				break;
			}

and here

getShieldAndWeapon(shield, weapon);
	if(weapon)
	{
		extraDefense = weapon->getExtraDefense();
		defenseValue = baseDefense + weapon->getDefense();
		defenseSkill = getWeaponSkill(weapon);
	}

	if(shield && shield->getDefense() > defenseValue)
	{
		if(shield->getExtraDefense() > extraDefense)
			extraDefense = shield->getExtraDefense();

		defenseValue = baseDefense + shield->getDefense();
		defenseSkill = getSkill(SKILL_SHIELD, SKILL_LEVEL);
	}

	if(!defenseSkill)
		return 0;

But i don't know what to change :s

 

[Zuma Master]

Maybe need some changes here, at player.cpp

switch(item->getWeaponType())
		{
			case WEAPON_NONE:
				break;

			case WEAPON_SHIELD:
			{
				if(!shield || (shield && item->getDefense() > shield->getDefense()))
					shield = item;

				break;
			}

			default: //weapons that are not shields
			{
				weapon = item;
				break;
			}

and here

getShieldAndWeapon(shield, weapon);
	if(weapon)
	{
		extraDefense = weapon->getExtraDefense();
		defenseValue = baseDefense + weapon->getDefense();
		defenseSkill = getWeaponSkill(weapon);
	}

	if(shield && shield->getDefense() > defenseValue)
	{
		if(shield->getExtraDefense() > extraDefense)
			extraDefense = shield->getExtraDefense();

		defenseValue = baseDefense + shield->getDefense();
		defenseSkill = getSkill(SKILL_SHIELD, SKILL_LEVEL);
	}

	if(!defenseSkill)
		return 0;

But i don't know what to change :s

The first tagged part is apparently a function that tells if an item is a weapon or a shield.
The second tagged part is apparently a function that is used to determine the total defense/attack on a weapon/shield. But don't get me wrong, I'm pretty newbish with CPP.