Solved How to remove Buy with backpack?

[Way20]

Hi to everyone, well like the title say I need to remove the option "buy with backpack" from the npcs trade window, anyone know how can I do it? I'm talking about this option in the window

Thanks in advance!

 

[Tarek]

Hi to everyone, well like the title say I need to remove the option "buy with backpack" from the npcs trade window, anyone know how can I do it? I'm talking about this option in the window

Thanks in advance!

It's client sided not server thing i think,

 

[Okke]

Use OTClient.

 

[WibbenZ]

You can disable the use by modifying your src code.
But you can not remove the button itself without using OTC or something like that where you can fully modify it.

 

[Okke]

You can disable the use by modifying your src code.
But you can not remove the button itself without using OTC or something like that where you can fully modify it.

There is a way to remove this button, you just need to know how to mod CIP's client, there are a few dudes that are heavy into modifying it....I just can't remember the name.

 

[WibbenZ]

Not worth the cost of actually doing it tho.

 

[Way20]

You can disable the use by modifying your src code.
But you can not remove the button itself without using OTC or something like that where you can fully modify it.

Hmm, disable is enough, which source files I need change to disable it?

 

[WibbenZ]

https://github.com/otland/forgottenserver/blob/master/src/protocolgame.cpp#L958
Change

bool inBackpacks = msg.getByte() != 0;

To

msg.skipBytes(1);
bool inBackpacks = false;

 

[Way20]

https://github.com/otland/forgottenserver/blob/master/src/protocolgame.cpp#L958
Change

bool inBackpacks = msg.getByte() != 0;

To

msg.skipBytes(1);
bool inBackpacks = false;

I don't have this

    bool inBackpacks = msg.getByte() != 0;

but I have this (I'm using TFS 0.4 Rev 3777)

    bool inBackpacks = msg.get<char>();

I've tried change to that

msg.skipBytes(1);
bool inBackpacks = false;

But I got this error

 

[WibbenZ]

Oh tought you used 1.x.
Upload your parsePlayerPurchase function (the one you linked the text from).
Aswell as the Game::* function it links to (it's in game.cpp).

 

[Way20]

Oh tought you used 1.x.
Upload your parsePlayerPurchase function (the one you linked the text from).
Aswell as the Game::* function it links to (it's in game.cpp).

That is it?

void ProtocolGame::parsePlayerPurchase(NetworkMessage &msg)
{
    uint16_t id = msg.get<uint16_t>();
    uint16_t count = msg.get<char>();
    uint16_t amount = msg.get<char>();
    bool ignoreCap = msg.get<char>();
    bool inBackpacks = msg.get<char>();
    addGameTaskTimed(DISPATCHER_TASK_EXPIRATION, &Game::playerPurchaseItem, player->getID(), id, count, amount, ignoreCap, inBackpacks);
}

 

[WibbenZ]

Yes and then the Game :: PlayerPurchaseItem function. (without spaces due to the : p smiley)

 

[Way20]

I think should be it

bool Game::playerPurchaseItem(uint32_t playerId, uint16_t spriteId, uint8_t count, uint8_t amount,
    bool ignoreCap/* = false*/, bool inBackpacks/* = false*/)
{
    Player* player = getPlayerByID(playerId);
    if(!player || player->isRemoved())
        return false;

    int32_t onBuy, onSell;
    Npc* merchant = player->getShopOwner(onBuy, onSell);
    if(!merchant)
        return false;

    const ItemType& it = Item::items.getItemIdByClientId(spriteId);
    if(!it.id)
        return false;

    uint8_t subType = count;
    if(it.isFluidContainer() && count < uint8_t(sizeof(reverseFluidMap) / sizeof(int8_t)))
        subType = reverseFluidMap[count];

    if(!player->canShopItem(it.id, subType, SHOPEVENT_BUY))
        return false;

    merchant->onPlayerTrade(player, SHOPEVENT_BUY, onBuy, it.id, subType, amount, ignoreCap, inBackpacks);
    return true;
}

 

[Way20]

Bump

 

[WibbenZ]

void ProtocolGame::parsePlayerPurchase(NetworkMessage &msg)
{
    uint16_t id = msg.get<uint16_t>();
    uint16_t count = msg.get<char>();
    uint16_t amount = msg.get<char>();
    bool ignoreCap = msg.get<char>();
    bool inBackpacks = false;
    msg.skip(1);
    addGameTaskTimed(DISPATCHER_TASK_EXPIRATION, &Game::playerPurchaseItem, player->getID(), id, count, amount, ignoreCap, inBackpacks);
}

 

[Way20]

void ProtocolGame::parsePlayerPurchase(NetworkMessage &msg)
{
    uint16_t id = msg.get<uint16_t>();
    uint16_t count = msg.get<char>();
    uint16_t amount = msg.get<char>();
    bool ignoreCap = msg.get<char>();
    bool inBackpacks = false;
    msg.skip(1);
    addGameTaskTimed(DISPATCHER_TASK_EXPIRATION, &Game::playerPurchaseItem, player->getID(), id, count, amount, ignoreCap, inBackpacks);
}

It worked!, thanks a lot man!!