[TFS 1.x][C++] Poison Bug

[Peonso]

I want to apply @Jo3Bingham fix to TFS poison bug (https://github.com/otland/forgottenserver/issues/1372#issuecomment-130429221), but since I'm not proficient in C++ I'm in doubt on how to handle it correctly.

Would that do the job? Adding this code at that line?

https://github.com/otland/forgotten...69cc5c941869fe5c2b27c903f/src/combat.cpp#L528

if ((g_game.combatChangeHealth(caster, target, damage)) == 0) {
   return false;
}

 

[Ninja]

No, you cannot compare a boolean value with a numeric value.

You might want to look into Game::combatChangeHealth, and change so that it returns false here.

 

[jo3bingham]

Note that my "fix" will only allow a player to be poisoned when they take damage. Which is fine for snakes, but scorpions, for example, don't have to draw blood to poison a player.

 

[Peonso]

Note that my "fix" will only allow a player to be poisoned when they take damage. Which is fine for snakes, but scorpions, for example, don't have to draw blood to poison a player.

Well, I think the incorrect behavior of only poisoning when you get a hit is "less worse". If I change the line pointed by Ninja I will get no downside? Only this will be changed?

 

[Peonso]

No, you cannot compare a boolean value with a numeric value.

You might want to look into Game::combatChangeHealth, and change so that it returns false here.

Note that my "fix" will only allow a player to be poisoned when they take damage. Which is fine for snakes, but scorpions, for example, don't have to draw blood to poison a player.

It fucked up envenon/soulfire runes. I also get poffs as if I'm blocking the poison damage, even if it's "not" applied.