• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Solved Question regarding the addition of new flags

tokenzz

tokenzz

:thinking:
Joined
Feb 2, 2013
Messages
778
Solutions
2
Reaction score
345
Hiho,

I'm curious how the TFS system is built around the player flag enums. What I'd like to do with this knowledge, is to add custom flags (parts from TFS 0.4) to OTHire.

Would this be possible by simply adding a new enum, converting functions from the code related to those playerflags in game.cpp and elsewhere?

Also, where do I specify the binary value of the flag? Does that automatically get set by order or where is it specified?

example:
Code: 
 TFS 0.4

enum PlayerFlags
{
PlayerFlag_CannotUseCombat = 0, //2^0 = 1
PlayerFlag_CannotAttackPlayer, //2^1 = 2
PlayerFlag_CannotAttackMonster, //2^2 = 4
PlayerFlag_CannotBeAttacked, //2^3 = 8
PlayerFlag_CanConvinceAll, //2^4 = 16
PlayerFlag_CanSummonAll, //2^5 = 32
PlayerFlag_CanIllusionAll, //2^6 = 64
PlayerFlag_CanSenseInvisibility, //2^7 = 128
PlayerFlag_IgnoredByMonsters, //2^8 = 256
PlayerFlag_NotGainInFight, //2^9 = 512
PlayerFlag_HasInfiniteMana, //2^10 = 1024
PlayerFlag_HasInfiniteSoul, //2^11 = 2048
PlayerFlag_HasNoExhaustion, //2^12 = 4096
PlayerFlag_CannotUseSpells, //2^13 = 8192
PlayerFlag_CannotPickupItem, //2^14 = 16384
PlayerFlag_CanAlwaysLogin, //2^15 = 32768
PlayerFlag_CanBroadcast, //2^16 = 65536
PlayerFlag_CanEditHouses, //2^17 = 131072
PlayerFlag_CannotBeBanned, //2^18 = 262144
PlayerFlag_CannotBePushed, //2^19 = 524288
PlayerFlag_HasInfiniteCapacity, //2^20 = 1048576
PlayerFlag_CanPushAllCreatures, //2^21 = 2097152
PlayerFlag_CanTalkRedPrivate, //2^22 = 4194304
PlayerFlag_CanTalkRedChannel, //2^23 = 8388608
PlayerFlag_TalkOrangeHelpChannel, //2^24 = 16777216
PlayerFlag_NotGainExperience, //2^25 = 33554432
PlayerFlag_NotGainMana, //2^26 = 67108864
PlayerFlag_NotGainHealth, //2^27 = 134217728
PlayerFlag_NotGainSkill, //2^28 = 268435456
PlayerFlag_SetMaxSpeed, //2^29 = 536870912
PlayerFlag_SpecialVIP, //2^30 = 1073741824
PlayerFlag_NotGenerateLoot, //2^31 = 2147483648
PlayerFlag_CanTalkRedChannelAnonymous, //2^32 = 4294967296
PlayerFlag_IgnoreProtectionZone, //2^33 = 8589934592
PlayerFlag_IgnoreSpellCheck, //2^34 = 17179869184
PlayerFlag_IgnoreEquipCheck, //2^35 = 34359738368
PlayerFlag_CannotBeMuted, //2^36 = 68719476736
PlayerFlag_IsAlwaysPremium, //2^37 = 137438953472
PlayerFlag_38, //2^38 = 274877906944 //obsolete, can be re-used
PlayerFlag_39, //2^39 = 549755813888 //not used by us
PlayerFlag_ShowGroupNameInsteadOfVocation, //2^40 = 1099511627776
PlayerFlag_HasInfiniteStamina, //2^41 = 2199023255552
PlayerFlag_CannotMoveItems, //2^42 = 4398046511104
PlayerFlag_CannotMoveCreatures, //2^43 = 8796093022208
PlayerFlag_CanReportBugs, //2^44 = 17592186044416
PlayerFlag_45, //2^45 = 35184372088832 //not used by us
PlayerFlag_CannotBeSeen, //2^46 = 70368744177664
PlayerFlag_HideHealth, //2^47 = 140737488355328
PlayerFlag_CanPassThroughAllCreatures, //2^48 = 281474976710656
PlayerFlag_LastFlag
};
enum PlayerCustomFlags
{
PlayerCustomFlag_AllowIdle = 0, //2^0 = 1
PlayerCustomFlag_CanSeePosition, //2^1 = 2
PlayerCustomFlag_CanSeeItemDetails, //2^2 = 4
PlayerCustomFlag_CanSeeCreatureDetails, //2^3 = 8
PlayerCustomFlag_NotSearchable, //2^4 = 16
PlayerCustomFlag_GamemasterPrivileges, //2^5 = 32
PlayerCustomFlag_CanThrowAnywhere, //2^6 = 64
PlayerCustomFlag_CanPushAllItems, //2^7 = 128
PlayerCustomFlag_CanMoveAnywhere, //2^8 = 256
PlayerCustomFlag_CanMoveFromFar, //2^9 = 512
PlayerCustomFlag_CanUseFar, //2^10 = 1024
PlayerCustomFlag_CanLoginMultipleCharacters,//2^11 = 2048 (account flag)
PlayerCustomFlag_CanLogoutAnytime, //2^12 = 4096 (account flag)
PlayerCustomFlag_HideLevel, //2^13 = 8192
PlayerCustomFlag_IsProtected, //2^14 = 16384
PlayerCustomFlag_IsImmune, //2^15 = 32768
PlayerCustomFlag_NotGainSkull, //2^16 = 65536
PlayerCustomFlag_NotGainUnjustified, //2^17 = 131072
PlayerCustomFlag_IgnorePacification, //2^18 = 262144
PlayerCustomFlag_IgnoreLoginDelay, //2^19 = 524288
PlayerCustomFlag_CanStairhop, //2^20 = 1048576
PlayerCustomFlag_CanTurnhop, //2^21 = 2097152
PlayerCustomFlag_IgnoreHouseRent, //2^22 = 4194304
PlayerCustomFlag_CanWearAllAddons, //2^23 = 8388608
PlayerCustomFlag_IsWalkable, //2^24 = 16777216
PlayerCustomFlag_25, //2^25 = 33554432 // PlayerCustomFlag_CanUseAllMounts
PlayerCustomFlag_HasFullLight, //2^26 = 67108864
PlayerCustomFlag_LastFlag
};


OTHire:
enum PlayerFlags{
//Add the flag's numbers to get the groupFlags number you need
PlayerFlag_CannotUseCombat = 0, //2^0 = 1
PlayerFlag_CannotAttackPlayer, //2^1 = 2
PlayerFlag_CannotAttackMonster, //2^2 = 4
PlayerFlag_CannotBeAttacked, //2^3 = 8
PlayerFlag_CanConvinceAll, //2^4 = 16
PlayerFlag_CanSummonAll, //2^5 = 32
PlayerFlag_CanIllusionAll, //2^6 = 64
PlayerFlag_CanSenseInvisibility, //2^7 = 128
PlayerFlag_IgnoredByMonsters, //2^8 = 256
PlayerFlag_NotGainInFight, //2^9 = 512
PlayerFlag_HasInfiniteMana, //2^10 = 1024
PlayerFlag_HasInfiniteSoul, //2^11 = 2048
PlayerFlag_HasNoExhaustion, //2^12 = 4096
PlayerFlag_CannotUseSpells, //2^13 = 8192
PlayerFlag_CannotPickupItem, //2^14 = 16384
PlayerFlag_CanAlwaysLogin, //2^15 = 32768
PlayerFlag_CanBroadcast, //2^16 = 65536
PlayerFlag_CanEditHouses, //2^17 = 131072
PlayerFlag_CannotBeBanned, //2^18 = 262144
PlayerFlag_CannotBePushed, //2^19 = 524288
PlayerFlag_HasInfiniteCapacity, //2^20 = 1048576
PlayerFlag_CanPushAllCreatures, //2^21 = 2097152
PlayerFlag_CanTalkRedPrivate, //2^22 = 4194304
PlayerFlag_CanTalkRedChannel, //2^23 = 8388608
PlayerFlag_TalkOrangeHelpChannel, //2^24 = 16777216
PlayerFlag_NotGainExperience, //2^25 = 33554432
PlayerFlag_NotGainMana, //2^26 = 67108864
PlayerFlag_NotGainHealth, //2^27 = 134217728
PlayerFlag_NotGainSkill, //2^28 = 268435456
PlayerFlag_SetMaxSpeed, //2^29 = 536870912
PlayerFlag_SpecialVIP, //2^30 = 1073741824
PlayerFlag_NotGenerateLoot, //2^31 = 2147483648
PlayerFlag_CanTalkRedChannelAnonymous, //2^32 = 4294967296
PlayerFlag_IgnoreProtectionZone, //2^33 = 8589934592
PlayerFlag_IgnoreSpellCheck, //2^34 = 17179869184
PlayerFlag_IgnoreWeaponCheck, //2^35 = 34359738368
PlayerFlag_CannotBeMuted, //2^36 = 68719476736
PlayerFlag_IsAlwaysPremium, //2^37 = 137438953472
PlayerFlag_CanAnswerRuleViolations, //2^38 = 274877906944
PlayerFlag_CanReloadContent, //2^39 = 549755813888
PlayerFlag_ShowGroupInsteadOfVocation, //2^40 = 1099511627776
PlayerFlag_CannotMoveItems, //2^41 = 2199023255552
PlayerFlag_CannotMoveCreatures, //2^42 = 4398046511104
PlayerFlag_CanReportBugs, //2^43 = 8796093022208
PlayerFlag_CanSeeSpecialDescription, //2^44 = 17592186044416
PlayerFlag_CannotBeSeen, //2^45 = 35184372088832
//add new flags here
PlayerFlag_LastFlag
};

NOTE: I am not interested in a flag generator or equivalent

/A somewhat confused Tibian

Kind regards,

t0kenz
 
Last edited:
Sort by date Sort by votes
Each flag that exist has a value of 2 to the power of its index for its enum that is what this 2^n means,
Code: 
PlayerCustomFlag_CanSeeCreatureDetails, //2^3 = 8

Code: 
2 ^ 3
2 x 2 x 2 = 8

Of course there is a limit to range..

If you re-arrange the enums index then you end up bugging different aspects of the server.
 
Upvote 0 Downvote
So, could I simply make a new enum in my othire const.h called whatever or is it easier to just add more on the current ones that exist? I could definitely learn by trial & error, but much easier to ask here to start off with in case anyone has got any knowledge already (which I know you do).
 
Upvote 0 Downvote
Codex NG said:
Each flag that exist has a value of 2 to the power of its index for its enum that is what this 2^n means,
Code: 
PlayerCustomFlag_CanSeeCreatureDetails, //2^3 = 8

Code: 
2 ^ 3
2 x 2 x 2 = 8

Of course there is a limit to range..

If you re-arrange the enums index then you end up bugging different aspects of the server.
Click to expand...
The flag value in the enum is not 2^3 its actually 3, so it could have 2^31-1 values in it. The thing is that the flag function will shift to 1 bit left 3 times and this value is uint64_t, so you could only have 64 of those without bugging anything.
Source: https://github.com/Zerua/TFS-8.60/blob/master/group.h#L72

@tokenzz
You can copy everything about custom flags and it will work without any problem, the only thing you may have problem is to make the flag actualy do something, but the functionality is just the same. (loading from the xml, setcustomflag, hascustomflag, etc etc)
 
Upvote 0 Downvote
MatheusMkalo said:
The flag value in the enum is not 2^3 its actually 3, so it could have 2^31-1 values in it. The thing is that the flag function will shift to 1 bit left 3 times and this value is uint64_t, so you could only have 64 of those without bugging anything.
Source: https://github.com/Zerua/TFS-8.60/blob/master/group.h#L72

@tokenzz
You can copy everything about custom flags and it will work without any problem, the only thing you may have problem is to make the flag actualy do something, but the functionality is just the same. (loading from the xml, setcustomflag, hascustomflag, etc etc)
Click to expand...
Appreciate the very concrete answer. ~solved
 
Upvote 0 Downvote
Codex NG said:
I know what a comment is... these flags are associated with the player and group flags, some times I wonder about you...
Click to expand...
And thats what i've said, I said the problem is not the enum getting to big, its the function that is going to use that value can make it too big.
1 << n = 2^n
 
Upvote 0 Downvote

Similar threads

Tofame
Removing .otb – Only Using .dat
2
Replies
35
Views
5K
lindero33
L
Back
Top