Solved Reward chest system error

[silveralol]

hello folks, I'm trying to implement a reward chest system different, then I saw in github from forgottenserver a pull request, very nice code made by @Non Sequitur
I copy all to my source, but get two errors about the functions

https://github.com/otland/forgottenserver/pull/1641#discussion-diff-48067223R498

and

https://github.com/otland/forgottenserver/pull/1641#discussion-diff-48067223R501

the error says: Error container has no member "isRewardCorpse()" and Error container has no member "setRewardCorpse()"
How I can solve this?
I lost my mind trying resolve this :/ seems that is a little #include, idk :/
thanks in advice.
Regards,
Silveralol

 

[Mkalo]

hello folks, I'm trying to implement a reward chest system different, then I saw in github from forgottenserver a pull request, very nice code made by @Non Sequitur
I copy all to my source, but get two errors about the functions

https://github.com/otland/forgottenserver/pull/1641#discussion-diff-48067223R498

and

https://github.com/otland/forgottenserver/pull/1641#discussion-diff-48067223R501

the error says: Error container has no member "isRewardCorpse()" and Error container has no member "setRewardCorpse()"
How I can solve this?
I lost my mind trying resolve this :/ seems that is a little #include, idk :/
thanks in advice.
Regards,
Silveralol

The error where?? Compiling error?? Lua??

Copy the entire error...

 

[silveralol]

The error where?? Compiling error?? Lua??

Copy the entire error...

is when I try compile it, i'm not in my own pc, then what I can tell about the error is it:
when this line https://github.com/otland/forgottenserver/pull/1641/files#diff-db869def8f9edca87c157f26f4a1d25bR343
call the function get the error
and when this line
https://github.com/otland/forgottenserver/pull/1641/files#diff-721c64f80744c3e002360fff5827e2c8R130
call the another function get errors
the errors says
"the class Container has no member isRewardCorpse()"
or
"the class Container has no member setRewardCorpse()"

 

[Danger II]

Did you add:
https://github.com/otland/forgottenserver/pull/1641/files#diff-708342412a7a3b1182b63622489c9f97R498
and
https://github.com/otland/forgottenserver/pull/1641/files#diff-708342412a7a3b1182b63622489c9f97R501
to item.h?

 

[silveralol]

Did you add:
https://github.com/otland/forgottenserver/pull/1641/files#diff-708342412a7a3b1182b63622489c9f97R498
and
https://github.com/otland/forgottenserver/pull/1641/files#diff-708342412a7a3b1182b63622489c9f97R501
to item.h?

yes of course, I followed all steps.

 

[Danger II]

Obviously you have forget something or the code is incorrect (I doubt)

 

[silveralol]

Obviously you have forget something or the code is incorrect (I doubt)

man, I'm tired to read the full code and read my sources, I do all steps four, five, six times...
could you try compile it ?

 

[president vankk]

Harnessing that silvera has created this topic.. I'm getting the error below on Windows, but on my ubuntu it works pretty fine:

 

[Mkalo]

man, I'm tired to read the full code and read my sources, I do all steps four, five, six times...
could you try compile it ?

Change container-> to item->

 

[silveralol]

Harnessing that silvera has created this topic.. I'm getting the error below on Windows, but on my ubuntu it works pretty fine:

in your Ubuntu, the functions setRewardCorpse() and isRewardCorpse() works?
I'm sure that when you try compile in Ubuntu same with errors like this the compiler will compile, but with just warnings
also, remembering something, that a line missing somewhere....
I get the same errror in the past

Change container-> to item->

making this change is almost sure that will work?

 

[president vankk]

in your Ubuntu, the functions setRewardCorpse() and isRewardCorpse() works?
I'm sure that when you try compile in Ubuntu same with errors like this the compiler will compile, but with just warnings
also, remembering something, that a line missing somewhere....
I get the same errror in the past

Yup, the same sources compiles on Ubuntu pretty fine without any warning or error, but it does not compile on Windows. Also, I already revised the code like ten times in the past of two months and seems I got all.

 

[silveralol]

Yup, the same sources compiles on Ubuntu pretty fine without any warning or error, but it does not compile on Windows. Also, I already revised the code like ten times in the past of two months and seems I got all.

the line that I'm saying is a line not included at the pull request (I guess) I need solve my first problem, then I'll see if I get the same error, I'm using MVS 2013 yet ¬¬

 

[silveralol]

@president vankk man, I try again, the resolve the problem with my two errors, I've pasted in the wrong function then later I compile and it work perfectly, but only with normal characters, characters with access don't work
I think that you need to try copy it again, maybe you paste in the wrong function like me...
and a special thanks to:
@MatheusMkalo and @Danger II for try help me

 

[president vankk]

@president vankk man, I try again, the resolve the problem with my two errors, I've pasted in the wrong function then later I compile and it work perfectly, but only with normal characters, characters with access don't work
I think that you need to try copy it again, maybe you paste in the wrong function like me...
and a special thanks to:
@MatheusMkalo and @Danger II for try help me

It is perfectly and compiles on Ubuntu, lawl - but I'll give a shoot on it but now.

 

[Caduceus]

Sorry to bump an old thread, but I am trying to implement this system as well. Is the Boss supposed to drop all the loot possible, by passing the chance of drop?

 

[silveralol]

Sorry to bump an old thread, but I am trying to implement this system as well. Is the Boss supposed to drop all the loot possible, by passing the chance of drop?

see something about "factor" in the lua part
and drop the chance
and voilá

 

[Caduceus]

Boss.lua, local lootFactor = 1 already. If I lower this to 0, there is no loot

local playerLoot
            if --[[stamina > 840 and]] con.score ~= 0 then
                local lootFactor = 1
                lootFactor = lootFactor / participants ^ (1 / 3) -- tone down the loot a notch if there are many participants
                lootFactor = lootFactor * (1 + lootFactor) ^ (con.score / expectedScore) -- increase the loot multiplicatively by how many times the player surpassed the expected score
                playerLoot = monsterType:getBossReward(lootFactor, _ == 1)

                if con.player then
                    for _, p in ipairs(playerLoot) do
                        reward:addItem(p[1], p[2])
                    end
                end
            end

 

[silveralol]

@Caduceus

lootFactor = lootFactor / participants ^ (1 /0.5)

try. after it you need to check the chances in the monsters