Solved Change attackspeed based on fist fight

[Allesn]

Hello, I wan't to chance the attackspeed based on fist fighting skill, to do this, I made:
player.h

uint32_t getAttackSpeed() const {
            return (vocation->getAttackSpeed() * (1 - getSkillLevel(SKILL_FIST) * 0.00375));
        }

But I did not notice much difference...
Is there any way to improve it?

 

[Zothion]

https://github.com/otland/forgottenserver/pull/1305
without this change it will always only be able to attack in full 1000ms intervals

 

[Allesn]

SOLVED, I just change

#define EVENT_CREATURE_THINK_INTERVAL 1000

to

#define EVENT_CREATURE_THINK_INTERVAL 300

in creature.h

 

[Zothion]

that also works yes, but now its just every 300ms interval instead of 1000ms, plus you will have 3.33x more creature think events running on your server, while the linked fix disregards creature think completely and can trigger every 1ms, so if you are willing to recompile i would recommend to take that change instead

 

[Allesn]

that also works yes, but now its just every 300ms interval instead of 1000ms, plus you will have 3.33x more creature think events running on your server, while the linked fix disregards creature think completely and can trigger every 1ms, so if you are willing to recompile i would recommend to take that change instead

How do I this change? I just remake the changes in commit?

 

[Zothion]

replace the removed (red) lines with the added (green) lines at same positions, red/blank lines on the left side show where

 

[Allesn]

replace the removed (red) lines with the added (green) lines at same positions, red/blank lines on the left side show where

Ok, I will do this. Thank you