C++ Walk trough summon

[Sigoles]

How would the code for a player be able to walkthrough a summon if it is inside the protection zone?

forgottenserver/player.cpp at c4b10a905b11728522e715bd41f2493858ab0e46 · otland/forgottenserver · GitHub

I was tryed something like this:

const Tile* SummonTile = creature->getTile();
if (SummonTile->hasFlag(TILESTATE_PROTECTIONZONE) && creature->isSummon) {   
        return true;
    }

or this:

const Player* player = creature->getPlayer();
    if (!player || !creature->isSummon("Rat")) {
        return false;
    }

tfs 1.3

Or an edit to be able to move summon, <flag pushable="1" /> does not work being summon



thanks

 

[WibbenZ]

How would the code for a player be able to walkthrough a summon if it is inside the protection zone?

forgottenserver/player.cpp at c4b10a905b11728522e715bd41f2493858ab0e46 · otland/forgottenserver · GitHub

I was tryed something like this:

const Tile* SummonTile = creature->getTile();
if (SummonTile->hasFlag(TILESTATE_PROTECTIONZONE) && creature->isSummon) {   
        return true;
    }

tfs 1.3

Or an edit to be able to move summon, <flag pushable="1" /> does not work being summon



thanks

Do as you have been told in prev threads to find faults, use the print functions.
In C++ it's

std::cout << "State: " << SummonTile->hasFlag(TILESTATE_PROTECTIONZONE) << std::endl;

Print before and after the if statment, if you write out the if statments both should print out 1 or true, the one that prints null or false is "breaking" the statment.

 

[Nekiro]

forgottenserver/player.cpp at c4b10a905b11728522e715bd41f2493858ab0e46 · otland/forgottenserver · GitHub

change to:

const Player* player = creature->getPlayer();
if (!player && (!creature->getMonster() && !creature->getMaster())) {
    return false;
}

forgottenserver/player.cpp at c4b10a905b11728522e715bd41f2493858ab0e46 · otland/forgottenserver · GitHub

to:

const Tile* creatureTile = creature->getTile();
if (!creatureTile || !creatureTile->hasFlag(TILESTATE_PROTECTIONZONE)) {
    return false;
}

I edited this post 999999 times XD sry for this

 

[Sigoles]

@Thexamx @WibbenZ

Current code (did not work yet I can not move through and did not print anything).

bool Player::canWalkthrough(const Creature* creature) const
{
    if (group->access || creature->isInGhostMode()) {
        return true;
    }
  
    const Tile* creatureTile = creature->getTile();
    if (creatureTile || creatureTile->hasFlag(TILESTATE_PROTECTIONZONE)) {
        std::cout << "State: " << creatureTile->hasFlag(TILESTATE_PROTECTIONZONE) << std::endl;
        return true;
    }
  
  
  
    const Player* player = creature->getPlayer();
    if (!player) {
        return false;
    }

    const Tile* playerTile = player->getTile();
    if (!playerTile || (!playerTile->hasFlag(TILESTATE_PROTECTIONZONE) && player->getLevel() > static_cast<uint32_t>(g_config.getNumber(ConfigManager::PROTECTION_LEVEL)))) {
        return false;
    }

    const Item* playerTileGround = playerTile->getGround();
    if (!playerTileGround || !playerTileGround->hasWalkStack()) {
        return false;
    }
  
  
    Player* thisPlayer = const_cast<Player*>(this);
    if ((OTSYS_TIME() - lastWalkthroughAttempt) > 2000) {
        thisPlayer->setLastWalkthroughAttempt(OTSYS_TIME());
        return false;
    }

    if (creature->getPosition() != lastWalkthroughPosition) {
        thisPlayer->setLastWalkthroughPosition(creature->getPosition());
        return false;
    }

    thisPlayer->setLastWalkthroughPosition(creature->getPosition());
  
  
    return true;
}

I was tested with !creatureTile too

 

[WibbenZ]

@Thexamx @WibbenZ

Current code (did not work yet I can not move through and did not print anything).

bool Player::canWalkthrough(const Creature* creature) const
{
    if (group->access || creature->isInGhostMode()) {
        return true;
    }
 
    const Tile* creatureTile = creature->getTile();
    if (creatureTile || creatureTile->hasFlag(TILESTATE_PROTECTIONZONE)) {
        std::cout << "State: " << creatureTile->hasFlag(TILESTATE_PROTECTIONZONE) << std::endl;
        return true;
    }
 
 
 
    const Player* player = creature->getPlayer();
    if (!player) {
        return false;
    }

    const Tile* playerTile = player->getTile();
    if (!playerTile || (!playerTile->hasFlag(TILESTATE_PROTECTIONZONE) && player->getLevel() > static_cast<uint32_t>(g_config.getNumber(ConfigManager::PROTECTION_LEVEL)))) {
        return false;
    }

    const Item* playerTileGround = playerTile->getGround();
    if (!playerTileGround || !playerTileGround->hasWalkStack()) {
        return false;
    }
 
 
    Player* thisPlayer = const_cast<Player*>(this);
    if ((OTSYS_TIME() - lastWalkthroughAttempt) > 2000) {
        thisPlayer->setLastWalkthroughAttempt(OTSYS_TIME());
        return false;
    }

    if (creature->getPosition() != lastWalkthroughPosition) {
        thisPlayer->setLastWalkthroughPosition(creature->getPosition());
        return false;
    }

    thisPlayer->setLastWalkthroughPosition(creature->getPosition());
 
 
    return true;
}

I was tested with !creatureTile too

The only way you are gonna see that print is if the code works, put it before the if statment and check both of them

 

[Sigoles]

The only way you are gonna see that print is if the code works, put it before the if statment and check both of them

The print works if I walk inside other character and out of protection zone

Stat: 0

 

[Nekiro]

Ddi you even try what I posted? In "current code" I dont see my changes.

Clean TFS code and try my changes and let me know

 

[Sigoles]

Ddi you even try what I posted? In "current code" I dont see my changes.

Clean TFS code and try my changes and let me know

Yes, we cant pass with through
code actually:

bool Player::canWalkthrough(const Creature* creature) const
{
    if (group->access || creature->isInGhostMode()) {
        return true;
    }
       
    const Player* player = creature->getPlayer();
    if (!player && (!creature->getMonster() && !creature->getMaster())) {
        return false;
    }   
   
    const Tile* creatureTile = creature->getTile();
    if (!creatureTile || !creatureTile->hasFlag(TILESTATE_PROTECTIONZONE)) {
        return false;
    }
   
    const Tile* playerTile = player->getTile();
    const Item* playerTileGround = playerTile->getGround();
    if (!playerTileGround || !playerTileGround->hasWalkStack()) {
        return false;
    }
   
    
    Player* thisPlayer = const_cast<Player*>(this);
    if ((OTSYS_TIME() - lastWalkthroughAttempt) > 2000) {
        thisPlayer->setLastWalkthroughAttempt(OTSYS_TIME());
        return false;
    }

    if (creature->getPosition() != lastWalkthroughPosition) {
        thisPlayer->setLastWalkthroughPosition(creature->getPosition());
        return false;
    }

    thisPlayer->setLastWalkthroughPosition(creature->getPosition());
   
   
    return true;
}

 

[Sigoles]

Update thread