C++ Critical Effect on Monster

[boxxer321]

Hi, guys!
first of all, sorry for my bad english!

I come here because I changed a few lines in the player.cpp to send a "CRIT!" Effect, but the effect is being shown to the player and I wanted it to go to the monster

here is the line:

void Player::sendCritical() const
{
if(g_config.getBool(ConfigManager:: DISPLAY_CRITICAL_HIT))
g_game.addMagicEffect(getPosition(), MAGIC_EFFECT_MIRRORVERTICAL);

}

 

[Nekiro]

You have to get current player target or add the effect somewhere where you know who is the target. "getPosition()" used in player.cpp will return player position not the target position.

Code for tfs 1.x.

if (Creature* target = getAttackedCreature()) {
    g_game.addMagicEffect(target->getPosition(), MAGIC_EFFECT_MIRRORVERTICAL);
}

 

[boxxer321]

You have to get current player target or add the effect somewhere where you know who is the target. "getPosition()" used in player.cpp will return player position not the target position.

if (Creature* target = getAttackedCreature()) {
    g_game.addMagicEffect(target->getPosition(), MAGIC_EFFECT_MIRRORVERTICAL);
}

sorry, but this happened

1>..\player.cpp(5325): error C2662: 'Creature::getAttackedCreature' : cannot convert 'this' pointer from 'const Player' to 'Creature &'
1> Conversion loses qualifiers
1>..\player.cpp(5330): fatal error C1075: end of file found before the left brace '{' at '..\player.cpp(5324)' was matched

 

[Infernum]

what version of TFS are you using?

 

[boxxer321]

what version of TFS are you using?

TFS 0.4
8.60

 

[boxxer321]

@Static_ some idea?

 

[Sarah Wesker]

void Player::sendCritical() const
{
    if(g_config.getBool(ConfigManager::DISPLAY_CRITICAL_HIT)){
        if(!attackedCreature){
            return;
        }

        g_game.addAnimatedText(attackedCreature->getPosition(), COLOR_DARKRED, "CRITICAL!");
     }
}