Ramirow
Veteran OT User
- Joined
- Aug 22, 2009
- Messages
- 585
- Solutions
- 15
- Reaction score
- 302
- Location
- Argentina
- YouTube
- ramirogrant
First of all, I make this thread because I was struggling to add a new skill that I could show using bars on the skill section of the client.
I know this pieces of code are not something really complex and I only post it in case someone is struggling like I did with this issue, will also create a thread on how to display it on OtClient. (Show additional skills on client (https://otland.net/threads/show-additional-skills-on-client.265785/))
This will create a skill that has all working functions for it (addSkillTries, getSkillLevel and so on) BUT you need to code, be it in Lua or in C++, how the player is supposed to advance or gain experience in the skill itself.
I will use "Runecraft" as an example skill. With that said, let's start.
tools.cpp
luascript.cpp
Items.cpp
iologindata.cpp
condition.cpp
items.h
enums.h
vocation.h
vocation.cpp
Well, that should be about it, hope it's useful to someone. If you need any help I would answer to the best of my knowledge.
If you need to create a new database you can add this to your schema.sql:
Again, can't use the correct symbol, please careful about that.
Or you can run this sql query on an existing database:
I know this pieces of code are not something really complex and I only post it in case someone is struggling like I did with this issue, will also create a thread on how to display it on OtClient. (Show additional skills on client (https://otland.net/threads/show-additional-skills-on-client.265785/))
This will create a skill that has all working functions for it (addSkillTries, getSkillLevel and so on) BUT you need to code, be it in Lua or in C++, how the player is supposed to advance or gain experience in the skill itself.
I will use "Runecraft" as an example skill. With that said, let's start.
tools.cpp
Search for this line:
And under it paste:
Code:
case SKILL_FISHING:
return "fishing";
Code:
case SKILL_RUNECRAFT:
return "runecraft";luascript.cpp
Search for this line:
And under it paste:
Now search for
And paste this under that line:
registerEnum(CONDITION_PARAM_SKILL_FISHING)And under it paste:
Code:
registerEnum(CONDITION_PARAM_SKILL_RUNECRAFT)
registerEnum(CONDITION_PARAM_SKILL_RUNECRAFTPERCENT)Now search for
registerEnum(SKILL_FISHING)And paste this under that line:
registerEnum(SKILL_RUNECRAFT)Items.cpp
Search for this line:
Right under it paste:
Now look for:
And under it paste:
{"skillfish", ITEM_PARSE_SKILLFISH},Right under it paste:
{"skillrunecraft", ITEM_PARSE_SKILLRUNECRAFT},Now look for:
Code:
case ITEM_PARSE_SKILLFISH: {
abilities.skills[SKILL_FISHING] = pugi::cast<int32_t>(valueAttribute.value());
break;
}
Code:
case ITEM_PARSE_SKILLRUNECRAFT: {
abilities.skills[SKILL_RUNECRAFT] = pugi::cast<int32_t>(valueAttribute.value());
break;
}iologindata.cpp
Search for:
Pay attention to the query some lines below. Replace
For:
NOTE: I can't seem to use the symbol it should contain, just don't use this
Search for:
Now look for:
And replace the entire line with
Just under it you will find this line:
Replace the entire line with:
Now look for:
And under that line paste:
NOTE: Same as before, had to use
bool IOLoginData::loadPlayerById(Player* player, uint32_t id)Pay attention to the query some lines below. Replace
'skill_fishing', 'skill_fishing_tries',For:
'skill_fishing', 'skill_fishing_tries', 'skill_runecraft', 'skill_runecraft_tries',NOTE: I can't seem to use the symbol it should contain, just don't use this
' and use the ones you see in the query.Search for:
bool IOLoginData::loadPlayerByName(Player* player, const std::string& name) and repeat the same as before (Replace the query lines)Now look for:
static const std::string skillNames[]And replace the entire line with
static const std::string skillNames[] = {"skill_fist", "skill_club", "skill_sword", "skill_axe", "skill_dist", "skill_shielding", "skill_fishing", "skill_runecraft"};Just under it you will find this line:
static const std::string skillNameTries[]Replace the entire line with:
static const std::string skillNameTries[] = {"skill_fist_tries", "skill_club_tries", "skill_sword_tries", "skill_axe_tries", "skill_dist_tries", "skill_shielding_tries", "skill_fishing_tries", "skill_runecraft_tries"};Now look for:
player->skills[SKILL_FISHING].triesAnd under that line paste:
Code:
query << "'skill_runecraft' = " << player->skills[SKILL_RUNECRAFT].level << ',';
query << "'skill_runecraft_tries' = " << player->skills[SKILL_RUNECRAFT].tries << ',';' instead of the actual symbol, please remember to use the correct one.condition.cpp
Search for:
And under it paste:
Code:
case CONDITION_PARAM_SKILL_FISHINGPERCENT: {
skillsPercent[SKILL_FISHING] = value;
return true;
}
Code:
case CONDITION_PARAM_SKILL_RUNECRAFT: {
skills[SKILL_RUNECRAFT] = value;
return true;
}
case CONDITION_PARAM_SKILL_RUNECRAFTPERCENT: {
skillsPercent[SKILL_RUNECRAFT] = value;
return true;
}items.h
Search for:
And under it paste:
ITEM_PARSE_SKILLFISH,And under it paste:
ITEM_PARSE_SKILLRUNECRAFT,enums.h
Search for:
And under it paste:
After that search for:
And under it paste:
NOTE: You will have to set
Finally, where it says
CONDITION_PARAM_DISABLE_DEFENSE = 47,And under it paste:
Code:
CONDITION_PARAM_SKILL_RUNECRAFT = 48,
CONDITION_PARAM_SKILL_RUNECRAFTPERCENT = 49,After that search for:
SKILL_FISHING = 6,And under it paste:
SKILL_RUNECRAFT = 7,NOTE: You will have to set
SKILL_MAGLEVEL and SKILL_LEVEL from 7-8 to 8-9 in their values (So id 7 is free for our new skill)Finally, where it says
SKILL_LAST = SKILL_FISHING change it to SKILL_LAST = SKILL_RUNECRAFTvocation.h
Find
float skillMultipliers[SKILL_LAST + 1] = {1.5f, 2.0f, 2.0f, 2.0f, 2.0f, 1.5f, 1.1f}; and replace it with float skillMultipliers[SKILL_LAST + 1] = {1.5f, 2.0f, 2.0f, 2.0f, 2.0f, 1.5f, 1.1f};vocation.cpp
Search for
Change it to
uint32_t Vocation::skillBase[SKILL_LAST + 1] = {50, 50, 50, 50, 30, 100, 20};Change it to
uint32_t Vocation::skillBase[SKILL_LAST + 1] = {50, 50, 50, 50, 30, 100, 20, 20};Well, that should be about it, hope it's useful to someone. If you need any help I would answer to the best of my knowledge.
If you need to create a new database you can add this to your schema.sql:
Code:
'skill_runecraft' int(10) unsigned NOT NULL DEFAULT 10,
'skill_runecraft_tries' bigint(20) unsigned NOT NULL DEFAULT 0,Or you can run this sql query on an existing database:
Code:
ALTER TABLE players
ADD COLUMN skill_runecraft int(10) unsigned NOT NULL DEFAULT 10,
ADD COLUMN skill_runecraft_tries bigint(20) unsigned NOT NULL DEFAULT 0;
Last edited:
