• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!
  • New resources must be posted under Resources tab. A discussion thread will be created automatically, you can't open threads manually anymore.

Feature [TFS 1.3] Adding New Skills

Evil Puncker said:
show us the script that you are using to add the skill tries
Click to expand...
mini request - since compiling is pain as well as skilltries is it possible to create a skill similar that advance by chance? similar to stages?
e.g.:

Coding skill is 1, you attempt to code a scroll... 50% to level up.
Coding skill is 10, you attempt to code a scroll... 10% to level up.
Coding skill is 100, 0.005% chance coding tible will increase coding skill.

(pls)
 
I maked all like in tutorial, but i got two errors..
How it's possible, if i capy/paste your codes? :(

error C2196: case value 'CONDITION_PARAM_SKILL_RUNECRAFT' already used
error C2196: case value 'CONDITION_PARAM_SKILL_RUNECRAFTPERCENT' already used
 
Dran Ryszard said:
I maked all like in tutorial, but i got two errors..
How it's possible, if i capy/paste your codes? :(

error C2196: case value 'CONDITION_PARAM_SKILL_RUNECRAFT' already used
error C2196: case value 'CONDITION_PARAM_SKILL_RUNECRAFTPERCENT' already used
Click to expand...
you added these entries twice
 
Evil Puncker said:
what tutorial are you using? and what tfs are you using?

github.com

New skill · Pull Request #4503 · otland/forgottenserver

Pull Request Prelude I have followed proper The Forgotten Server code styling. I have read and understood the contribution guidelines before making this PR. I am aware that this PR may be clo...
github.com github.com
Click to expand...

Tutorial from first post? 😅 I dont remember but its 1.3 or 1.5

//edit

@Evil Puncker thanks, i was check all files again with your tutorial on github, and in file enums.h i have more lines than he posted in tutorial, so i think im using tfs 1.5
 
Last edited:
Have added 2 new skills it works, but having some trouble it appears when log out and login again the 2 skills are doing ping pong, if runecraft has skill 15, and reliccraft has skill 10, when i log in again reliccraft has skill 15 and runecraft skill 10 anyone experienced same issue ?
Database also does the ping pong , one time reliccraft as 15, log out, check runecraft has 10 and viceversa
 
Last edited:
Ramirow said:
vocation.h
Find float skillMultipliers[SKILL_LAST + 1] = {1.5f, 2.0f, 2.0f, 2.0f, 2.0f, 1.5f, 1.1f}; and replace it with
float skillMultipliers[SKILL_LAST + 1] = {1.5f, 2.0f, 2.0f, 2.0f, 2.0f, 1.5f, 1.1f};
Click to expand...
Hi there, i think theres something missing, am i wrong? @Ramirow
 
Blasphemy said:
Hi there, i think theres something missing, am i wrong? @Ramirow
Click to expand...

In my case it wasn't
Code: 
float skillMultipliers[SKILL_LAST + 1] = {1.5f, 2.0f, 2.0f, 2.0f, 2.0f, 1.5f, 1.1f};
but
Line 108:
Code: 
double skillMultipliers[SKILL_LAST + 1] = {1.5, 2.0, 2.0, 2.0, 2.0, 1.5, 1.1, 1.1, 1.1, 1.1, 1.1}

But just add 1.1 or whatever value behind it per new skill you wish to add
 
Last edited:
Banyato said:
Have added 2 new skills it works, but having some trouble it appears when log out and login again the 2 skills are doing ping pong, if runecraft has skill 15, and reliccraft has skill 10, when i log in again reliccraft has skill 15 and runecraft skill 10 anyone experienced same issue ?
Database also does the ping pong , one time reliccraft as 15, log out, check runecraft has 10 and viceversa
Click to expand...
From the time I tested it years ago (Tfs 1.3) I had like 4-5 skills all working without any issue. You may want to check Evil Puncker's work HERE as the written tutorial I made is kinda hard to follow. Recheck what you've done already and see if something is missing.


Blasphemy said:
Hi there, i think theres something missing, am i wrong? @Ramirow
Click to expand...
In fact, yeah, couldn't edit the op but you should add a numeric value for the new skill to use.
In case you're adding a new skill the line should look something like this:
C++: 
float skillMultipliers[SKILL_LAST + 1] = {1.5f, 2.0f, 2.0f, 2.0f, 2.0f, 1.5f, 1.1f, 1.1f};
Notice there's one more multiplier (8 now, instead of the original 7). The value of it is for you to choose.
 
Ramirow said:
From the time I tested it years ago (Tfs 1.3) I had like 4-5 skills all working without any issue. You may want to check Evil Puncker's work HERE as the written tutorial I made is kinda hard to follow. Recheck what you've done already and see if something is missing.



In fact, yeah, couldn't edit the op but you should add a numeric value for the new skill to use.
In case you're adding a new skill the line should look something like this:
C++: 
float skillMultipliers[SKILL_LAST + 1] = {1.5f, 2.0f, 2.0f, 2.0f, 2.0f, 1.5f, 1.1f, 1.1f};
Notice there's one more multiplier (8 now, instead of the original 7). The value of it is for you to choose.
Click to expand...
Yup,

I am not sure, but, in case of login logout i was thinking about iologin... so i tried to add skills in order as it's the list of skills, id 7, id8, id9... but nothing. I have created a new one, and this one work perfect, strange situation, im going to revert again everything and check, i know it works since i used already the tutorial for add skills, but just i change TFS version.
 
instead of a skill is there a way to add a new STAT for player? basing it of from the "Cap" stat of the player, can we create one called "Newstat"?
 
maxsaenz95 said:
instead of a skill is there a way to add a new STAT for player? basing it of from the "Cap" stat of the player, can we create one called "Newstat"?
Click to expand...
Certainly possible, just not the thread to ask it in.
I suggest opening a new thread specifically for this, or look around on the forums, thousands of topics on attributes and how to add them.
 
Hello, for better save new skill
Example for runecraft:

TESTED ON TFS 1.4.2

Open data/migrations/16.lua and replace code with it:
db.query("ALTER TABLE players ADD skill_fist int unsigned NOT NULL DEFAULT 10, ADD skill_fist_tries bigint unsigned NOT NULL DEFAULT 0, ADD skill_club int unsigned NOT NULL DEFAULT 10, ADD skill_club_tries bigint unsigned NOT NULL DEFAULT 0, ADD skill_sword int unsigned NOT NULL DEFAULT 10, ADD skill_sword_tries bigint unsigned NOT NULL DEFAULT 0, ADD skill_axe int unsigned NOT NULL DEFAULT 10, ADD skill_axe_tries bigint unsigned NOT NULL DEFAULT 0, ADD skill_dist int unsigned NOT NULL DEFAULT 10, ADD skill_dist_tries bigint unsigned NOT NULL DEFAULT 0, ADD skill_shielding int unsigned NOT NULL DEFAULT 10, ADD skill_shielding_tries bigint unsigned NOT NULL DEFAULT 0, ADD skill_fishing int unsigned NOT NULL DEFAULT 10, ADD skill_fishing_tries bigint unsigned NOT NULL DEFAULT 0, ADD skill_runecraft int unsigned NOT NULL DEFAULT 10, ADD skill_runecraft_tries bigint unsigned NOT NULL DEFAULT 0")
db.query("UPDATE players SET skill_fist = (SELECT value FROM player_skills WHERE player_id = id AND skillid = 0), skill_fist_tries = (SELECT count FROM player_skills WHERE player_id = id AND skillid = 0), skill_club = (SELECT value FROM player_skills WHERE player_id = id AND skillid = 1), skill_club_tries = (SELECT count FROM player_skills WHERE player_id = id AND skillid = 1), skill_sword = (SELECT value FROM player_skills WHERE player_id = id AND skillid = 2), skill_sword_tries = (SELECT count FROM player_skills WHERE player_id = id AND skillid = 2), skill_axe = (SELECT value FROM player_skills WHERE player_id = id AND skillid = 3), skill_axe_tries = (SELECT count FROM player_skills WHERE player_id = id AND skillid = 3), skill_dist = (SELECT value FROM player_skills WHERE player_id = id AND skillid = 4), skill_dist_tries = (SELECT count FROM player_skills WHERE player_id = id AND skillid = 4), skill_shielding = (SELECT value FROM player_skills WHERE player_id = id AND skillid = 5), skill_shielding_tries = (SELECT count FROM player_skills WHERE player_id = id AND skillid = 5), skill_fishing = (SELECT value FROM player_skills WHERE player_id = id AND skillid = 6), skill_fishing_tries = (SELECT count FROM player_skills WHERE player_id = id AND skillid = 6), skill_runecraft = (SELECT value FROM player_skills WHERE player_id = id AND skillid = 7), skill_runecraft_tries = (SELECT count FROM player_skills WHERE player_id = id AND skillid = 7)")

And go now to data/global.lua
Find:
Code: 
`p`.`skill_shielding`,
`p`.`skill_fishing`,
Replace with:
Code: 
`p`.`skill_shielding`,
`p`.`skill_fishing`,
`p`.`skill_runecraft`,
Find:
Code: 
["skill_shielding"] = result.getNumber(query, "skill_shielding"),
["skill_fishing"] = result.getNumber(query, "skill_fishing"),
And replace with:
Code: 
["skill_shielding"] = result.getNumber(query, "skill_shielding"),
["skill_fishing"] = result.getNumber(query, "skill_fishing"),
["skill_runecraft"] = result.getNumber(query, "skill_runecraft"),

@Paxiz -- for better search

@Ramirow can you check it?
 
Last edited:
hi, can I add that runecraft to login.lua?
I wanted to use it, as skill for energy protection (and skilling by atack from energy)

So how to write it i login lua to check player skill lvl and after energy attack add tries and use a % less from energy damage based on that skill lvl?

Can someone help in that?

something like that will do work?

LUA: 
function onTakeDamage(player, attacker, damage, damageType)

    if damageType == COMBAT_ENERGYDAMAGE then
        local runecraftSkill = player:getSkillLevel(SKILL_RUNECRAFT)

        local damageReduction = runecraftSkill * 0.5

        local reducedDamage = damage - (damage * (damageReduction / 100))

        reducedDamage = math.max(0, reducedDamage)

        local triesToAdd = math.floor(damage / 100)

        player:addSkillTries(SKILL_RUNECRAFT, triesToAdd)

        player:removeHealth(damage - reducedDamage)
        attacker:say(player:getName() .. " took reduced energy damage due to runecraft skill!", TALKTYPE_ORANGE_1)
        
        print(player:getName() .. " received " .. reducedDamage .. " energy damage after runecraft skill reduction.")
    end

    return true
end
 
Last edited:
PuszekLDZ said:
hi, can I add that runecraft to login.lua?
I wanted to use it, as skill for energy protection (and skilling by atack from energy)

So how to write it i login lua to check player skill lvl and after energy attack add tries and use a % less from energy damage based on that skill lvl?

Can someone help in that?

something like that will do work?

LUA: 
function onTakeDamage(player, attacker, damage, damageType)

    if damageType == COMBAT_ENERGYDAMAGE then
        local runecraftSkill = player:getSkillLevel(SKILL_RUNECRAFT)

        local damageReduction = runecraftSkill * 0.5

        local reducedDamage = damage - (damage * (damageReduction / 100))

        reducedDamage = math.max(0, reducedDamage)

        local triesToAdd = math.floor(damage / 100)

        player:addSkillTries(SKILL_RUNECRAFT, triesToAdd)

        player:removeHealth(damage - reducedDamage)
        attacker:say(player:getName() .. " took reduced energy damage due to runecraft skill!", TALKTYPE_ORANGE_1)
       
        print(player:getName() .. " received " .. reducedDamage .. " energy damage after runecraft skill reduction.")
    end

    return true
end
Click to expand...
You're on the right track from what I remember, It's been years since I had a working server but I did something like that in creaturescripts, onStatsChange function.
You should look for help in the Support Board if you can't get it to work, but again, you're in the right track.
 
PuszekLDZ said:
omething like that will do work?
Click to expand...
Attached is the tutorial guide on how to properly implement the script. It is essential that you use the 'onHealthChange' and 'onManaChange' functions for handling damage reduction, damage amplification, and other related effects. Below, I’ve included links that will help you better understand how to structure and write the script correctly.
docs.otland.net

CreatureEvent | OTS Guide

docs.otland.net docs.otland.net

Evan

Post in thread '[TFS 1.0] Critical Hit % - Permanent'

Okay, prepare to be educated!

First off, some notes:
  • onHealthChange() and onManaChange() events are only called when health and mana are changed, respectively!
    • Yes, that means if there is a poff/spark, onHealthChange()/onManaChange() will never be called!
  • All parameters MUST be used or it will not work!
    • Do not worry about trying to figure out what to put if you can't think of anything, they have default values, just need to use the names alone!
  • Be smart, please remember this is called every time when...
  • Like
  • Love
 

Similar threads

Crevasse
Feature Monster Skill Advancement System
2
Replies
36
Views
3K
kay
kay
Back
Top