• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Question about GitHub

andu

Sold 649 scripts, 25 maps and 9 events!
Joined
Aug 7, 2009
Messages
976
Solutions
17
Reaction score
368
GitHub
olrios
Twitch
jamagowy
I forked forgottenserver from otland/forgottenserver (https://github.com/otland/forgottenserver) and I'm using GitHub Desktop to upload changes to the server.
But there is a problem.

When I choose my fork's repository "olrios / forgottenserver" and I commit and fetch something then all of that is going to otland/forgottenserver.

But when I choose otland/forgottenserver then all changes are going to my github account olrios.

How to fix this?

1575473983103.png

1575475025431.png
 
Solution
Once you commit you have to push origin at the top right where the refresh button usually is.

The new commits you're adding are being added to your PR because that's how it works; you're still editing the same branch you made to submit a PR so it'll keep adding those changes as long as you keep committing to the repo. That's why you're supposed to create a new branch for each PR you want to do, not throw all of your changes onto 1 branch (you can base a new branch off of a previous one if you still want the old changes)
Then why nothing is going to olrios/forgottenserver? I did like ~10 commits and only 1 appeared. Rest went to my pull request I made on otland/forgottenserver

Searched some forums and found I'm not the only one who have this issue. Maybe bug is with branch cfg.


1575475339562.png
 
Once you commit you have to push origin at the top right where the refresh button usually is.

The new commits you're adding are being added to your PR because that's how it works; you're still editing the same branch you made to submit a PR so it'll keep adding those changes as long as you keep committing to the repo. That's why you're supposed to create a new branch for each PR you want to do, not throw all of your changes onto 1 branch (you can base a new branch off of a previous one if you still want the old changes)
 
Last edited:
Solution
Think harder. I fixed the issue with the branch by following help from stackoverflow

@Delusion this is a issue when you made a new branch for pull request and then you move changes to new branch which isn't for pr. but all new work is still going to old pr becouse gd cannot handle with file privilages on pc. Launching gd with admin rights fixing the problem.

Thanks anyway!

Btw was talking about my 4d old pr
1575476521767.png
 
Think harder. I fixed the issue with the branch by following help from stackoverflow

@Delusion this is a issue when you made a new branch for pull request and then you move changes to new branch which isn't for pr. but all new work is still going to old pr becouse gd cannot handle with file privilages on pc. Launching gd with admin rights fixing the problem.

Thanks anyway!

Btw was talking about my 4d old pr
View attachment 40710
I think you caught my answer before I realized what was actually happening and edited my post accordingly. You should still be creating a new branch regardless if it's "fixed", because your next PR will have all of those changes made to your custom branch, instead of the commits you actually want to PR.
 
Back
Top