Exit Character

[IgoR lYCAN]

Based on TFS 1.3
When You made exit with "battle" <- ( -> Without pz locked. <- )

The character doenst logout!
It should after 1 minute exited.

 

[IgoR lYCAN]

up

 

[Hyresu]

Can you post your player.cpp?

 

[IgoR lYCAN]

Can you post your player.cpp?

cant post everything :/

justtell me wich part you want it

 

[Evil Puncker]

Can you post your player.cpp?

opentibiabr/otservbr-global

OTServBR-Global 12x for OpenTibia community. https://forums.otserv.com.br - opentibiabr/otservbr-global

github.com

 

[IgoR lYCAN]

opentibiabr/otservbr-global

OTServBR-Global 12x for OpenTibia community. https://forums.otserv.com.br - opentibiabr/otservbr-global

github.com

Yes, this one is the base that i use.

 

[IgoR lYCAN]

The problem is exactly this :

When I exit, with battle ( normal battle )



The character doenst logout, if there is monsters on his screen <--

After he lose the battle, the character logout.

But the thing is: if you exit, with these conditions, the character should logout after 60 seconds.

 

[IgoR lYCAN]

up

 

[Perun]

up

void Player::sendPing()

here you can see

if (noPongTime >= 60000 && canLogout()) {
        if (g_creatureEvents->playerLogout(this)) {
            if (client) {
                client->logout(true, true);
            } else {
                g_game.removeCreature(this, true);
            }
        }
    }

so you need to look at canLogout func:

bool Player::canLogout()
{
    if (isConnecting) {
        return false;
    }

    if (getTile()->hasFlag(TILESTATE_NOLOGOUT)) {
        return false;
    }

    if (getTile()->hasFlag(TILESTATE_PROTECTIONZONE)) {
        return true;
    }

    return !isPzLocked() && !hasCondition(CONDITION_INFIGHT);
}

which says

return !isPzLocked() && !hasCondition(CONDITION_INFIGHT);

so you can just remove

 && !hasCondition(CONDITION_INFIGHT)

what is not good idea in my opinion cuz a few bad things can happen then

 

[IgoR lYCAN]

void Player::sendPing()

here you can see

if (noPongTime >= 60000 && canLogout()) {
        if (g_creatureEvents->playerLogout(this)) {
            if (client) {
                client->logout(true, true);
            } else {
                g_game.removeCreature(this, true);
            }
        }
    }

so you need to look at canLogout func:

bool Player::canLogout()
{
    if (isConnecting) {
        return false;
    }

    if (getTile()->hasFlag(TILESTATE_NOLOGOUT)) {
        return false;
    }

    if (getTile()->hasFlag(TILESTATE_PROTECTIONZONE)) {
        return true;
    }

    return !isPzLocked() && !hasCondition(CONDITION_INFIGHT);
}

which says

return !isPzLocked() && !hasCondition(CONDITION_INFIGHT);

so you can just remove

 && !hasCondition(CONDITION_INFIGHT)

what is not good idea in my opinion cuz a few bad things can happen then

Which kinda of problems this config avoids?

You recommend dont change it?

 

[IgoR lYCAN]

@Perun ? '---'

It worked;

but
Which kinda of problems this config avoids?

You recommend dont change it?

 

[Rodo]

@Perun ? '---'

It worked;

but
Which kinda of problems this config avoids?

You recommend dont change it?

Hey IgoR lYCAN, I know this is an old post but I just want to add that if you remove that condition players would be able to be logged out during a battle with any monster or player, even if this player is PK.

Your character was not being logged out due to the conditions shared by Perun, you could try debugging the project to make sure which one is preventing the disconnection, seems like the player is attacking or being attacked, I use TFS 1.3 and have not seen this issue