TFS 1.X+ Vocation(id or name)

[roriscrave]

I created a code where the player writes in a letter the vocation he wants to be.

function onTextEdit(player, item, text)
        if Vocation(text) then
            player:setVocation(text)
        else
            --Vocation don't exist
            return false
        end
    return true
end

but if player open a label, and write wrong vocation, it dont return false, it return error, exemple, if a player write "Sorqcerer".
Error is here, if text isnt a valid vocation, it dont return 'nil', it return error

Vocation(text)

 

[Leo32]

No need to open up another support thread.

TFS 1.X+ - tfs 1.3open label, type a name of vocation, and press OK

Hello Guys, i'm using tfs 1.3 for tibia 8.6. I'm trying to make a script, that the player opens the label, write the name of the vocation you want to change and when he presses OK he changes his vocation, is it possible? exemple: if a sorcerer open a label and type elite sorcerer (new voc of my...

otland.net

 

[roriscrave]

No need to open up another support thread.

TFS 1.X+ - tfs 1.3open label, type a name of vocation, and press OK

Hello Guys, i'm using tfs 1.3 for tibia 8.6. I'm trying to make a script, that the player opens the label, write the name of the vocation you want to change and when he presses OK he changes his vocation, is it possible? exemple: if a sorcerer open a label and type elite sorcerer (new voc of my...

otland.net

Because i cant remove "solved" for another thread

 

[Leo32]

So it should be working.
It just throws the warning.

Validate vocations a different way then:

local validVocations = {
    "sorcerer",
    "druid",
    "paladin",
    "knight",
    "master sorcerer",
    "elder druid",
    "royal paladin",
    "elite knight",
}
function onTextEdit(player, item, text)
    local vocation = text:gsub('^%s*(.-)%s*$', '%1'):lower() -- trim the input text and convert to lower-case
    if table.contains(validVocations, vocation) then
        player:setVocation(vocation)
    else
        --Vocation don't exist
        return false
    end
    return true
end

forgottenserver/data/global.lua at 23438962cf3e5ae40243e7e2c8dc3173095fd77b · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[roriscrave]

So it should be working.
It just throws the warning.

Validate vocations a different way then:

I liked your post because it really is one way to solve it.
But I believe that the most certain thing would be to make Vocation (invalidVoc) return false or 'nil', let's see if anyone can help us.

 

[Leo32]

Vocation(invalidVoc) will return a warning every single time, you cannot work around this in lua.
You would need to edit sources to remove the warning or re-write how it handles invalid params:

forgottenserver/src/vocation.cpp at 47e688092e10993e8201cea9e540680cc63a3f5b · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[roriscrave]

Vocation(invalidVoc) will return a warning every single time, you cannot work around this in lua.
You would need to edit sources to remove the warning or re-write how it handles invalid params:

forgottenserver/src/vocation.cpp at 47e688092e10993e8201cea9e540680cc63a3f5b · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

I will try to rewrite, if I can I post here, if anyone wants to help, feel free