Lyky
Well-Known Member
- Joined
- May 27, 2014
- Messages
- 295
- Solutions
- 8
- Reaction score
- 89
Hi got problem with Banker NPC [TFS 1.2]
Looks like isNumber isn't parsed or storage is missing?
- deposit isNumber gold
Used following npc banker:
@slawkens
NPC - Banker NPC For TFS
Error: (when player states: "depost 'x amount' gold")
Lua Script Error: [Npc interface]
data/npc/scripts/Bank.lua
nCreatureSay
data/lib/customFunctions.lua:3: attempt to call global 'isNumber' (a nil value)
stack traceback:
[C]: in function 'isNumber'
data/lib/customFunctions.lua:3: in function 'isValidMoney'
data/lib/customFunctions.lua:9: in function 'getMoneyCount'
data/npc/scripts/Bank.lua:70: in function 'callback'
data/npc/lib/npcsystem/npchandler.lua:384: in function 'onCreatureSay'
data/npc/scripts/Bank.lua:10: in function <data/npc/scripts/Bank.lua:10>
customFunctions.lua
npc/scripts/bank.lua
Looks like isNumber isn't parsed or storage is missing?
- deposit isNumber gold
Used following npc banker:
@slawkens
NPC - Banker NPC For TFS
Error: (when player states: "depost 'x amount' gold")
Lua Script Error: [Npc interface]
data/npc/scripts/Bank.lua
nCreatureSaydata/lib/customFunctions.lua:3: attempt to call global 'isNumber' (a nil value)
stack traceback:
[C]: in function 'isNumber'
data/lib/customFunctions.lua:3: in function 'isValidMoney'
data/lib/customFunctions.lua:9: in function 'getMoneyCount'
data/npc/scripts/Bank.lua:70: in function 'callback'
data/npc/lib/npcsystem/npchandler.lua:384: in function 'onCreatureSay'
data/npc/scripts/Bank.lua:10: in function <data/npc/scripts/Bank.lua:10>
customFunctions.lua
LUA:
--Basic
function isValidMoney(money)
return isNumber(money) and money > 0 and money < 4294967296
end
function getMoneyCount(string)
local b, e = string:find("%d+")
local money = b and e and tonumber(string:sub(b, e)) or -1
if isValidMoney(money) then
return money
end
return -1
end
function getMoneyWeight(money)
local gold = money
local crystal = math.floor(gold / 10000)
gold = gold - crystal * 10000
local platinum = math.floor(gold / 100)
gold = gold - platinum * 100
return (ItemType(2160):getWeight() * crystal) + (ItemType(2152):getWeight() * platinum) + (ItemType(2148):getWeight() * gold)
end
function getAccountNumberByPlayerName(name)
local player = Player(name)
if player then
return player:getAccountId()
end
local resultId = db.storeQuery("SELECT `account_id` FROM `players` WHERE `name` = " .. db.escapeString(name))
if resultId ~= false then
local accountId = result.getDataInt(resultId, "account_id")
result.free(resultId)
return accountId
end
return 0
end
-- Game --
function Game.getPlayersByIPAddress(ip, mask)
if not mask then mask = 0xFFFFFFFF end
local masked = bit.band(ip, mask)
local result = {}
for _, player in ipairs(Game.getPlayers()) do
if bit.band(player:getIp(), mask) == masked then
result[#result + 1] = player
end
end
return result
end
function Game.getPlayersByAccountNumber(accountNumber)
local result = {}
for _, player in ipairs(Game.getPlayers()) do
if player:getAccountId() == accountNumber then
result[#result + 1] = player
end
end
return result
end
function Game.getHouseByPlayerGUID(playerGUID)
for _, house in ipairs(Game.getHouses()) do
if house:getOwnerGuid() == playerGUID then
return house
end
end
return nil
end
-- Player --
function Player.withdrawMoney(self, amount)
local balance = self:getBankBalance()
if amount > balance or not self:addMoney(amount) then
return false
end
self:setBankBalance(balance - amount)
return true
end
function Player.depositMoney(self, amount)
if not self:removeMoney(amount) then
return false
end
self:setBankBalance(self:getBankBalance() + amount)
return true
end
function Player.transferMoneyTo(self, target, amount)
local balance = self:getBankBalance()
if amount > balance then
return false
end
local targetPlayer = Player(target)
if targetPlayer then
targetPlayer:setBankBalance(targetPlayer:getBankBalance() + amount)
else
if not playerExists(target) then
return false
end
db.query("UPDATE `players` SET `balance` = `balance` + '" .. amount .. "' WHERE `name` = " .. db.escapeString(target))
end
self:setBankBalance(self:getBankBalance() - amount)
return true
end
function Player.getBlessings(self)
local blessings = 0
for i = 1, 5 do
if self:hasBlessing(i) then
blessings = blessings + 1
end
end
return blessings
end
function Player.isMage(self)
return isInArray({1, 2, 5, 6}, self:getVocation():getId())
end
function Player.getHighestSkillLevel(self)
local ret = 0
local clubLevel = self:getSkillLevel(SKILL_CLUB)
local swordLevel = self:getSkillLevel(SKILL_SWORD)
local axeLevel = self:getSkillLevel(SKILL_AXE)
local distLevel = self:getSkillLevel(SKILL_DISTANCE)
if clubLevel > swordLevel and clubLevel > axeLevel then
ret = 1
elseif swordLevel > clubLevel and swordLevel > axeLevel then
ret = 2
elseif axeLevel > clubLevel and axeLevel > swordLevel then
ret = 3
elseif distLevel > swordLevel and distLevel > axeLevel and distLevel > clubLevel then
ret = 10
end
return self:getSkillLevel(ret)
end
function Player.isPromoted(self)
local vocation = self:getVocation()
if vocation:getId() == 0 or vocation:getPromotion():getId() == 0 then
return true
end
return false
end
function Player.addExperienceStage(self, experience, sendText, useMult)
if useMult then
experience = experience * Game.getExperienceStage(self:getLevel())
end
return self:addExperience(experience, sendText)
end
-- Tile --
function Tile.relocateTo(self, toPosition)
if self:getPosition() == toPosition then
return false
end
if not Tile(toPosition) then
return false
end
for i = self:getThingCount() - 1, 0, -1 do
local thing = self:getThing(i)
if thing then
if thing:isItem() then
if ItemType(thing:getId()):isMovable() then
thing:moveTo(toPosition)
end
elseif thing:isCreature() then
thing:teleportTo(toPosition)
end
end
end
return true
end
function Tile.isPz(self)
return self:hasFlag(TILESTATE_PROTECTIONZONE)
end
function Tile.isHouse(self)
local house = self:getHouse()
return house and true or false
end
-- Vocation --
function Vocation.getBase(self)
local demotion = self:getDemotion()
while demotion do
local tmp = demotion:getDemotion()
if not tmp then
return demotion
end
demotion = tmp
end
return self
end
function Vocation.getPromotionId(self)
local promotion = self:getPromotion()
return promotion and promotion:getId() or 0
end
-- Others --
function formatOsTime(time)
local time = time - os.time()
local hours = math.floor(time / 3600)
minutes = math.floor((time - (3600 * hours)) / 60)
return "" .. hours .. " hours and " .. minutes .. " minutes"
endnpc/scripts/bank.lua
LUA:
local config = {
transferDisabledVocations = {0} -- disable non vocation characters
}
local talkState = {}
local count = {}
local transfer = {}
local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)
function onCreatureAppear(cid) npcHandler:onCreatureAppear(cid) end
function onCreatureDisappear(cid) npcHandler:onCreatureDisappear(cid) end
function onCreatureSay(cid, type, msg) npcHandler:onCreatureSay(cid, type, msg) end
function onThink() npcHandler:onThink() end
if(not getPlayerBalance) then
getPlayerBalance = function(cid)
local result = db.getResult("SELECT `balance` FROM `players` WHERE `id` = " .. getPlayerGUID(cid))
if(result:getID() == -1) then
return false
end
local value = tonumber(result:getDataString("balance"))
result:free()
return value
end
doPlayerSetBalance = function(cid, balance)
db.executeQuery("UPDATE `players` SET `balance` = " .. balance .. " WHERE `id` = " .. getPlayerGUID(cid))
return true
end
doPlayerWithdrawMoney = function(cid, amount)
local balance = getPlayerBalance(cid)
if(amount > balance or not doPlayerAddMoney(cid, amount)) then
return false
end
doPlayerSetBalance(cid, balance - amount)
return true
end
doPlayerDepositMoney = function(cid, amount)
if(not doPlayerRemoveMoney(cid, amount)) then
return false
end
doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
return true
end
doPlayerTransferMoneyTo = function(cid, target, amount)
local balance = getPlayerBalance(cid)
if(amount > balance) then
return false
end
local tid = getPlayerByName(target)
if(tid > 0) then
doPlayerSetBalance(tid, getPlayerBalance(tid) + amount)
else
if(playerExists(target) == FALSE) then
return false
end
db.executeQuery("UPDATE `player_storage` SET `value` = `value` + '" .. amount .. "' WHERE `player_id` = (SELECT `id` FROM `players` WHERE `name` = '" .. escapeString(player) .. "') AND `key` = '" .. balance_storage .. "'")
end
doPlayerSetBalance(cid, getPlayerBalance(cid) - amount)
return true
end
end
local function getPlayerVocationByName(name)
local result = db.getResult("SELECT `vocation` FROM `players` WHERE `name` = " .. db.escapeString(name))
if(result:getID() == -1) then
return false
end
local value = result:getDataString("vocation")
result:free()
return value
end
local function isValidMoney(money)
return (isNumber(money) and money > 0 and money < 4294967296)
end
local function getCount(string)
local b, e = string:find("%d+")
local money = b and e and tonumber(string:sub(b, e)) or -1
if(isValidMoney(money)) then
return money
end
return -1
end
function greetCallback(cid)
talkState[cid], count[cid], transfer[cid] = 0, nil, nil
return true
end
function creatureSayCallback(cid, type, msg)
if(not npcHandler:isFocused(cid)) then
return false
end
---------------------------- help ------------------------
if msgcontains(msg, 'advanced') then
if isInArray(config.transferDisabledVocations, getPlayerVocation(cid)) then
selfSay("Once you are on the Tibian mainland, you can access new functions of your bank account, such as transferring money to other players safely or taking part in house auctions.", cid)
else
selfSay("Renting a house has never been this easy. Simply make a bid for an auction. We will check immediately if you have enough money.", cid)
end
talkState[cid] = 0
elseif msgcontains(msg, 'help') or msgcontains(msg, 'functions') then
selfSay("You can check the {balance} of your bank account, {deposit} money or {withdraw} it. You can also {transfer} money to other characters, provided that they have a vocation.", cid)
talkState[cid] = 0
elseif msgcontains(msg, 'bank') then
npcHandler:say("We can change money for you. You can also access your bank account.", cid)
talkState[cid] = 0
elseif msgcontains(msg, 'job') then
npcHandler:say("I work in this bank. I can change money for you and help you with your bank account.", cid)
talkState[cid] = 0
---------------------------- balance ---------------------
elseif msgcontains(msg, 'balance') then
selfSay("Your account balance is " .. getPlayerBalance(cid) .. " gold.", cid)
talkState[cid] = 0
---------------------------- deposit ---------------------
elseif msgcontains(msg, 'deposit all') and getPlayerMoney(cid) > 0 then
count[cid] = getPlayerMoney(cid)
if not isValidMoney(count[cid]) then
selfSay("Sorry, but you can't deposit that much.", cid)
talkState[cid] = 0
return false
end
if count[cid] < 1 then
selfSay("You don't have any money to deposit in you inventory..", cid)
talkState[cid] = 0
else
selfSay("Would you really like to deposit " .. count[cid] .. " gold?", cid)
talkState[cid] = 2
end
elseif msgcontains(msg, 'deposit') then
selfSay("Please tell me how much gold it is you would like to deposit.", cid)
talkState[cid] = 1
elseif talkState[cid] == 1 then
count[cid] = getCount(msg)
if isValidMoney(count[cid]) then
selfSay("Would you really like to deposit " .. count[cid] .. " gold?", cid)
talkState[cid] = 2
else
selfSay("Is isnt valid amount of gold to deposit.", cid)
talkState[cid] = 0
end
elseif talkState[cid] == 2 then
if msgcontains(msg, 'yes') then
if not doPlayerDepositMoney(cid, count[cid]) then
selfSay("You don\'t have enough gold.", cid)
else
selfSay("Alright, we have added the amount of " .. count[cid] .. " gold to your balance. You can withdraw your money anytime you want to. Your account balance is " .. getPlayerBalance(cid) .. ".", cid)
end
elseif msgcontains(msg, 'no') then
selfSay("As you wish. Is there something else I can do for you?", cid)
end
talkState[cid] = 0
---------------------------- withdraw --------------------
elseif msgcontains(msg, 'withdraw') then
selfSay("Please tell me how much gold you would like to withdraw.", cid)
talkState[cid] = 6
elseif talkState[cid] == 6 then
count[cid] = getCount(msg)
if isValidMoney(count[cid]) then
selfSay("Are you sure you wish to withdraw " .. count[cid] .. " gold from your bank account?", cid)
talkState[cid] = 7
else
selfSay("Is isnt valid amount of gold to withdraw.", cid)
talkState[cid] = 0
end
elseif talkState[cid] == 7 then
if msgcontains(msg, 'yes') then
if not doPlayerWithdrawMoney(cid, count[cid]) then
selfSay("There is not enough gold on your account. Your account balance is " .. getPlayerBalance(cid) .. ". Please tell me the amount of gold coins you would like to withdraw.", cid)
talkState[cid] = 0
else
selfSay("Here you are, " .. count[cid] .. " gold. Please let me know if there is something else I can do for you.", cid)
talkState[cid] = 0
end
elseif msgcontains(msg, 'no') then
selfSay("As you wish. Is there something else I can do for you?", cid)
talkState[cid] = 0
end
---------------------------- transfer --------------------
elseif msgcontains(msg, 'transfer') then
selfSay("Please tell me the amount of gold you would like to transfer.", cid)
talkState[cid] = 11
elseif talkState[cid] == 11 then
count[cid] = getCount(msg)
if getPlayerBalance(cid) < count[cid] then
selfSay("You dont have enough money on your bank account.", cid)
talkState[cid] = 0
return true
end
if isValidMoney(count[cid]) then
selfSay("Who would you like transfer " .. count[cid] .. " gold to?", cid)
talkState[cid] = 12
else
selfSay("Is isnt valid amount of gold to transfer.", cid)
talkState[cid] = 0
end
elseif talkState[cid] == 12 then
transfer[cid] = msg
if getCreatureName(cid) == transfer[cid] then
selfSay("Ekhm, You want transfer money to yourself? Its impossible!", cid)
talkState[cid] = 0
return true
end
if isInArray(config.transferDisabledVocations, getPlayerVocation(cid)) then
selfSay("Your vocation cannot transfer money.", cid)
talkState[cid] = 0
end
if playerExists(transfer[cid]) then
selfSay("So you would like to transfer " .. count[cid] .. " gold to \"" .. transfer[cid] .. "\" ?", cid)
talkState[cid] = 13
else
selfSay("Player with name \"" .. transfer[cid] .. "\" doesnt exist.", cid)
talkState[cid] = 0
end
elseif talkState[cid] == 13 then
if msgcontains(msg, 'yes') then
local targetVocation = getPlayerVocationByName(transfer[cid])
if not targetVocation or isInArray(config.transferDisabledVocations, targetVocation) or not doPlayerTransferMoneyTo(cid, transfer[cid], count[cid]) then
selfSay("This player does not exist on this world or have no vocation.", cid)
else
selfSay("You have transferred " .. count[cid] .. " gold to \"" .. transfer[cid] .."\".", cid)
transfer[cid] = nil
end
elseif msgcontains(msg, 'no') then
selfSay("As you wish. Is there something else I can do for you?", cid)
end
talkState[cid] = 0
---------------------------- money exchange --------------
elseif msgcontains(msg, 'change gold') then
npcHandler:say("How many platinum coins would you like to get?", cid)
talkState[cid] = 14
elseif talkState[cid] == 14 then
if getCount(msg) == -1 or getCount(msg) == 0 then
npcHandler:say("Hmm, can I help you with something else?", cid)
talkState[cid] = 0
else
count[cid] = getCount(msg)
npcHandler:say("So you would like me to change " .. count[cid] * 100 .. " of your gold coins into " .. count[cid] .. " platinum coins?", cid)
talkState[cid] = 15
end
elseif talkState[cid] == 15 then
if msgcontains(msg, 'yes') then
if doPlayerRemoveItem(cid, 2148, count[cid] * 100) then
doPlayerAddItem(cid, 2152, count[cid])
npcHandler:say("Here you are.", cid)
else
npcHandler:say("Sorry, you do not have enough gold coins.", cid)
end
else
npcHandler:say("Well, can I help you with something else?", cid)
end
talkState[cid] = 0
elseif msgcontains(msg, 'change platinum') then
npcHandler:say("Would you like to change your platinum coins into gold or crystal?", cid)
talkState[cid] = 16
elseif talkState[cid] == 16 then
if msgcontains(msg, 'gold') then
npcHandler:say("How many platinum coins would you like to change into gold?", cid)
talkState[cid] = 17
elseif msgcontains(msg, 'crystal') then
npcHandler:say("How many crystal coins would you like to get?", cid)
talkState[cid] = 19
else
npcHandler:say("Well, can I help you with something else?", cid)
talkState[cid] = 0
end
elseif talkState[cid] == 17 then
if getCount(msg) == -1 or getCount(msg) == 0 then
npcHandler:say("Hmm, can I help you with something else?", cid)
talkState[cid] = 0
else
count[cid] = getCount(msg)
npcHandler:say("So you would like me to change " .. count[cid] .. " of your platinum coins into " .. count[cid] * 100 .. " gold coins for you?", cid)
talkState[cid] = 18
end
elseif talkState[cid] == 18 then
if msgcontains(msg, 'yes') then
if doPlayerRemoveItem(cid, 2152, count[cid]) then
npcHandler:say("Here you are.", cid)
doPlayerAddItem(cid, 2148, count[cid] * 100)
else
npcHandler:say("Sorry, you do not have enough platinum coins.", cid)
end
else
npcHandler:say("Well, can I help you with something else?", cid)
end
talkState[cid] = 0
elseif talkState[cid] == 19 then
if getCount(msg) == -1 or getCount(msg) == 0 then
npcHandler:say("Hmm, can I help you with something else?", cid)
talkState[cid] = 0
else
count[cid] = getCount(msg)
npcHandler:say("So you would like me to change " .. count[cid] * 100 .. " of your platinum coins into " .. count[cid] .. " crystal coins for you?", cid)
talkState[cid] = 20
end
elseif talkState[cid] == 20 then
if msgcontains(msg, 'yes') then
if doPlayerRemoveItem(cid, 2152, count[cid] * 100) then
npcHandler:say("Here you are.", cid)
doPlayerAddItem(cid, 2160, count[cid])
else
npcHandler:say("Sorry, you do not have enough platinum coins.", cid)
end
else
npcHandler:say("Well, can I help you with something else?", cid)
end
talkState[cid] = 0
elseif msgcontains(msg, 'change crystal') then
npcHandler:say("How many crystal coins would you like to change into platinum?", cid)
talkState[cid] = 21
elseif talkState[cid] == 21 then
if getCount(msg) == -1 or getCount(msg) == 0 then
npcHandler:say("Hmm, can I help you with something else?", cid)
talkState[cid] = 0
else
count[cid] = getCount(msg)
npcHandler:say("So you would like me to change " .. count[cid] .. " of your crystal coins into " .. count[cid] * 100 .. " platinum coins for you?", cid)
talkState[cid] = 22
end
elseif talkState[cid] == 22 then
if msgcontains(msg, 'yes') then
if doPlayerRemoveItem(cid, 2160, count[cid]) then
npcHandler:say("Here you are.", cid)
doPlayerAddItem(cid, 2152, count[cid] * 100)
else
npcHandler:say("Sorry, you do not have enough crystal coins.", cid)
end
else
npcHandler:say("Well, can I help you with something else?", cid)
end
talkState[cid] = 0
elseif msgcontains(msg, 'change') then
npcHandler:say("There are three different coin types in Tibia: 100 gold coins equal 1 platinum coin, 100 platinum coins equal 1 crystal coin. So if you'd like to change 100 gold into 1 platinum, simply say '{change gold}' and then '1 platinum'.", cid)
talkState[cid] = 0
end
return true
end
npcHandler:setCallback(CALLBACK_GREET, greetCallback)
npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())
