OTClient Saved position of containers

[Crystals]

Hello I'm trying to find where or how to set it so that open backpacks are saved after logging out. It's a small thing, but it makes me happy

Theforgottenserver 1.4.2
otclientv8

 

[Fabi Marzan]

I thought I already had it included

Saving opened containers · otland/forgottenserver@df20cb5

A free and open-source MMORPG server emulator written in C++ - Saving opened containers · otland/forgottenserver@df20cb5

github.com

or

Saving opened backpacks and sending them onlogin · moviebr/baiakthunder@7aa792a

Baiak Thunder - 8.60 (TFS 1.3) for OpenTibia community. - Saving opened backpacks and sending them onlogin · moviebr/baiakthunder@7aa792a

github.com

 

[Crystals]

I saw that it was possible to do it somehow, probably without changing the src

 

[Gesior.pl]

probably without changing the src

List of 'open containers' is kept in C++ (forgottenserver/src/player.h at 1.4 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/1.4/src/player.h#L1200)).
You can't reopen containers without C++ changes. This change (TFS 1.6) should be compatible with 1.4 code:

Saving opened containers · otland/forgottenserver@df20cb5

A free and open-source MMORPG server emulator written in C++ - Saving opened containers · otland/forgottenserver@df20cb5

github.com

 

[Ciosny]

List of 'open containers' is kept in C++ (forgottenserver/src/player.h at 1.4 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/1.4/src/player.h#L1200)).
You can't reopen containers without C++ changes. This change (TFS 1.6) should be compatible with 1.4 code:

Saving opened containers · otland/forgottenserver@df20cb5

A free and open-source MMORPG server emulator written in C++ - Saving opened containers · otland/forgottenserver@df20cb5

github.com

If a genius writes so, it must be so

 

[Crystals]

List of 'open containers' is kept in C++ (forgottenserver/src/player.h at 1.4 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/1.4/src/player.h#L1200)).
You can't reopen containers without C++ changes. This change (TFS 1.6) should be compatible with 1.4 code:

Saving opened containers · otland/forgottenserver@df20cb5

A free and open-source MMORPG server emulator written in C++ - Saving opened containers · otland/forgottenserver@df20cb5

github.com

Hmmm, I did it, but suddenly a lot of errors appeared when trying to compile such as...

Błąd C2679 dwuargumentowy "=": nie znaleziono żadnego operatora, który przyjmuje prawostronny operand typu "bool" (lub nie istnieje akceptowalna konwersja) theforgottenserver C:\Forgottenserver testy\Kopia SRC\04.10.2024\src\item.h 327

Błąd C2365 "ATTR_OPENCONTAINER": zmiana definicji; definicja poprzednia była "moduł wyliczający" theforgottenserver

Błąd C2679 dwuargumentowy "=": nie znaleziono żadnego operatora, który przyjmuje prawostronny operand typu "double" (lub nie istnieje akceptowalna konwersja) theforgottenserver C:\Forgottenserver testy\Kopia SRC\04.10.2024\src\item.h 318

Błąd C2365 "ATTR_OPENCONTAINER": zmiana definicji; definicja poprzednia była "moduł wyliczający" theforgottenserver C:\Forgottenserver testy\Kopia SRC\04.10.2024\src\item.h 96

Błąd C2679 dwuargumentowy "=": nie znaleziono żadnego operatora, który przyjmuje prawostronny operand typu "int64_t" (lub nie istnieje akceptowalna konwersja) theforgottenserver C:\Forgottenserver testy\Kopia SRC\04.10.2024\src\item.h 309

 

[Crystals]

up

 

[ZiumZium]

List of 'open containers' is kept in C++ (forgottenserver/src/player.h at 1.4 · otland/forgottenserver (https://github.com/otland/forgottenserver/blob/1.4/src/player.h#L1200)).
You can't reopen containers without C++ changes. This change (TFS 1.6) should be compatible with 1.4 code:

Saving opened containers · otland/forgottenserver@df20cb5

A free and open-source MMORPG server emulator written in C++ - Saving opened containers · otland/forgottenserver@df20cb5

github.com

Hmmm i have one problem

"forgottenserver-1.4.2\src\iologindata.cpp(642,4): error C2065: "containers": undeclared identifier

Database& db = Database::getInstance();
for (const auto& it : itemList) {
    int32_t pid = it.first;
    Item* item = it.second;
    ++runningId;

    if (Container* container = item->getContainer()) {
        if (container->getIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER)) {
            container->setIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER, 0);
        }

        if (!openContainers.empty()) {
            for (const auto& its : openContainers) {
                auto openContainer = its.second;
                auto opcontainer = openContainer.container;

                if (opcontainer == container) {
                    container->setIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER, static_cast<int64_t>(its.first) + 1);
                    break;
                }
            }
        }

        containers.emplace_back(container, runningId);
    }

this: containers.emplace_back(container, runningId);

 

[ZiumZium]

up

 

[Gesior.pl]

error C2065: "containers": undeclared identifier

containers variable was defined in commit from 2021-09-18:

Optimize IOLoginData::saveItems by reducing number of allocations (#3… · otland/forgottenserver@a6ad4d6

…176)

github.com

TFS 1.4.0 was released on same day (2021-09-18). Maybe it was added after official TFS 1.4.0 was released or maybe you are using "TFS 1.4" downgrade (ex. 8.6) version, which uses TFS 1.3 as base, not TFS 1.4.

 

[ZiumZium]

containers variable was defined in commit from 2021-09-18:

Optimize IOLoginData::saveItems by reducing number of allocations (#3… · otland/forgottenserver@a6ad4d6

…176)

github.com

TFS 1.4.0 was released on same day (2021-09-18). Maybe it was added after official TFS 1.4.0 was released or maybe you are using "TFS 1.4" downgrade (ex. 8.6) version, which uses TFS 1.3 as base, not TFS 1.4.

Hmm Ok, I'll check it when I get home

i use this: Release The Forgotten Server 1.4.2 · otland/forgottenserver (https://github.com/otland/forgottenserver/releases/tag/v1.4.2)

Post automatically merged: Nov 6, 2024

 

[ZiumZium]

containers variable was defined in commit from 2021-09-18:

Optimize IOLoginData::saveItems by reducing number of allocations (#3… · otland/forgottenserver@a6ad4d6

…176)

github.com

TFS 1.4.0 was released on same day (2021-09-18). Maybe it was added after official TFS 1.4.0 was released or maybe you are using "TFS 1.4" downgrade (ex. 8.6) version, which uses TFS 1.3 as base, not TFS 1.4.

Ok, what you wrote worked.


It just started giving me errors with "subContainer"

Post automatically merged: Nov 7, 2024

ps. "}" I had it corrected in the file. But that wasn't what was causing the error

 

[ZiumZium]

any idea how to fix it?

 

[ZiumZium]

up

 

[ZiumZium]

up

 

[ZiumZium]

up

 

[ZiumZium]

up

 

[Just Pietros]

Is there something like this under TFS 1.2?