Solved Player walks over field

[czouski]

When rightclicking a corpse player walks over Fields or any other thing on the map.
is there any simple way to fix it?
for example walking with left click takes correct path and avoids things.
can anyone atleast point me in the right function as this stuff just seems scattered half of the time meaninglessly
fix:

//path finding fix for walking over fields.
    if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_BLOCKPATH)) {
        return RETURNVALUE_THEREISNOWAY;
    }

before fix:

Gyazo Screen Video

gyazo.com

after fix:

Gyazo Screen Video

gyazo.com

extra before clip:

Gyazo Screen Video

gyazo.com

extra after clip:

Gyazo Screen Video

gyazo.com

 

[czouski]

fixed tfs 1.4.2

const CreatureVector* creatures = getCreatures();
if (const Player* player = creature->getPlayer()) {
    if (creatures && !creatures->empty() && !hasBitSet(FLAG_IGNOREBLOCKCREATURE, flags) && !player->isAccessPlayer()) {
        for (const Creature* tileCreature : *creatures) {
            if (getGround() && (getGround()->getID() == 11063)) {
                return RETURNVALUE_NOTENOUGHROOM; // Prevent another player from standing on this tile
            }
            if (!player->canWalkthrough(tileCreature)) {
                return RETURNVALUE_NOTPOSSIBLE;
            }
        }
    }

    if (player->getParent() == nullptr && hasFlag(TILESTATE_NOLOGOUT)) {
        //player is trying to login to a "no logout" tile
        return RETURNVALUE_NOTPOSSIBLE;
    }
    //path finding fix for walking over fields.
    if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_BLOCKPATH)) {
        return RETURNVALUE_THEREISNOWAY;
    }

 

[czouski]

patch **

//path finding fix for walking over fields.

if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_MAGICFIELD)) {

    return RETURNVALUE_THEREISNOWAY;

}

because parcels etc was blocking.

 

[Madusa]

Explain the solution more because it does not work

const CreatureVector* creatures = getCreatures();
        if (const Player* player = creature->getPlayer()) {
            if (creatures && !creatures->empty() && !hasBitSet(FLAG_IGNOREBLOCKCREATURE, flags) && !player->isAccessPlayer()) {
                for (const Creature* tileCreature : *creatures) {
                    if (!player->canWalkthrough(tileCreature)) {
                        return RETURNVALUE_NOTPOSSIBLE;
                    }
                }
            }

            if (player->getParent() == nullptr && hasFlag(TILESTATE_NOLOGOUT)) {
                //player is trying to login to a "no logout" tile
                return RETURNVALUE_NOTPOSSIBLE;
            }
            //path finding fix for walking over fields.

            if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_MAGICFIELD)) {

                return RETURNVALUE_THEREISNOWAY;

            }

I added it and nothing happened
Tfs 1.5

 

[czouski]

Explain the solution more because it does not work

const CreatureVector* creatures = getCreatures();
        if (const Player* player = creature->getPlayer()) {
            if (creatures && !creatures->empty() && !hasBitSet(FLAG_IGNOREBLOCKCREATURE, flags) && !player->isAccessPlayer()) {
                for (const Creature* tileCreature : *creatures) {
                    if (!player->canWalkthrough(tileCreature)) {
                        return RETURNVALUE_NOTPOSSIBLE;
                    }
                }
            }

            if (player->getParent() == nullptr && hasFlag(TILESTATE_NOLOGOUT)) {
                //player is trying to login to a "no logout" tile
                return RETURNVALUE_NOTPOSSIBLE;
            }
            //path finding fix for walking over fields.

            if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_MAGICFIELD)) {

                return RETURNVALUE_THEREISNOWAY;

            }

I added it and nothing happened
Tfs 1.5

so if you use item from a far it calls query add and in query add if ur using pathfinding functions and the tile has magicfield it should return thereisnoway text instead of proceeding with walk unless there is way to get around the fields.

 

[Madusa]

I don't understand

 

[czouski]

I don't understand

then don't use it you don't need it.

 

[Madusa]

Haha, what nonsense, why do you publish failed code and say that you fixed it?

 

[czouski]

Haha, what nonsense, why do you publish failed code and say that you fixed it?

it works for me. and for 1.4.2 why do you try to put it into 1.5 and claim its not working?

 

[kibo433]

Explain the solution more because it does not work

const CreatureVector* creatures = getCreatures();
        if (const Player* player = creature->getPlayer()) {
            if (creatures && !creatures->empty() && !hasBitSet(FLAG_IGNOREBLOCKCREATURE, flags) && !player->isAccessPlayer()) {
                for (const Creature* tileCreature : *creatures) {
                    if (!player->canWalkthrough(tileCreature)) {
                        return RETURNVALUE_NOTPOSSIBLE;
                    }
                }
            }

            if (player->getParent() == nullptr && hasFlag(TILESTATE_NOLOGOUT)) {
                //player is trying to login to a "no logout" tile
                return RETURNVALUE_NOTPOSSIBLE;
            }
            //path finding fix for walking over fields.

            if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_MAGICFIELD)) {

                return RETURNVALUE_THEREISNOWAY;

            }

I added it and nothing happened
Tfs 1.5

I use TFS 1.5 (tibia 8.0), too and it works. Just only add:

//path finding fix for walking over fields.
    if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_BLOCKPATH)) {
        return RETURNVALUE_THEREISNOWAY;
    }

nothing more...

 

[czouski]

I use TFS 1.5 (tibia 8.0), too and it works. Just only add:

//path finding fix for walking over fields.
    if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_BLOCKPATH)) {
        return RETURNVALUE_THEREISNOWAY;
    }

nothing more...

but then player wont walk on top of crates boxes etc use TILESTATE_MAGICFIELD for proper anti field pathfinding** it was due to people receiving dmg from walking on them by accident

 

[kibo433]

but then player wont walk on top of crates boxes etc use TILESTATE_MAGICFIELD for proper anti field pathfinding** it was due to people receiving dmg from walking on them by accident

For me, this is sufficient. In Tibia version 7.4, when a parcel stood on the road, the message 'There is no way' also appeared. However, what I noticed is that in TFS, when we set follow directly on a creature, our character will run through a magic field, but when we set attack on a creature and the follow function, our character will not go through the magic field. No message is displayed either (it should again display 'There is no way').

Edit: Sorry, my mistake.
"when we set follow directly on a creature, our character will run through a magic field", that was a campfire, not magic field. Our character doesn't run through magic field, but the message still doesn't appear.

 

[czouski]

hey no problem you can always include both of the flags! or ignore the campfire via getId by retrieving Tile item

 

[abdala ragab]

Explain the solution more because it does not work

const CreatureVector* creatures = getCreatures();
        if (const Player* player = creature->getPlayer()) {
            if (creatures && !creatures->empty() && !hasBitSet(FLAG_IGNOREBLOCKCREATURE, flags) && !player->isAccessPlayer()) {
                for (const Creature* tileCreature : *creatures) {
                    if (!player->canWalkthrough(tileCreature)) {
                        return RETURNVALUE_NOTPOSSIBLE;
                    }
                }
            }

            if (player->getParent() == nullptr && hasFlag(TILESTATE_NOLOGOUT)) {
                //player is trying to login to a "no logout" tile
                return RETURNVALUE_NOTPOSSIBLE;
            }
            //path finding fix for walking over fields.

            if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_MAGICFIELD)) {

                return RETURNVALUE_THEREISNOWAY;

            }

I added it and nothing happened
Tfs 1.5

if (hasBitSet(FLAG_PATHFINDING, flags) && hasFlag(TILESTATE_MAGICFIELD)) {
                return RETURNVALUE_NOERROR;
            }