TFS 1.X+ Error starting http server

[Mjmackan]

Using the latest sources, after successfully compiling and running the server i get this print shown in console below and then the console exits.

-Mysql is set up.
-Website is set up.
-Ports are open(even tried to turn off firewall)

 

[Gesior.pl]

i get this print shown in console below and then the console exits.

Run console first (hold Shift and press right mouse button in empty space in TFS folder to show extra 'terminal' [bash/cmd/powershell] options) and then run TFS by command ex. .\theforgottenserver-x64.exe (PowerShell) or ./theforgottenserver-x64.exe (Git Bash).
Then it won't close terminal on error and you will see messages.

 

[Mjmackan]

Run console first (hold Shift and press right mouse button in empty space in TFS folder to show extra 'terminal' [bash/cmd/powershell] options) and then run TFS by command ex. .\theforgottenserver-x64.exe (PowerShell) or ./theforgottenserver-x64.exe (Git Bash).
Then it won't close terminal on error and you will see messages.

>> Starting HTTP server on 90.227.183.136:8080 with 1 threads.
PS C:\forgottenserver-1.6>

So many new things, what does this even do? Checks my ports and such? When i set the 'httpWorkers' to 0 it finally came to life but then i got a session error in mysql, not sure if thats cuz i run myaac and mehahclient which really not support 13.10 either of em.

Think I need to take a break into the sauna, I just wanted to mess with all the new features and thingys of TFS not spend hours on compiling and hosting hehe.

 

[Gesior.pl]

myaac

MyAAC does not work with TFS 1.6+ (EDIT: TFS 1.6 was released 5 days after commit that breaks login with MyAAC, so it's not only broken on 1.7, also on 1.6). No AAC works with newest TFS, since they implemented 'own' sessions key algorithm (12+ client feature processed by login.php of MyAAC), that works only with 'build in HTTP' login server. One that makes your server crash on start, if you don't disable it with httpWorkers = 0.

PR that broke compatibility with MyAAC has 12+ months:

Minimal HTTP login server (#4706) · otland/forgottenserver@ceb2a07

Adds a login http server which is build on boost-beast Co-authored-by: Mario <[email protected]>

github.com

It was reported as a problem 5 days after this PR:

[Bug]: Cant login to game world - "Malformed session key." · Issue #4739 · otland/forgottenserver

By submitting this bug issue, you agree to the following. This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for supp...

github.com

report was closed with 'go fix your acc. maker', but nobody worked on MyAAC update, as nobody hosts OTS based on TFS 1.6+ engine.

I tried to run TFS master around 2 months ago on Windows and I gave up after 1 hour of configuring all that crap.
In last weeks I made multiple PRs:

fix: Ubuntu 22.04 compilation (#4943) by gesior · Pull Request #4944 · otland/forgottenserver

Changes Proposed Fix Ubuntu 22.04 compilation with system libraries. offtop: It's impossible to compile TFS without HTTP server. You can disable it by setting port to 0 in config.lua, but it&#3...

github.com

fix: build problems (#4955 #4956) by gesior · Pull Request #4957 · otland/forgottenserver

This PR fixes build problems: TFS always builds with HTTP server disabled in C++ ( [Bug]: TFS always builds with build-in HTTP server disabled #4955 ), -DHTTP=ON and -DHTTP=OFF does not work, HTTP...

github.com

fix: load SQL config from config.lua (#4518) by gesior · Pull Request #4940 · otland/forgottenserver

Changes Proposed After changes, it loads config.lua config first, then loads env variables and if they are not empty, it overwrites config.lua values. Right now TFS loads env first, so to do not ov...

github.com

feat: run TFS in docker using docker-compose.yaml by gesior · Pull Request #4959 · otland/forgottenserver

All is described in docker/README.md. It's docker configuration made using docker-compose.yaml. It starts TFS, MariaDB and phpMyAdmin inside containers. You can connect to it from Tibia Client ...

github.com

feat: make HTTP listen on the same IP as OTS by gesior · Pull Request #4958 · otland/forgottenserver

This PR makes it possible to host OTS inside docker with working HTTP server. After changes from this commit (and #4957 ), you can run local server inside docker with server IP set to 127.0.0.1 in ...

github.com

some of them are merge, some are not.

With all these changes I can compile TFS on Windows and run it with build-in HTTP server, which makes it possible to login, if you set URL to login to http://127.0.0.1:8080/ in client (using ex. OTS IP Changer for Tibia 12+ (https://ots.me/ots-ip-changer-12/) )
It's also possible to run TFS in Docker on Windows with 1 command docker compose up, but this PR is still waiting for approval.

Starting HTTP server on 90.227.183.136:8080 with 1 threads.

I would try to set server IP to 127.0.0.1 in config.lua and start it with HTTP workers enabled. Maybe it's Windows problem of binding to IP that is not assigned to any network interface (you probably use DMZ / port forwarding on router).
If changing to 127.0.0.1 fixed problem with starting server with HTTP enabled, this is PR that fixes it:

feat: make HTTP listen on the same IP as OTS by gesior · Pull Request #4958 · otland/forgottenserver

This PR makes it possible to host OTS inside docker with working HTTP server. After changes from this commit (and #4957 ), you can run local server inside docker with server IP set to 127.0.0.1 in ...

github.com

It makes TFS listens on all possible IPs, but returns ip from config.lua as server IP on 'characters list',
but it's not merge yet. You must apply these changes yourself.

 

[Mjmackan]

MyAAC does not work with TFS 1.6+ (EDIT: TFS 1.6 was released 5 days after commit that breaks login with MyAAC, so it's not only broken on 1.7, also on 1.6). No AAC works with newest TFS, since they implemented 'own' sessions key algorithm (12+ client feature processed by login.php of MyAAC), that works only with 'build in HTTP' login server. One that makes your server crash on start, if you don't disable it with httpWorkers = 0.

PR that broke compatibility with MyAAC has 12+ months:

Minimal HTTP login server (#4706) · otland/forgottenserver@ceb2a07

Adds a login http server which is build on boost-beast Co-authored-by: Mario <[email protected]>

github.com

It was reported as a problem 5 days after this PR:

[Bug]: Cant login to game world - "Malformed session key." · Issue #4739 · otland/forgottenserver

By submitting this bug issue, you agree to the following. This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for supp...

github.com

report was closed with 'go fix your acc. maker', but nobody worked on MyAAC update, as nobody hosts OTS based on TFS 1.6+ engine.

I tried to run TFS master around 2 months ago on Windows and I gave up after 1 hour of configuring all that crap.
In last weeks I made multiple PRs:

fix: Ubuntu 22.04 compilation (#4943) by gesior · Pull Request #4944 · otland/forgottenserver

Changes Proposed Fix Ubuntu 22.04 compilation with system libraries. offtop: It's impossible to compile TFS without HTTP server. You can disable it by setting port to 0 in config.lua, but it&#3...

github.com

fix: build problems (#4955 #4956) by gesior · Pull Request #4957 · otland/forgottenserver

This PR fixes build problems: TFS always builds with HTTP server disabled in C++ ( [Bug]: TFS always builds with build-in HTTP server disabled #4955 ), -DHTTP=ON and -DHTTP=OFF does not work, HTTP...

github.com

fix: load SQL config from config.lua (#4518) by gesior · Pull Request #4940 · otland/forgottenserver

Changes Proposed After changes, it loads config.lua config first, then loads env variables and if they are not empty, it overwrites config.lua values. Right now TFS loads env first, so to do not ov...

github.com

feat: run TFS in docker using docker-compose.yaml by gesior · Pull Request #4959 · otland/forgottenserver

All is described in docker/README.md. It's docker configuration made using docker-compose.yaml. It starts TFS, MariaDB and phpMyAdmin inside containers. You can connect to it from Tibia Client ...

github.com

feat: make HTTP listen on the same IP as OTS by gesior · Pull Request #4958 · otland/forgottenserver

This PR makes it possible to host OTS inside docker with working HTTP server. After changes from this commit (and #4957 ), you can run local server inside docker with server IP set to 127.0.0.1 in ...

github.com

some of them are merge, some are not.

With all these changes I can compile TFS on Windows and run it with build-in HTTP server, which makes it possible to login, if you set URL to login to http://127.0.0.1:8080/ in client (using ex. OTS IP Changer for Tibia 12+ (https://ots.me/ots-ip-changer-12/) )
It's also possible to run TFS in Docker on Windows with 1 command docker compose up, but this PR is still waiting for approval.

I would try to set server IP to 127.0.0.1 in config.lua and start it with HTTP workers enabled. Maybe it's Windows problem of binding to IP that is not assigned to any network interface (you probably use DMZ / port forwarding on router).
If changing to 127.0.0.1 fixed problem with starting server with HTTP enabled, this is PR that fixes it:

feat: make HTTP listen on the same IP as OTS by gesior · Pull Request #4958 · otland/forgottenserver

This PR makes it possible to host OTS inside docker with working HTTP server. After changes from this commit (and #4957 ), you can run local server inside docker with server IP set to 127.0.0.1 in ...

github.com

It makes TFS listens on all possible IPs, but returns ip from config.lua as server IP on 'characters list',
but it's not merge yet. You must apply these changes yourself.

Jesus Gesior, ur THE man.
Thanks for explaining all this to me instead of forcing me to look up all this info, it really shortened the process.
I'll check out your PRs, thank you again.

I tried with 127.0.0.1 firstly, since back in the days i had exactly that problem, but im pretty sure i took care of it, I dont use DMZ as I've been lectured through that the harsh way.