Playerdeath.lua

[Sizaro]

sometimes when people die the server laggs for about 2 seconds and it says !

"Lua script error: [creature script interface] Data/creaturescripts/scripts/playerdeath.lua: onDeath
LuaGetCreatureName( ). creature not found

??

 

[Evan]

There's probably an error with login.lua or logout.lua or playerdeath.lua.

It's best if you post the entire script...

 

[Zonet]

Show me your playerdeath.lua.

 

[Slain]

Show me your playerdeath.lua.

i have the same issue, rare but annoying.

local config = {
deathListEnabled = getBooleanFromString(getConfigInfo('deathListEnabled')),
sqlType = getConfigInfo('sqlType'),
maxDeathRecords = getConfigInfo('maxDeathRecords')
}

function onDeath(cid, corpse, lastHitKiller, mostDamageKiller)
if(config.deathListEnabled == TRUE) then
local hitKillerName = "field item"
local damageKillerName = ""
if(lastHitKiller ~= FALSE) then
if(isPlayer(lastHitKiller) == TRUE) then
hitKillerName = getPlayerGUID(lastHitKiller)
else
hitKillerName = getCreatureName(lastHitKiller)
end

if(mostDamageKiller ~= FALSE and mostDamageKiller ~= lastHitKiller and getCreatureName(mostDamageKiller) ~= getCreatureName(lastHitKiller)) then
if(isPlayer(mostDamageKiller) == TRUE) then
damageKillerName = getPlayerGUID(mostDamageKiller)
else
damageKillerName = getCreatureName(mostDamageKiller)
end
end
end

db.executeQuery("INSERT INTO `player_deaths` (`player_id`, `time`, `level`, `killed_by`, `altkilled_by`) VALUES (" .. getPlayerGUID(cid) .. ", " .. os.time() .. ", " .. getPlayerLevel(cid) .. ", " .. db.escapeString(hitKillerName) .. ", " .. db.escapeString(damageKillerName) .. ");")
local rows = db.getResult("SELECT `player_id` FROM `player_deaths` WHERE `player_id` = " .. getPlayerGUID(cid) .. ";")
if(rows:getID() ~= -1) then
local amount = (rows:numRows(true) - config.maxDeathRecords)
if(amount > 0) then
if(config.sqlType == "sqlite") then
for i = 1, amount do
db.executeQuery("DELETE FROM `player_deaths` WHERE `rowid` = (SELECT `rowid` FROM `player_deaths` WHERE `player_id` = " .. getPlayerGUID(cid) .. " ORDER BY `time` LIMIT 1);")
end
else
db.executeQuery("DELETE FROM `player_deaths` WHERE `player_id` = " .. getPlayerGUID(cid) .. " ORDER BY `time` LIMIT " .. amount .. ";")
end
end
end
end
end

 

[slaw]

You must change

mostDamageKiller ~= FALSE
to

mostDamageKiller ~= 0

and

lastHitKiller ~= FALSE

lastHitKiller ~= 0

nothing more

 

[klekSu]

Thanks slawkens.
__________________

You are welcome on kleksoria.com!
Please visit new open tibia forum with it's own ots list. otservers.net!

 

[kito2]

You must change

mostDamageKiller ~= FALSE
to

mostDamageKiller ~= 0

and

lastHitKiller ~= FALSE

lastHitKiller ~= 0

nothing more

Why doing this? Wich is the difference?

 

[Darkhaos]

Why doing this? Wich is the difference?

yeah.. what is the diference? 0 = FALSE or FALSE = 0?

 

[slaw]

From TFS 0.3.4 TRUE = true, FALSE = false, not 1/0 anymore. Thats the difference If there is no mostDamageKiller for example, then it returns 0, not 'false'.

 

[Darkhaos]

ooh.. then 0 = nothing, 1 = something?

 

[Slain]

you must change

mostdamagekiller ~= false
to

mostdamagekiller ~= 0

and

lasthitkiller ~= false

lasthitkiller ~= 0

nothing more

ty :d

 

[darkramonzyn]

hmm i solve my probleman with this script

function onDeath(cid, corpse, deathList)

local strings = {""}
local t, position = 1, 1

local deathType = "killed"
local toSlain, toCrushed, toEliminated = 3, 9, 15

if #deathList >= toSlain and #deathList < toCrushed then
deathType = "slain"
elseif #deathList >= toCrushed and #deathList < toEliminated then
deathType = "crushed"
elseif #deathList >= toEliminated then
deathType = "eliminated"
end

for _, pid in ipairs(deathList) do
if isCreature(pid) == true then
strings[position] = t == 1 and "" or strings[position] .. ", "
strings[position] = strings[position] .. getCreatureName(pid) .. ""
t = t + 1
else
strings[position] = t == 1 and "" or strings[position] .. ", "
strings[position] = strings[position] .."a field item"
t = t + 1
end
end

for i, str in ipairs(strings) do
if(str:sub(str:len()) ~= ",") then
str = str .. "."
end

msg = getCreatureName(cid) .. " was " .. deathType .. " at level " .. getPlayerLevel(cid) .. " by " .. str
end

for _, oid in ipairs(getPlayersOnline()) do
doPlayerSendChannelMessage(oid, "Death channel", msg, TALKTYPE_CHANNEL_O, CHANNEL_DEATH)
end
return true
end