Script help

[zieworski denero]

Hello!

I tried to add this:

			[7720] = {SKILL__MAGLEVEL, 150}

in this script:

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Skill scroll" enabled="yes">
	<action itemid="9004;5958;5956;7696" event="script"><![CDATA[
		local t = {
			[9004] = {SKILL_CLUB, 150},
			[5958] = {SKILL_SWORD, 150},
			[5956] = {SKILL_AXE, 150},
			[7696] = {SKILL_DISTANCE, 150}
		}
		function onUse(cid, item, fromPosition, itemEx, toPosition)
			local v = t[item.itemid]
			if getPlayerSkillLevel(cid, v[1]) < v[2] then
				doPlayerAddSkill(cid, v[1], 1, true)
				doRemoveItem(item.uid, 1)
			else
				doCreatureSay(cid, "You can only use this if your " .. SKILL_NAMES[v[1]] .. " skill is lower than " .. v[2], TALKTYPE_ORANGE_1, false, cid)
			end
			return true
		end
	]]></action>
</mod>

But it doesn't work. Could someone fix it for me? I want if you click on X item, you get +1 magic level, however, only druids or sorceres BELOW mag lvl 150 can use it.

 

[Fallen]

try this;

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Skill scroll" enabled="yes">
	<action itemid="9004; 5958; 5956; 7696" event="buffer"><![CDATA[
		local t = {
			[9004] = {1, 150},
			[5958] = {2, 150},
			[5956] = {3, 150},
			[7696] = {4, 150}
		}
		local v = t[item.itemid]
		if getPlayerSkillLevel(cid, v[1]) < v[2] then
			doPlayerAddSkill(cid, 1)
			doRemoveItem(item.itemid, 1)
		else
			doCreatureSay(cid, "You can only use this if your " .. (v[1] == 1 and "club" or v[1] == 2 and "sword" or v[1] == 3 and "axe" or v[1] == 4 and "distance") .. " skill is lower than " .. v[2], TALKTYPE_ORANGE_1, false, cid)
		end
		return true
	]]></action>
</mod>

 

[JDB]

That won't work, that isn't even what he asked for.

 

[Fallen]

That won't work, that isn't even what he asked for.

no, he did the "doPlayerAddSkill(cid, v[1], 1, true)" wrong because
its actually "doPlayerAddSkill(cid, amount)".. not skill etc
-Show us ur "skillz" then-

 

[JDB]

That's not what I meant...
Did you even read his request? He wants to add MAGIC LEVELS.

And it has to be

doPlayerAddSkill(cid, v[1], 1)

Or else, how would it know which one to add?

 

[Fallen]

doPlayerAddMagLevel(cid, 2)
?

 

[JDB]

doPlayerAddMagLevel(cid, 2)
?

For some reason, most of the function's that add are deprecated or bugged. I have tried that and it doesn't work.

 

[Fallen]

db.executeQuery("UPDATE `players` SET `maglevel` = `maglevel` + 2 WHERE `id` = " .. getPlayerGUID(cid) .. ";")

 

[JDB]

This should work...

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Skill scroll" enabled="yes">
	<action itemid="9004;5958;5956;7696;7720" event="script"><![CDATA[
		local t = {
			[9004] = {SKILL_CLUB, 150},
			[5958] = {SKILL_SWORD, 150},
			[5956] = {SKILL_AXE, 150},
			[7696] = {SKILL_DISTANCE, 150},
			[7720] = {SKILL__MAGLEVEL, 150}
		}
		function onUse(cid, item, fromPosition, itemEx, toPosition)
			local v = t[item.itemid]
			return getPlayerSkillLevel(cid, v[1]) < v[2] and doPlayerAddSkill(cid, v[1], 1, true) and doRemoveItem(item.uid, 1) or getPlayerSkillLevel(cid, v[1]) >= v[2] and doCreatureSay(cid, "You can only use this if your " .. SKILL_NAMES[v[1]] .. " skill is lower than " .. v[2], TALKTYPE_ORANGE_1, false, cid)
		end
	]]></action>
</mod>

Another way...

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Skill scroll" enabled="yes">
	<action itemid="9004;5958;5956;7696;7720" event="script"><![CDATA[
		local t = {
			[9004] = {SKILL_CLUB, 1, 150},
			[5958] = {SKILL_SWORD, 1, 150},
			[5956] = {SKILL_AXE, 1, 150},
			[7696] = {SKILL_DISTANCE, 1, 150},
			[7720] = {SKILL__MAGLEVEL, 1, 150}
		}
		function onUse(cid, item, fromPosition, itemEx, toPosition)
			local v = t[item.itemid]
			return getPlayerSkillLevel(cid, v[1]) < v[3] and doPlayerAddSkill(cid, v[1], v[2], true) and doRemoveItem(item.uid, 1) or getPlayerSkillLevel(cid, v[1]) >= v[3] and doCreatureSay(cid, "You can only use this if your " .. SKILL_NAMES[v[1]] .. " skill is lower than " .. v[3], TALKTYPE_ORANGE_1, false, cid)
		end
	]]></action>
</mod>

 

[zieworski denero]

doesn't work ;\

 

[Cykotitan]

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Skill scroll" enabled="yes">
	<action itemid="9004;5958;5956;7696" event="script"><![CDATA[
		local t = {
			[9004] = {SKILL_CLUB, 150},
			[5958] = {SKILL_SWORD, 150},
			[5956] = {SKILL_AXE, 150},
			[7696] = {SKILL_DISTANCE, 150},
			[7720] = {SKILL__MAGLEVEL, 150},
		}
		function onUse(cid, item, fromPosition, itemEx, toPosition)
			local v = t[item.itemid]
			if (v[1] == SKILL__MAGLEVEL and getPlayerMagLevel(cid, true) < v[2]) or getPlayerSkillLevel(cid, v[1]) < v[2] then
				doPlayerAddSkill(cid, v[1], 1, true)
				doRemoveItem(item.uid, 1)
			else
				doCreatureSay(cid, 'You can only use this if your ' .. SKILL_NAMES[v[1]] .. (v[1] == SKILL__MAGLEVEL and '' or ' skill') .. ' is lower than ' .. v[2], TALKTYPE_ORANGE_1, false, cid)
			end
			return true
		end
	]]></action>
</mod>

 

[zieworski denero]

Hmm, it works~ but you don't get 1 magic level.

Example:

Right now, I have 0 in magic level. When using the scroll, I still have 0 mag lvl BUT with 99% left to 1.

Oh, and you can't use it more than once, if you do it, you won't even get 1%.

 

[Cykotitan]

Edit this function in 050-function.lua:

function doPlayerAddMagLevel(cid, amount)
	for i = 1, amount do
		doPlayerAddSpentMana(cid, math.ceil((getPlayerRequiredMana(cid, getPlayerMagLevel(cid, true) + 1) - getPlayerSpentMana(cid)) / getConfigInfo('rateMagic')))
	end
	return true
end

 

[zieworski denero]

works :d

thanks once again

 

[zieworski denero]

Sorry man, one more request

Could you make so only druids & sorcs can use mag level scroll?

 

[Cykotitan]

<?xml version="1.0" encoding="UTF-8"?>
<mod name="Skill scroll" enabled="yes">
	<action itemid="9004;5958;5956;7696" event="script"><![CDATA[
		local t = {
			[9004] = {SKILL_CLUB, 150},
			[5958] = {SKILL_SWORD, 150},
			[5956] = {SKILL_AXE, 150},
			[7696] = {SKILL_DISTANCE, 150},
			[7720] = {SKILL__MAGLEVEL, 150, [B][COLOR="Red"]{1, 2, 5, 6, 9, 10}[/COLOR][/B]},
		}
		function onUse(cid, item, fromPosition, itemEx, toPosition)
			local v = t[item.itemid]
			if not v[3] or isInArray(v[3], getPlayerVocation(cid)) then
				if (v[1] == SKILL__MAGLEVEL and getPlayerMagLevel(cid, true) < v[2]) or getPlayerSkillLevel(cid, v[1]) < v[2] then
					doPlayerAddSkill(cid, v[1], 1, true)
					doRemoveItem(item.uid, 1)
				else
					doCreatureSay(cid, 'You can only use this if your ' .. SKILL_NAMES[v[1]] .. (v[1] == SKILL__MAGLEVEL and '' or ' skill') .. ' is lower than ' .. v[2], TALKTYPE_ORANGE_1, false, cid)
				end
			else
				doCreatureSay(cid, 'You don\'t have the required vocation', TALKTYPE_ORANGE_1, false, cid)
			end
			return true
		end
	]]></action>
</mod>