TFS 1.X+ Skill Stages Error

aqubjukr · May 14, 2020

I'm trying to implement a skill stages system on my server. It even works, however, when I use any spell with a player, the following error appears on my console:

TFS1.3

Lua:

Lua Script Error: [Event Interface]
data/events/scripts/player.lua:Player@onGainSkillTries
data/events/scripts/player.lua:896: bad argument #1 to 'next' (table expected, got nil)
stack traceback:
        [C]: at 0x005be450
        [C]: in function 'next'
        data/events/scripts/player.lua:896: in function <data/events/scripts/player.lua:891>

aqubjukr · May 14, 2020

aqubjukr · May 15, 2020

zuber966 · May 15, 2020

Are you passing valid skill id?

aqubjukr · May 16, 2020

Yep man. I was trying to solve this, and I got to make the magic level stages work, but the others stopped: /

Lua:

function Player:onGainSkillTries(skill, tries)
    if APPLY_SKILL_MULTIPLIER == false then
    return tries
  end
  local skills = SkillsTable[skill]
  if skills and skills.rate then
    local rate = configManager.getNumber(skills.rate)
    if rate > 0 then
      return tries * rate
    else
      return tries * rate
    end
  end
    if skill == SKILL_MAGLEVEL then
    local ratemagic = configKeys.RATE_MAGIC
    if ratemagic > 0 then
      return tries * ratemagic
    else
      return tries * ratemagic
    end
end
end

Now i'm trying to get both.

zuber966 · May 16, 2020

It will never reach if in 14th line, becouse earlier if will return some value for any skill so you may remove it
Try changing line 7 to this
local rate = skills.rate
rate field from skills variable already holds skill rate from config according to player.lua file you have shared

------

Nope, I am wrong about rate part

aqubjukr · May 16, 2020

It doesn't work. When I do this, all the skill increase 1% each spell or attack.

zuber966 · May 16, 2020

Any errors in console?
From if in 6th line remove skills.rate

Tomorrow I will try it in my server and respond here if will work

@Edit

Alright, this should work for stages

Lua:

function getSkillsRate(level, stages)
    if stages then
        for sLevel, multiplier in pairs(stages) do
            if level >= sLevel[1] and level <= sLevel[2] then
                return multiplier
            end
        end
    end
    return 1
end

function Player:onGainSkillTries(skill, tries)
    if APPLY_SKILL_MULTIPLIER == false then
        return tries
    end
    local skills = SkillsTable[skill]
    if skills then
        if skill == SKILL_MAGLEVEL then
            return tries * getSkillsRate(self:getMagicLevel(), skills.stage)
        end
        return tries * getSkillsRate(self:getSkillLevel(skill), skills.stage)
    end
    return tries
end

Magic level was not working for you, because it is not hold in the same place as rest of skills so for this you need to use getMagicLevel

aqubjukr · May 16, 2020

OMG man, you've helped me a loot! I was breaking my mind and it was not so difficult.

Ps: I've tested all skills and everyone is working normally.

zuber966 · May 17, 2020

You may wanna use getBaseMagicLevel() instead of getMagicLevel(), because the second one returns magic level with bonuses

ivansho92 · Sep 12, 2020

aqubjukr said:
OMG man, you've helped me a loot! I was breaking my mind and it was not so difficult.

Ps: I've tested all skills and everyone is working normally.

hey man, can you shared the branch to do that?
i was trying with another repo, but the src are so differents.

TFS 1.X+ Skill Stages Error

aqubjukr

Well-Known Member

Attachments

zuber966

aqubjukr

Well-Known Member

aqubjukr

Well-Known Member

zuber966

Member

aqubjukr

Well-Known Member

zuber966

Member

aqubjukr

Well-Known Member

zuber966

Member

aqubjukr

Well-Known Member

zuber966

Member

ivansho92

New Member

Similar threads