Feature [1.5] add magicDamage in vocation.xml

[Error 502]

[1.5] add magicDamage in vocation.xml​

default------------>


magicDamage="1.2"



vocation.h
[1/4]

class Vocation

search

float meleeDamageMultiplier = 1.0f;

add below

float magicDamageMultiplier = 1.0f;

vocation.cpp
[2/4]

bool Vocations::loadFromXml()

search

if ((attr = childNode.attribute("distDamage"))) {
                    voc.distDamageMultiplier = pugi::cast<float>(attr.value());
                }

add below

            if ((attr = childNode.attribute("magicDamage"))) {
                    voc.magicDamageMultiplier = pugi::cast<float>(attr.value());
                }

Combat.cpp
[3/4]

CombatDamage Combat::getCombatDamage(Creature* creature, Creature* target) const

search

int32_t levelFormula = player->getLevel() * 2 + player->getMagicLevel() * 3;

replace

int32_t levelFormula = (player->getLevel() * 2 + player->getMagicLevel() * 3) * (player->getVocation()->magicDamageMultiplier);

vocations.xml
[4/4]
search

<formula meleeDamage="1.0" distDamage="1.0" defense="1.0" armor="1.0" />

replace

<formula meleeDamage="1.0" magicDamage="1.2" distDamage="1.0" defense="1.0" armor="1.0" />

the default value is 1.0 , even if you don't put anything

Spoiler: spoiler2

Disclaimer

I'M NOT AN EXPERT IN C++

Another way:

Vocations balance tfs 1.5 7.72

Hello i have this script from some time ago but now have some issues with with getting this worked local pvpvocs = { [1] = { pvp = {weapon = 40.2, spells = 45.0, defense = 1.0}, pve = {weapon = 40.2, spells = 45.0, defense = 50.0}, healing = 50.0 }, [2] = {...

otland.net

Spoiler: vocations-balance-tfs

The array lua was very long for me, I preferred damage in C++

 

[Marko999x]

Question:
Wouldn't it be easier to add a lua script with onHealthChange?

 

[Error 502]

Question:
Wouldn't it be easier to add a lua script with onHealthChange?

for me ,is more comfortable in xml
because in lua with
onHealthChange


+3800 lines

find another way

 

[Mateus Robeerto]

Is this magicDamage based on magic percentage increase or not?

This magicDamage is cool, different and very interesting.

 

[Marko999x]

for me ,is more comfortable in xml
because in lua with
onHealthChange
View attachment 76585

+3800 lines

find another way

Do u have 750 vocs?

 

[dami1310]

Question:
Wouldn't it be easier to add a lua script with onHealthChange?

You mean, would adding another file to control the outcome damage (even splitting melee and spell) be easier than this? Not in my opinion.

 

[Tofame]

Good job and nice contribution. Obviously c++ is better for this case. Also, kinda weird that at some point this disappeared, Im currently at 0.4 and magDamage is here by default in vocations, maybe that's my distro being specific. If that's not in tfs master it should definitely be brought there.