TFS 1.X+ 10.98 issue regarding loading npc

[ThatGuyPJ]

hi there! ive started up my server and I got an issue with npcs, about half of them do not spawn and I cant summon them in either and most don't reply, apart from traders. none of the boat captains spawn either which is a pain.

Lua Script Error: [Npc interface]
data/npc/lib/npc.lua
data/npc/lib/npcsystem/customModules.lua:3: attempt to index global 'Storage' (a nil value)
stack traceback:
        [C]: in function '__index'
        data/npc/lib/npcsystem/customModules.lua:3: in main chunk
        [C]: in function 'dofile'
        data/npc/lib/npc.lua:3: in main chunk
[Warning - NpcScriptInterface::loadNpcLib] Can not load data/npc/lib/npc.lua

Lua Script Error: [Npc interface]
data/npc/scripts/Kasmir.lua
data/npc/scripts/Kasmir.lua:78: attempt to call method 'addAliasKeyword' (a nil value)
stack traceback:
        [C]: in function 'addAliasKeyword'
        data/npc/scripts/Kasmir.lua:78: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Kasmir.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Gabel.lua
data/npc/scripts/Gabel.lua:87: attempt to call method 'addGreetMessage' (a nil value)
stack traceback:
        [C]: in function 'addGreetMessage'
        data/npc/scripts/Gabel.lua:87: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Gabel.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Malor.lua
data/npc/scripts/Malor.lua:99: attempt to call method 'addGreetMessage' (a nil value)
stack traceback:
        [C]: in function 'addGreetMessage'
        data/npc/scripts/Malor.lua:99: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Malor.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Edala.lua
data/npc/scripts/Edala.lua:44: attempt to call method 'addAliasKeyword' (a nil value)
stack traceback:
        [C]: in function 'addAliasKeyword'
        data/npc/scripts/Edala.lua:44: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Edala.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Yaman.lua
data/npc/scripts/Yaman.lua:101: attempt to call method 'addGreetMessage' (a nil value)
stack traceback:
        [C]: in function 'addGreetMessage'
        data/npc/scripts/Yaman.lua:101: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Yaman.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Frodo.lua
data/npc/scripts/Frodo.lua:16: attempt to call method 'addAliasKeyword' (a nil value)
stack traceback:
        [C]: in function 'addAliasKeyword'
        data/npc/scripts/Frodo.lua:16: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Frodo.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Frodo.lua
data/npc/scripts/Frodo.lua:16: attempt to call method 'addAliasKeyword' (a nil value)
stack traceback:
        [C]: in function 'addAliasKeyword'
        data/npc/scripts/Frodo.lua:16: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Frodo.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Tristan.lua
data/npc/scripts/Tristan.lua:10: attempt to call method 'addSpellKeyword' (a nil value)
stack traceback:
        [C]: in function 'addSpellKeyword'
        data/npc/scripts/Tristan.lua:10: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Tristan.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Frodo.lua
data/npc/scripts/Frodo.lua:16: attempt to call method 'addAliasKeyword' (a nil value)
stack traceback:
        [C]: in function 'addAliasKeyword'
        data/npc/scripts/Frodo.lua:16: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Frodo.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Frodo.lua
data/npc/scripts/Frodo.lua:16: attempt to call method 'addAliasKeyword' (a nil value)
stack traceback:
        [C]: in function 'addAliasKeyword'
        data/npc/scripts/Frodo.lua:16: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Frodo.lua


Lua Script Error: [Npc interface]
data/npc/scripts/Blind Orc.lua
data/npc/scripts/Blind Orc.lua:30: attempt to call method 'addGreetKeyword' (a nil value)
stack traceback:
        [C]: in function 'addGreetKeyword'
        data/npc/scripts/Blind Orc.lua:30: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Blind Orc.lua

this is just the first few as posting the full errors is over 25000 characters, so im hoping it could be an easy fix that with correct all of the individual problems for all the npcs hopefully!

thanks in advance for any replies

 

[Evil Puncker]

you found the solution ?

method 'addGreetMessage' (a nil value)

server/data/npc/lib/npcsystem/modules.lua at 390edf6921500180ab3a51d27396ed17ebf57676 · orts/server

A real map datapack based on TFS 1.2 engine. Contribute to orts/server development by creating an account on GitHub.

github.com

 

[danio4don]

server/data/npc/lib/npcsystem/modules.lua at 390edf6921500180ab3a51d27396ed17ebf57676 · orts/server

A real map datapack based on TFS 1.2 engine. Contribute to orts/server development by creating an account on GitHub.

github.com

there is still this problem after adding

https://imgur.com/rqQ566X

 

[Evil Puncker]

there is still this problem after adding

https://imgur.com/rqQ566X

server/data/npc/lib/npcsystem/customModules.lua at master · orts/server

A real map datapack based on TFS 1.2 engine. Contribute to orts/server development by creating an account on GitHub.

github.com

 

[danio4don]

server/data/npc/lib/npcsystem/customModules.lua at master · orts/server

A real map datapack based on TFS 1.2 engine. Contribute to orts/server development by creating an account on GitHub.

github.com

I already have it added

-- Adds a keyword which acts as a greeting word
function KeywordHandler:addGreetKeyword(keys, parameters, condition, action)
    local keys = keys
    keys.callback = FocusModule.messageMatcherDefault
    return self:addKeyword(keys, GreetModule.greet, parameters, condition, action)
end

it doesn't help

 

[Orkanite]

@danio4don If you already have done the following-

1. cloned TFS from otland/forgottenserver (https://github.com/otland/forgottenserver)
2. added npc scripts from another data pack you found somewhere (ORTS?)
3. got error "attempt to call method 'addGreetMessage' (a nil value)"
4. pasted in data\npc\lib\npcsystem\customModules.lua from another data pack to fix it based on research
5. modified data\npc\lib\npc.lua to include this line-

   dofile('data/npc/lib/npcsystem/customModules.lua')

and you're still receiving those errors, particularly "attempt to index global 'Storage' (a nil value)" most likely you need to do the following-

1. clone the ORTS datapack from orts/server (https://github.com/orts/server) to your local filesystem
2. in the ORTS datapack, copy the folder data\lib\miscellaneous and paste it into your current TFS datapack in data\lib folder
3. modify your data\lib\lib.lua to include this line-

   dofile('data/lib/miscellaneous/miscellaneous.lua')

I got it working based on what someone earlier in this thread said about global storages in lib/misc.