a bug in my script creature.lua (OnTargetCombat)

[jededias]

When I attack a monster if I have the outfit 100, it change to 101 for 3 seconds and it back to the normal outfit 100.
This script is working only 1 time, to work again I need attack the monster again, how fix it?

local attackOutfit = Condition(CONDITION_OUTFIT, CONDITIONID_COMBAT)
local outfitTable = {
    --Looktype/newLooktype/Seconds until newOutfit removes
    [100] = {newOutfit = 101, outfitInterval = 3}
}

function Creature:onTargetCombat(target)
    if self:isPlayer() then
        local table = outfitTable[self:getOutfit().lookType]
        if table then
            attackOutfit:setOutfit({lookType = table.newOutfit})
            attackOutfit:setTicks(table.outfitInterval * 1000)
            self:addCondition(attackOutfit)
            print("Its Working ?")
        end
    end
    return true
end

 

[Evil Puncker]

that is not a bug, that is exactly how nTargetCombat works, if you want to apply it every time a hit is done, you better use onHealthChange creatureevent

 

[jededias]

that is not a bug, that is exactly how nTargetCombat works, if you want to apply it every time a hit is done, you better use onHealthChange creatureevent

Could u add onHealthChange in my code to I see how it works? Please <3

 

[Evil Puncker]

something like this I think:

local attackOutfit = Condition(CONDITION_OUTFIT, CONDITIONID_COMBAT)
local outfitTable = {
    --Looktype/newLooktype/Seconds until newOutfit removes
    [100] = {newOutfit = 101, outfitInterval = 3}
}

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType)
print("first check")
    if primaryType ~= COMBAT_HEALING or secondaryType ~= COMBAT_HEALING then
print("second check")
        local player = attacker:getPlayer()
        if player and creature ~= attacker then
print("third check")
            local table = outfitTable[player:getOutfit().lookType]
            if table then
print("fourth check")
                attackOutfit:setOutfit({lookType = table.newOutfit})
                attackOutfit:setTicks(table.outfitInterval * 1000)
                player:addCondition(attackOutfit)
            end
        end
    end
print("fifth check")
    return primaryDamage, primaryType, secondaryDamage, secondaryType
end

don't forget to register it properly on creatureevents.xml and login.lua (idk if last one is necessary but I think so)

 

[jededias]

@Evil Puncker
I tried add in creaturescripts: <event type="healthchange" name="damage" script="changeoutfit.lua" />
inside login.lua > player:registerEvent("damage")
And I create the changeoutfit.lua but nothing happens

local attackOutfit = Condition(CONDITION_OUTFIT, CONDITIONID_COMBAT)
local outfitTable = {
    --Looktype/newLooktype/Seconds until newOutfit removes
    [100] = {newOutfit = 101, outfitInterval = 3}
}

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType)
    if primaryType ~= COMBAT_HEALING or secondaryType ~= COMBAT_HEALING then
        local player = creature:getPlayer()
        if player and creature ~= attacker then
            local table = outfitTable[player:getOutfit().lookType]
            if table then
                attackOutfit:setOutfit({lookType = table.newOutfit})
                attackOutfit:setTicks(table.outfitInterval * 1000)
                player:addCondition(attackOutfit)
                print("Its Working ?")
            end
        end
    end
    return primaryDamage, primaryType, secondaryDamage, secondaryType
end

 

[Evil Puncker]

oh sorry, try again, forgot to change something

 

[jededias]

oh sorry, try again, forgot to change something

Dont worked, maybe is because the tag in creaturescripts?

 

[Evil Puncker]

Dont worked, maybe is because the tag in creaturescripts?

don't think so, I've added a few checks on the script, try it again and see what your console prints

 

[jededias]

don't think so, I've added a few checks on the script, try it again and see what your console prints

Dont working

 

[Evil Puncker]

that is really weird, at least the first check should be print, if it is not printing it, it means there is an error on registering the script, re-check your .xml and login.lua files

 

[Infernum]

you have to register the creaturescript to each monster for it to register

 

[jededias]

you have to register the creaturescript to each monster for it to register

Thanks! I add the script to the monster.xml and it's working now <3

that is really weird, at least the first check should be print, if it is not printing it, it means there is an error on registering the script, re-check your .xml and login.lua files

Thanks you for the codes bro, its working now, I add the script to monsters xml