Add Player 3% Mana per sec needed

Hashirama479 · Jan 8, 2017

Yo I need a script which gives players 3% mana per sec and it should work forever also its shouldnt be like using a item = getting mana it should always heal doenst matter if you log off or what ever haha xD ( sorry if the script alredy exists but cant find it.... )

andu · Jan 8, 2017

Editied. Works on every tfs, otx and few yurots
It's creaturescript, so remember to register in login.lua too.

Code:

-- Creaturescripts.xml: <event type="think" name="Healing" script="healing.lua"/>
-- login.lua: registerCreatureEvent(cid, "Healing")
-- for more ask andu @ otland.net

local config = {
    useTfsVersion1 = "no", -- use "yes" for tfs 1.0+ and otx 2.0+. For old tfs, and other engines use "no".
    inCombat = {
        healthPercent = 0.0,    -- % of max health
        manaPercent = 0.0    -- % of max mana
    },
    outOfCombat = {
        healthPercent = 15.0,    -- % of max health
        manaPercent = 7.5    -- % of max mana
    },
    energyGain = 10        -- melee/tank etc (in my server players what have exactly 100 mana are melee/tanks)
}

if config.useTfsVersion1 == "yes" then
    function hasCondition(cid, condition)
        local c = Creature(cid)
        return c ~= nil and c:getCondition(condition, CONDITIONID_DEFAULT) or false
    end
end

function onThink(cid, interval)
    if isPlayer(cid) == true then
        local hp, mp = 0, 0
        if hasCondition(cid, CONDITION_INFIGHT) == true then
            hp = config.inCombat.healthPercent
            mp = config.inCombat.manaPercent
        else
            hp = config.outOfCombat.healthPercent
            mp = config.outOfCombat.manaPercent
        end

        local hpheal, mpheal = getCreatureMaxHealth(cid)*(hp/100), getPlayerMaxMana(cid) * (mp / 100)

        if hpheal >= 1 and getCreatureHealth(cid) < getCreatureMaxHealth(cid) then
            doCreatureAddHealth(cid, hpheal)
        end
        if getPlayerMana(cid) < getPlayerMaxMana(cid) then
            if getPlayerMaxMana(cid) > 100 then
                if mpheal >= 1 then
                    doPlayerAddMana(cid, mpheal)
                end
            else
                doPlayerAddMana(cid, config.energyGain)    -- energy
            end
        end
    end
    return true
end

Hashirama479 · Jan 8, 2017

Where do I need to put the script? Globalevents?

andu · Jan 8, 2017

andu said:
Creaturescript, remember to register in login.lua too.

Hashirama479 · Jan 8, 2017

Ah sorry didnt see haha

Hashirama479 · Jan 8, 2017

Thanks mate! working perfect <333

Hashirama479 · Jan 8, 2017

Ah I have two problems with the script

1. It shows the mana amount which has been added is it possible to remove? So it does not show as explain 1248 anymore

2. It even adds mana when you have alredy ur max mana xD

Hashirama479 · Jan 8, 2017

https://gyazo.com/c439c4df41d4e4164d0b2755e7a06af2

here a quick video what I mean

andu · Jan 8, 2017

1,2

change it in your config.lua

showHealingDamage

Hashirama479 · Jan 8, 2017

kk works thanks <3

using 0.4 but worked too xD so thanks

Znote · Jan 10, 2017

I would do a few changes:
If you have max mana or max health, don't do anything.
If you have more than 100% - configured%Regen, HP/MP, give yourself only max - current HP/MP.

Should be less stressful performance wise.

Colors · Jan 10, 2017

About the performance; Is better to use an onThink script like this one, or just create a regeneration condition and update the hp/mana ticks/amount as needed?

andu · Jan 10, 2017

Znote said:
I would do a few changes:
If you have max mana or max health, don't do anything.
If you have more than 100% - configured%Regen, HP/MP, give yourself only max - current HP/MP.

Should be less stressful performance wise.

That's true. Changed.

Colors said:
About the performance; Is better to use an onThink script like this one, or just create a regeneration condition and update the hp/mana ticks/amount as needed?

Conditions doesn't have good support in sources. They loads before function so you can't use variables like cid. Unless you decide to make alot of conditions to match different players' max mana. This option will be memory absorbing.

@Hashirama479 I updated it to better match your needs. post

Hashirama479 · Jan 10, 2017

andu said:
@Hashirama479 I updated it to better match your needs. post

Does not work here error from console -

https://gyazo.com/f227fe20fb100de0954f20860d30590c

EDIT: and yes I did put no here

Code:

    useTfsVersion1 = "no" -- use "yes" for tfs 1.0+ and otx 2.0+. For old tfs, and other engines use "no".

xD

Colandus · Jan 10, 2017

andu said:

Creaturescript, remember to register in login.lua too.

Code:

-- Creaturescripts.xml: <event type="think" name="Healing" script="healing.lua"/>
-- login.lua: registerCreatureEvent(cid, "Healing")
-- for more ask andu @ otland.net

local config = {
    useTfsVersion1 = "yes" -- use "yes" for tfs 1.0+ and otx 2.0+. For old tfs, and other engines use "no".
    inCombat = {
        healthPercent = 0.0,    -- % of max health
        manaPercent = 0.0    -- % of max mana
    },
    outOfCombat = {
        healthPercent = 15.0,    -- % of max health
        manaPercent = 7.5    -- % of max mana
    },
    energyGain = 10        -- melee/tank etc (in my server players what have exactly 100 mana are melee/tanks)
}

function onThink(cid, interval)
    if isPlayer(cid) == true then
        local hp, mp, tfsv = 0, 0, false
        if useTfsVersion1 == "yes" then
            tfsv = cid:getCondition(CONDITION_INFIGHT, CONDITIONID_DEFAULT)
        else
            tfsv = hasCondition(cid, CONDITION_INFIGHT)
        end
        if tfsv == true then
            hp = config.inCombat.healthPercent
            mp = config.inCombat.manaPercent
        else
            hp = config.outOfCombat.healthPercent
            mp = config.outOfCombat.manaPercent
        end

        local hpheal, mpheal = getCreatureMaxHealth(cid)*(hp/100), getPlayerMaxMana(cid) * (mp / 100)

        if hpheal >= 1 and getCreatureHealth(cid) < getCreatureMaxHealth(cid) then
            doCreatureAddHealth(cid, hpheal)
        end
        if getPlayerMana(cid) < getPlayerMaxMana(cid) then
            if getPlayerMaxMana(cid) > 100 then
                if mpheal >= 1 then
                    doPlayerAddMana(cid, mpheal)
                end
            else
                doPlayerAddMana(cid, config.energyGain)    -- energy
            end
        end
    end
    return true
end

That variable tfsv is confusing. You should probably name it like "infight" or something.

Also I'd rather do like:

Code:

local valuesTable = infight and config.inCombat or config.outOfCombat
local hp = valuesTable.healthPercent
local mp = valuesTable.manaPercent

And the energyGain code should probably have been omitted considering this is something that exists only in your server.

Infernum · Jan 10, 2017

Hashirama479 said:
Does not work here error from console -

https://gyazo.com/f227fe20fb100de0954f20860d30590c

EDIT: and yes I did put no here

Code:

useTfsVersion1 = "no" -- use "yes" for tfs 1.0+ and otx 2.0+. For old tfs, and other engines use "no".

xD

Code:

local mpGainPercent = 3

function onThink(interval)
    local players = getPlayersOnline()
    if (#players == 0) then
        return true
    end
    for i = 1, #players do
        local cid = getPlayerByNameWildcard(players[i])
        local maxMana = getCreatureMaxMana(cid)
        if getCreatureMana(cid) ~= maxMana then
            doPlayerAddMana(cid, maxMana * (mpGainPercent/100))
        end
    end
    return true
end

Code:

<globalevent name="mana regen" interval="1000" event="script" value="xxxxxxxx.lua"/>

andu · Jan 10, 2017

Hashirama479 said:
Does not work here error from console -

https://gyazo.com/f227fe20fb100de0954f20860d30590c

EDIT: and yes I did put no here

Code:

useTfsVersion1 = "no" -- use "yes" for tfs 1.0+ and otx 2.0+. For old tfs, and other engines use "no".

xD

change

Code:

"no"

to

Code:

"no",

andu · Jan 10, 2017

@Xeraphus why

Your script is executing over 2000 functions per second on 500 players online server. With over 7 milions functions per hour. And forces server to do heavy job: in every second make and drop a table with 500 keys and 10k subkeys.

Colandus · Jan 10, 2017

andu said:
@Xeraphus why

Your script is executing over 2000 functions per second on 500 players online server. With over 7 milions functions per hour.

You want to jump from start to finish with no rise in performance? Ok here you go:

Code:

function onThink(interval)
end

It might be more less effective to use globalscripts onThink over creaturescripts onThink in this case, but not devastatingly. But aside from that, your code also "does something to all online players via lua" and "every tick get all online players" is also done, but by C++. Perhaps he uses an additional table compared to you etc but as I said this isn't devastating. Might not be great though but not as you say.

Infernum · Jan 10, 2017

andu said:
@Xeraphus why

Your script is executing over 2000 functions per second on 500 players online server. With over 7 milions functions per hour. And forces server to do heavy job: in every second make and drop a table with 500 keys and 10k subkeys.

ok
my bad you're lightyears more advanced than me

Add Player 3% Mana per sec needed

World of Ninja

Sold 649 scripts, 25 maps and 9 events!

World of Ninja

Sold 649 scripts, 25 maps and 9 events!

World of Ninja

World of Ninja

World of Ninja

World of Ninja

Sold 649 scripts, 25 maps and 9 events!

World of Ninja

<?php echo $title; ?>

♥

Sold 649 scripts, 25 maps and 9 events!

World of Ninja

Advanced OT User

︈

Sold 649 scripts, 25 maps and 9 events!

Sold 649 scripts, 25 maps and 9 events!

Advanced OT User

︈