Lua Adding +1 kill when player kill someone.

[maas]

Hello guys, im adding a top fraggers system in my gesior, bu tiv some prob with a creaturescript that i made, the script hv to add +1 in table frags_all.... The way is players > frags_all

i Made all correct but when a player kill the number of the table do not change!!!

The scripts are above and my server is TFS 1.3

creaturescripts/scripts/topfrags.lua

local skulls = {SKULL_WHITE, SKULL_YELLOW, SKULL_RED, SKULL_BLACK}

function addPlayerFrag(cid, value)
    db.executeQuery("UPDATE `players` SET `frags_all` = `frags_all` + " .. value .. " WHERE `id` = " .. getPlayerGUID(cid) .. ";")
    return true
end

function onKill(cid, target)
    if isPlayer(cid) and isPlayer(target) then
        for i= 1, #skulls do
            if getPlayerSkullType(target) == skulls[i]  then
                addPlayerFrag(cid, 1)
                break
            end
        end
    end
    return true
end

function onLogin(cid)
    registerCreatureEvent(cid, "TopFrags")
    return true
end

And
creaturescripts/creaturescripts.xml

<event type="kill" name="TopFrags" event="script" value="topfrags.lua" />
<event type="login" name="RTopFrags" event="script" value="topfrags.lua" />

THANKSSS

 

[Nekiro]

Where is this function onLogin placed? In your creaturescript? You should register this in login.lua

Also if you use tfs 1.3 do not use old code style.

function onKill(player, target)
and
target:isPlayer() for example

 

[maas]

@Thexamx

i Removed the function >>

1. function onLogin(cid)
2. registerCreatureEvent(cid, "TopFrags")
3. return true
4. end

And registered in login.lua, but still not working, its my first time code tfs 1.3, can u help more plx <3

 

[Nekiro]

Use code tags.

local skulls = {SKULL_WHITE, SKULL_YELLOW, SKULL_RED, SKULL_BLACK}

function addPlayerFrag(player, value)
    db.query("UPDATE `players` SET `frags_all` = `frags_all` + " .. value .. " WHERE `id` = " .. player:getGuid() .. ";")
    return true
end

function onKill(player, target)
    if not target:isPlayer() then
        return true
    end

    if table.contains(skulls, player:getSkull()) then
        addPlayerFrag(player, 1)
    end
    
    return true
end

 

[maas]

@Thexamx

Ill give to you a like but... still not working bro...

 

[Nekiro]

@Thexamx

Ill give to you a like but... still not working bro...

Oh yeah I made typo, it should be player:getSkull() not target, try now xD

 

[maas]

Oh yeah I made typo, it should be player:getSkull() not target, try now xD

Not @Thexamx not working too

 

[Nekiro]

Change
db.executeQuery
to:
db.asyncQuery

How does it not work? Have you debugged the code or just put it in, test and "no. not working".

 

[maas]

Change
db.executeQuery
to:
db.asyncQuery

How does it not work? Have you debugged the code or just put it in, test and "no. not working".

@Thexamx Omg bro! OFC that im testing everything before talking to you that not working... to me the script still not working, i do all that u said without mistakes and forgets, but still if error in something... sorry again to disturb u, that isnt my intention... i just need help because that is important to me.

 

[WibbenZ]

@Thexamx Omg bro! OFC that im testing everything before talking to you that not working... to me the script still not working, i do all that u said without mistakes and forgets, but still if error in something... sorry again to disturb u, that isnt my intention... i just need help because that is important to me.

If you have an error then post it, that way we can help you faster insted of guessing.

 

[maas]

If you have an error then post it, that way we can help you faster insted of guessing.

Dont hv any console error understand? just not adding +1 at the table frags_all in players when kill players.

 

[Nekiro]

@Thexamx Omg bro! OFC that im testing everything before talking to you that not working... to me the script still not working, i do all that u said without mistakes and forgets, but still if error in something... sorry again to disturb u, that isnt my intention... i just need help because that is important to me.

So you made prints and you see to which moment the script is executed?

 

[2Rec]

You registered it onLogin? Check if names are matching.
If it isnt a case, add prints.

 

[WibbenZ]

Fixed via TV, @Thexamx script worked (changed executeQuery to query)
Problem was that in XML he had written value="path" insted of script="path".

 

[klenio0]

don't working