Compiling Adding new spell effects source tfs 1.3

[Thorn]

Hello guys, i have many custom spell effects, and i was wondering how to use them in game? so i now know i need to register them in sources, i just did. i registered all in const.h, but i read somewhere i also need to "change the numbers" in protocolgame.cpp? im asking here because i cant find anything to edit there...

is there anything else i need to edit? before compiling and be able to use these new effects? also, command !z only reaches to 250-260, don't know exactly, will that be a problem when i try to implement spell effects that are of higher number than that?

Thanks!

 

[Infernum]

just search for some magic effect and look everywhere it's registered, especially in tools.cpp (obviously you can ignore when a magic effect is used by sendMagicEffect in sources)
for example: Search · CONST_ME_YALAHARIGHOST · GitHub
just follow the files in c++ and add your magic effect in those files, and it should work
as for the command you have to change the talkaction to support the number you put your effect as in const.h

 

[Thorn]

just search for some magic effect and look everywhere it's registered, especially in tools.cpp (obviously you can ignore when a magic effect is used by sendMagicEffect in sources)
for example: Search · CONST_ME_YALAHARIGHOST · GitHub
just follow the files in c++ and add your magic effect in those files, and it should work
as for the command you have to change the talkaction to support the number you put your effect as in const.h

i added the spells in both files and i got this error :S

 

[Infernum]

you need to change this in const.h

enum MagicEffectClasses : uint8_t {

to

enum MagicEffectClasses : uint16_t {

then change all of these from uint8_t type to uint16_t type
forgottenserver/protocolgame.cpp at 768ec435e27e53a045181c7d9e65a0b39abd5c6f · otland/forgottenserver · GitHub
forgottenserver/protocolgame.h at 71b0479ee2c675175487601bbd7387df58437df0 · otland/forgottenserver · GitHub
forgottenserver/player.h at 71b0479ee2c675175487601bbd7387df58437df0 · otland/forgottenserver · GitHub

change these from uint8_t effect to uint16_t effect
forgottenserver/game.cpp at master · otland/forgottenserver · GitHub
forgottenserver/game.cpp at master · otland/forgottenserver · GitHub

 

[Thorn]

you need to change this in const.h

enum MagicEffectClasses : uint8_t {

to

enum MagicEffectClasses : uint16_t {

then change all of these from uint8_t type to uint16_t type
forgottenserver/protocolgame.cpp at 768ec435e27e53a045181c7d9e65a0b39abd5c6f · otland/forgottenserver · GitHub
forgottenserver/protocolgame.h at 71b0479ee2c675175487601bbd7387df58437df0 · otland/forgottenserver · GitHub
forgottenserver/player.h at 71b0479ee2c675175487601bbd7387df58437df0 · otland/forgottenserver · GitHub

change these from uint8_t effect to uint16_t effect
forgottenserver/game.cpp at master · otland/forgottenserver · GitHub
forgottenserver/game.cpp at master · otland/forgottenserver · GitHub

actually im doing this because i want to have spells with the custom animations, but a friend told me this is not necesary, that if i put the number instead of the name should work, but it doesn't, it just cast a tibia spell effect, do you know why? (not in the !z talkaction, in the spell)

 

[jestem pro]

Just add them to the .spr/.dat file and eventually change the range of effects in the talkaction script related to effects. This should work.

going with your problem maybe add them to lib (8.6)/ global.lua(1.×)

 

[tekadon2]

I'm having the same problem, I've done all the modifications but the spells only show effects until 255.
The! Z command uses the command to the maximum.

 

[chrallaz]

I know this is an old thread.
I followed @Infernum 's guide on this "EVEN THO" I'm using OTServBR
Everything executes correctly in MSVC 2022 but!!! Its not showing my effect 256 or 257 I added above.

I know probably for me const.h is utils_definitions.hpp since its were I can find.

enum MagicEffectClasses : uint8_t {

which I changed to

enum MagicEffectClasses : uint16_t {

Then I followed

then change all of these from uint8_t type to uint16_t type
forgottenserver/protocolgame.cpp at 768ec435e27e53a045181c7d9e65a0b39abd5c6f · otland/forgottenserver · GitHub
forgottenserver/protocolgame.h at 71b0479ee2c675175487601bbd7387df58437df0 · otland/forgottenserver · GitHub
forgottenserver/player.h at 71b0479ee2c675175487601bbd7387df58437df0 · otland/forgottenserver · GitHub

Which all lines up correctly. Just differences in which "lines".


!!!! But here is where I think my problem occurs.

change these from uint8_t effect to uint16_t effect
forgottenserver/game.cpp at master · otland/forgottenserver · GitHub
forgottenserver/game.cpp at master · otland/forgottenserver · GitHub

I cannot seem to find exactly were to change these lines for OTServBR
Because I check these lines and they look already pretty much the same as TFS
Does anyone wanna help me out? <3


So I was guessing around but I can't compile this.

 

[amatria]

This is pure speculation, but if you are now using a uint16_t type for the effectId, these lines should change

forgottenserver/src/protocolgame.cpp at 768ec435e27e53a045181c7d9e65a0b39abd5c6f · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

to

msg.add<uint16_t>(type);

!! Disclaimer: Not tested. This change may debug your client.

 

[chrallaz]

This is pure speculation, but if you are now using a uint16_t type for the effectId, these lines should change

forgottenserver/src/protocolgame.cpp at 768ec435e27e53a045181c7d9e65a0b39abd5c6f · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

to

msg.addByte(type >> 8);
msg.addByte(type);

!! Disclaimer: Not tested. This change may debug your client.

I Will try it later on. Thanks for checking mano
I'll get back asap with an answer.

Post automatically merged: Jun 6, 2022

This is pure speculation, but if you are now using a uint16_t type for the effectId, these lines should change

forgottenserver/src/protocolgame.cpp at 768ec435e27e53a045181c7d9e65a0b39abd5c6f · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

to

msg.add<uint16_t>(type);

!! Disclaimer: Not tested. This change may debug your client.

Alright yes your correct, with OTC I can login now but its some what buggy.
With Normal Client it crasches instantly now.

How would I approach this issue with OTC client?

 

[amatria]

What do you mean by "somewhat buggy"? Are you able to see the new effects? Or, for instance, are you seeing only a small subset of all the available effects?

How would I approach this issue with OTC client?

I would start my research here:

otcv8-dev/src/client/protocolgameparse.cpp at 817ddfe73301a9f05f9e9aa388c86bf04f179ef0 · OTCv8/otcv8-dev

OTCv8 Development repository (source code). Contribute to OTCv8/otcv8-dev development by creating an account on GitHub.

github.com

As you can see, after it parses the position, it extracts a uint8_t value from the InputMessagePtr.

Now that you send 2 bytes of information from your server, all those lines should be reading exactly 2 bytes of information.
e.g.

otcv8-dev/src/client/protocolgameparse.cpp at 817ddfe73301a9f05f9e9aa388c86bf04f179ef0 · OTCv8/otcv8-dev

OTCv8 Development repository (source code). Contribute to OTCv8/otcv8-dev development by creating an account on GitHub.

github.com

otcv8-dev/src/client/protocolgameparse.cpp at 817ddfe73301a9f05f9e9aa388c86bf04f179ef0 · OTCv8/otcv8-dev

OTCv8 Development repository (source code). Contribute to OTCv8/otcv8-dev development by creating an account on GitHub.

github.com

otcv8-dev/src/client/protocolgameparse.cpp at 817ddfe73301a9f05f9e9aa388c86bf04f179ef0 · OTCv8/otcv8-dev

OTCv8 Development repository (source code). Contribute to OTCv8/otcv8-dev development by creating an account on GitHub.

github.com

Afterwards, follow the flow of the program and find all the functions that consume the 2 bytes long effectId and change the datatype to uint16_t. And so on and so forth. Best of luck, this is kind of a tedious process. However, isn't there a thread here in OTLand that implements this same functionality?