C++ alana sio

[Sigoles]

The problem is that the command is giving to use even with the player (that typed the command) outside the house.

How I can make an check for this in c++?

bool InstantSpell::HouseKick(const InstantSpell*, Creature* creature, const std::string& param)
{
    Player* player = creature->getPlayer();

    Player* targetPlayer = g_game.getPlayerByName(param);
    if (!targetPlayer) {
        targetPlayer = player;
    }

    House* house = getHouseFromPos(targetPlayer);
    if (!house) {
        g_game.addMagicEffect(player->getPosition(), CONST_ME_POFF);
        player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE);
        return false;
    }

    if (!house->kickPlayer(player, targetPlayer)) {
        g_game.addMagicEffect(player->getPosition(), CONST_ME_POFF);
        player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE);
        return false;
    }
    return true;
}

tfs 1.2

 

[SpiderOT]

bool InstantSpell::HouseKick(const InstantSpell*, Creature* creature, const std::string& param)
{
    Player* player = creature->getPlayer();
    Player* targetPlayer = g_game.getPlayerByName(param);
    if (!targetPlayer) {
        targetPlayer = player;
    }
    House* house = getHouseFromPos(targetPlayer);
    House* phouse = getHouseFromPos(player);
    if (!house || !phouse || (house->getId() != phouse->getId()) {
        g_game.addMagicEffect(player->getPosition(), CONST_ME_POFF);
        player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE);
        return false;
    }
    if (!house->kickPlayer(player, targetPlayer)) {
        g_game.addMagicEffect(player->getPosition(), CONST_ME_POFF);
        player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE);
        return false;
    }
    return true;
}