Anti fake admin

[hepy]

Hi im trying to make a script that checks on login if the player have acces > 0, if so it checks the name of the admin and if it is one of them the script allows him to enter to the server, if no, the player will be kicked, set acces to 0 and also ban him
i have this: but idk whats wrong with it... for now instead of kicking player its checks if it is in the admin lists or no.. but when i try to login, i get no error but in the server console says: [8:51:20.716] Alberto has logged in.
[8:51:20.727] Alberto has logged out.

function onLogin(cid)
name = getPlayerName(cid)
	if getPlayerAccess(cid) > 0 then
		if (getCreatureName(cid) == "Alberto") then
       	doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "admin")
		else
       	doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "wrong admin")
		end
	end
end

thanks

 

[Dominik ms]

local admins = {"Dominik", "Lol User", "Alberto"}
function onLogin(cid)
local name = getCreatureName(cid)
	if(getPlayerAccess(cid) > 0) then
		if(not isInArray(admins, name) then
			doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "wrong admin")
			--ban script
			doAddPlayerBanishment(name, BAN_ACCOUNT, -1, ACTION_BANFINAL)
			return false
		end
	end
	doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "admin")
	return true
end

I never test ban script.

 

[Dante_]

local staffMembers = {"Dominik"}
function onLogin(cid)
local staffName = getCreatureName(cid)
	if(getPlayerAccess(cid) > 0 and not isInArray(staffMembers, staffName)) then
		print(staffName .. " has been denied login because they have access " .. getPlayerAccess(cid) .. ".")
		return false
	end
	return true
end

Instead of banning the character, it does not allow them to login and it sends the server a message explaining that the player was not allowed to log in so you can check your server to fix that.

 

[hepy]

thanks, works fine!
just to learn something with this, what was wrong with my code?
first this line:

name = getPlayerName(cid)

local name = getPlayerName(cid)

what else? thanks

 

[Dominik ms]

local it is not your problem.
Your problem is in returns.

 

[JDB]

This will allow only your IP to log on with the God. It will kick anyone else.

local ip = {"127.0.0.1", "127.0.0.1"}
local access = 5
function onLogin(cid)
	if getPlayerAccess(cid) >= access then
		if not isInArray(ip, getPlayerIp(cid)) then
			doRemoveCreature(cid, true)
			print(getPlayerIp(cid) .. " has tried to log onto your God.")
		end
	end
	
	return true
end

Console message

55.555.55.555 has tried to log onto your God.

 

[hepy]

@jdb: wow nice! but what about dinamic ips? could i add a no-ip dns instead an ip?

@dominik ms: thanks, i will read a "returns" tutorial or something like that

 

[JDB]

@jdb: wow nice! but what about dinamic ips? could i add a no-ip dns instead an ip?

To be honest, I am not sure. You will have to test that.

 

[zakius]

serv gets only numeric ip of client, but you can try coding sth asking dns serv or domain <=>ip converter like DNS <-> IP converter to get text adress

 

[hepy]

is there a lua function that can do that?:S

 

[zakius]

using lua socket you probably can send request containing ip and then somehow parse answer, but honestly, I have no idea how

 

[hepy]

hmm.. i really dont have any clue how to script that :S i still have problems with the "returns" hahahah
any idea?