Any ideas how to break 2b HP limit in monsters?

[Dran Ryszard]

Any ideas how to break 2b HP limit in monsters?
TFS 1.5 Downgraded 8.6 Nekiro

I was change all what i found with health/monsters int/uint32 to int/uint64 but still limit is 2.1B
Changed files:
creature.h
creature.cpp
iologindata.cpp
luascript.cpp
monster.cpp
monster.h
player.cpp (but here i think is only about hp for player?, but on player hp limit is still 2.1b, so that needed something more)
player.h(up)

 

[Tofame]

Client also needs those changes.

 

[oen432]

Client also needs those changes.

No. Client has no clue what the real hp of creatures are (only own character).

 

[Tofame]

No. Client has no clue what the real hp of creatures are (only own character).

So battlelist gets %hp value from server?

My guess then is that monster HP parser from XML on serverside, that intvalue is capped at 2 billions.

 

[oen432]

So battlelist gets %hp value from server?

Yes, its only hp percentage.

 

[Dran Ryszard]

So any ideas?

 

[Evil Hero]

protocolgame.cpp
search for:
void ProtocolGame::sendCreatureHealth(const Creature* creature)
void ProtocolGame::AddCreature(NetworkMessage& msg, const Creature* creature, bool known, uint32_t remove)
and apply your changes, should be working then

 

[Dran Ryszard]

void ProtocolGame::sendCreatureHealth(const Creature* creature)

Changed but still limit not brake :/
I tried change uint32_t inside function too, but then i get few bugs when i login to the game, i don't see health and character outfit, and few sqm on the map be only black.

protocolgame.cpp

void ProtocolGame::AddCreature(NetworkMessage& msg, const Creature* creature, bool known, uint64_t remove)
{
    const Player* otherPlayer = creature->getPlayer();
    if (known) {
        msg.add<uint16_t>(0x62);
        msg.add<uint32_t>(creature->getID());
    } else {
        msg.add<uint16_t>(0x61);
        msg.add<uint32_t>(remove);
        msg.add<uint32_t>(creature->getID());
                const Monster* monster = creature->getMonster();
        if (monster && monster->getLevel() > 0) {
            msg.addString(creature->getName() + " [" + std::to_string(monster->getLevel()) + "]");
        } else {
            msg.addString(creature->getName());
        }
    }

    if (creature->isHealthHidden()) {
        msg.addByte(0x00);
    } else {
        msg.addByte(std::ceil((static_cast<double>(creature->getHealth()) / std::max<int64_t>(creature->getMaxHealth(), 1)) * 100));
    }

    msg.addByte(creature->getDirection());

    if (!creature->isInGhostMode() && !creature->isInvisible()) {
        AddOutfit(msg, creature->getCurrentOutfit());
    } else {
        static Outfit_t outfit;
        AddOutfit(msg, outfit);
    }

    LightInfo lightInfo = creature->getCreatureLight();
    msg.addByte(player->isAccessPlayer() ? 0xFF : lightInfo.level);
    msg.addByte(lightInfo.color);

    msg.add<uint16_t>(creature->getStepSpeed());

    msg.addByte(creature->getSkullClient(creature));
    msg.addByte(player->getPartyShield(otherPlayer));

    if (!known) {
        msg.addByte(player->getGuildEmblem(otherPlayer));
    }

    msg.addByte(player->canWalkthroughEx(creature) ? 0x00 : 0x01);
}

void ProtocolGame::sendCreatureHealth(const Creature* creature)
{
    NetworkMessage msg;
    msg.addByte(0x8C);
    msg.add<uint64_t>(creature->getID());

    if (creature->isHealthHidden()) {
        msg.addByte(0x00);
    } else {
        msg.addByte(std::ceil((static_cast<double>(creature->getHealth()) / std::max<int64_t>(creature->getMaxHealth(), 1)) * 100));
    }
    writeToOutputBuffer(msg);
}

protocolgame.h

        void AddCreature(NetworkMessage& msg, const Creature* creature, bool known, uint64_t remove);

 

[Marko999x]

Do you need it for creatures only?

 

[oen432]

Do you need it for creatures only?

Npc, players and monsters are creatures.

 

[Marko999x]

Npc, players and monsters are creatures.

Yes but that wasn't my question but its prob because I wrote it wrong
I got ready to use source from Nekiro which contains more int32 to int64 changes than only for "health"
That's the reason why I asked him it so I can just send him the source and he can compare it or use it

Anyway,
@Dran Ryszard
You can check those source and compare what you missed

 

[Dran Ryszard]

Yes but that wasn't my question but its prob because I wrote it wrong
I got ready to use source from Nekiro which contains more int32 to int64 changes than only for "health"
That's the reason why I asked him it so I can just send him the source and he can compare it or use it

Anyway,
@Dran Ryszard
You can check those source and compare what you missed

Ye, only for monsters, thanks i will check it