are these scripts correct?

[stonger]

i am using this vip system: http://otland.net/f163/best-vip-system-functions-vip-account-30286/

i know nothing of this. i just picked some things and putted them together.


and i wanted to make everything automatic. so, instead of the command, i created a rune. this is the script:

function onUse(cid, item, fromPosition, itemEx, toPosition) 

            doSendAnimatedText(getPlayerPosition(cid), "CONGRATulations!", TEXTCOLOR_RED)  
            doCreatureSay(cid, "Now you are vip blahblahblah!!", TALKTYPE_ORANGE_1) 
            doAccountAddVipTime(getPlayerAccount(player), days) + 7 
            doRemoveItem(item.uid, 1) 

    end     
return TRUE 
end

an this is the vip door:

function onUse(cid, item, fromPosition, itemEx, toPosition) 
    local cidPosition = getCreaturePosition(cid) 
        if (item.actionid == 5788 and  

    #####this is where what I did starts####     
        if(isVip(accountName))then  
            time = getAccountVipTime(accountName)  
            if(time > 0)then  

    ####this is where what i did finishes#### 
         
            ) then 
            if cidPosition.x < toPosition.x then 
                doTeleportThing(cid, {x=toPosition.x+1,y=toPosition.y,z=toPosition.z}, TRUE) 
                                doCreatureSay(cid, "BIENVENIDO VIP!", TALKTYPE_ORANGE_1) 
            else 
                doTeleportThing(cid, {x=toPosition.x-1,y=toPosition.y,z=toPosition.z}, TRUE) 
                                doCreatureSay(cid, "BIENVENIDO VIP!", TALKTYPE_ORANGE_1) 
            end 
            return TRUE 
        else

the one that help me to correct these scripts earn rep ^_^

 

[Cykotitan]

door script

function onUse(cid, item, fromPosition, itemEx, toPosition)  
	if(item.actionid == 5788 and isVip(accountName) and getAccountVipTime(accountName) > 0) then 
		doCreatureSay(cid, "BIENVENIDO VIP!", TALKTYPE_ORANGE_1)  
		doTeleportThing(cid, {x=getCreaturePosition(cid).x < toPosition.x and toPosition.x+1 or toPosition.x-1,y=toPosition.y,z=toPosition.z}, TRUE)
		return TRUE  
	end
end

 

[stonger]

Thanks a lot.
but... what is wrong with the rune? =D

 

[Cykotitan]

function onUse(cid, item, fromPosition, itemEx, toPosition)
	doSendAnimatedText(getCreaturePosition(cid), "CONGRATulations!", TEXTCOLOR_RED)
	doCreatureSay(cid, "Now you are vip blahblahblah!!", TALKTYPE_ORANGE_1)
	doAccountAddVipTime(getPlayerAccount(cid), 7 * 86400)
	doRemoveItem(item.uid, 1)   
	return true
end

 

[stonger]

thanks a lot =D:wub::wub::wub::wub: