Autoloot script error screen

[Sigoles]

This work normal but sometimes got an error on screen:

Script:

local function scanContainer(cid, position)
    local player = Player(cid)
    if not player then
        return
    end

    local corpse = Tile(position):getTopDownItem()
    if not corpse then
        return
    end

    if corpse:getType():isCorpse() and corpse:getAttribute(ITEM_ATTRIBUTE_CORPSEOWNER) == cid then
        for a = corpse:getSize() - 1, 0, -1 do
            local containerItem = corpse:getItem(a)
            if containerItem then
                for b = AUTOLOOT_STORAGE_START, AUTOLOOT_STORAGE_END do
                    if player:getStorageValue(b) == containerItem:getId() then
                        containerItem:moveTo(player)
                    end
                end
            end
        end
    end
end

function onKill(player, target)
    if not target:isMonster() then
        return true
    end

    addEvent(scanContainer, 100, player:getId(), target:getPosition())
    return true
end

Help? Thanks

 

[Infernum]

Tile(position):getTopDownItem() returns an item object
items don't have getSize method so you have to turn it into a container
Container(Tile(position):getTopDownItem())

 

[silveralol]

Tile(position):getTopDownItem() returns an item object
items don't have getSize method so you have to turn it into a container
Container(Tile(position):getTopDownItem())

don't work the line code ..
always enter in this if

if not corpse then
        return
    end

I fix this using

local corpse = Tile(position):getTopDownItem()
    if not corpse or not corpse:isContainer() then
        return
    end

works fine

 

[Infernum]

don't work the line code ..
always enter in this if

if not corpse then
        return
    end

Container(Tile(position):getTopDownItem().uid)
forgot the uid

 

[Infernum]

I fix this using

local corpse = Tile(position):getTopDownItem()
    if not corpse or not corpse:isContainer() then
        return
    end

works fine

that doesnt work because corpse still returns an item not a container
corpse:isContainer() can still return true since it has a container flag but isn't a container userdata
you have to turn it into a container userdata to use the methods

 

[silveralol]

that doesnt work because corpse still returns an item not a container
corpse:isContainer() can still return true since it has a container flag but isn't a container userdata
you have to turn it into a container userdata to use the methods

I don't understand :/ could you give me an exemple that show me when my attempt to fix don't work ?
testing your code get:

data/creaturescripts/scripts/others/autoloot.lua:15: attempt to index a nil value
stack traceback:
        [C]: in function '__index'
        data/creaturescripts/scripts/others/autoloot.lua:15: in function <data/creaturescripts/scripts/others/autoloot.lua:9>

 

[Infernum]

I don't understand :/ could you give me an exemple that show me when my attempt to fix don't work ?
testing your code get:

data/creaturescripts/scripts/others/autoloot.lua:15: attempt to index a nil value
stack traceback:
        [C]: in function '__index'
        data/creaturescripts/scripts/others/autoloot.lua:15: in function <data/creaturescripts/scripts/others/autoloot.lua:9>

nevermind i guess it inherits container if it has container flag
could have sworn that didnt work
my code still works if you put uid though

 

[Sigoles]

Hey I got one error using:
local corpse = Container(Tile(position):getTopDownItem().uid)

The line 7 is:
local corpse = Container(Tile(position):getTopDownItem().uid)


http://prnt.sc/dbdit7

 

[Printer]

Doing what @silveralol provided should fix the error.