bad argument #1 to 'find' string expected, got nill

[SixNine]

TFS 1.2

    elseif isInArray(arrayGreetings, msg) and not npcHandler:isFocused(cid) then
        npcHandler:addFocus(cid)
        if string.find(playerGreetMessage, "|PLAYERNAME|") then --here
            local newMsg = string.gsub(playerGreetMessage, "|PLAYERNAME|", player:getName())
            selfSay(newMsg, cid)
        else
            selfSay(playerGreetMessage, cid)
        end
     
    elseif isInArray(arrayFarewell, msg) and npcHandler:isFocused(cid) then
        if string.find(playerGoodbyeMessage, "|PLAYERNAME|") then -- here
            local newMsg = string.gsub(playerGoodbyeMessage, "|PLAYERNAME|", player:getName())
            selfSay(newMsg, cid)
        else
            selfSay(playerGoodbyeMessage, cid)
        end
        npcHandler:releaseFocus(cid)

 

[SixNine]

bump

 

[Infernum]

the greet/goodbye messages if u read the error are nil

 

[SixNine]

the greet/goodbye messages if u read the error are nil

But how is that respond to message "hi" gives a nil value

 

[Infernum]

read the error it says its in string.find in the code you posted and you even commented the lines

 

[SixNine]

read the error it says its in string.find in the code you posted and you even commented the lines

Yea but what should i do is there like different function instead of string.find? Or maybe something like this? Have no idea

if string.find(playerGreetMessage, "|PLAYERNAME|") < 0 then

 

[Infernum]

no the message is literally nil it says argument #1 in the error message to string.find
don't know what else to tell you because i don't know what that message is supposed to say or what that npc is or where its from

 

[SixNine]

no the message is literally nil it says argument #1 in the error message to string.find
don't know what else to tell you because i don't know what that message is supposed to say or what that npc is or where its from

Its Itutorial advanced npc

Advanced Task NPC

This is a pretty advanced task npcs set up. I did test it but only enough to know that it works as intended. There could be small bugs I didn't think about or find during the testing. Here is a list of what is in the code. --EDIT: I have created this code in Modal Windows aswell. It is a few...

otland.net

 

[SixNine]

anyone?

 

[SixNine]

bump

 

[SixNine]

bump

 

[Ralumbi]

@SixNine could you be more specific? What is the console error you're receiving? Transfering scripts from 1.x to 1.3-4 can give many of such type or errors since a lot of functions have been rewritten.

note: don't bump your post this much, won't really help

 

[SixNine]

@SixNine could you be more specific? What is the console error you're receiving? Transfering scripts from 1.x to 1.3-4 can give many of such type or errors since a lot of functions have been rewritten.

note: don't bump your post this much, won't really help

Sorry somehow imagine disappeared with error from this thread

 

[Ralumbi]

Sorry somehow imagine disappeared with error from this thread
View attachment 49643

Can you show us your taskmaster.lua? Will be easier to see what might be wrong.

 

[SixNine]

Can you show us your taskmaster.lua? Will be easier to see what might be wrong.

This one Advanced Task NPC (https://otland.net/threads/advanced-task-npc.266598/)

 

[Ralumbi]

@SixNine you should start with changing MESSAGES_GREET to MESSAGE_GREET same goes for other ones being written as MESSAGES. These global variables have been changed in time to MESSAGE_XXX instead.

So in your case you must change these lines:

line 118: local playerGreetMessage = MESSAGES_GREET[player:getStorageValue(npcStorage)]
to
line 118: local playerGreetMessage = MESSAGE_GREET[player:getStorageValue(npcStorage)]

and

line 119: local playerGoodbyeMessage = MESSAGES_GOODBYE[player:getStorageValue(npcStorage)]
to
line 119: local playerGoodbyeMessage = MESSAGE_GOODBYE[player:getStorageValue(npcStorage)]

Hope it works for you. Most likely the error message will change which accomplish our goal here

 

[SixNine]

@SixNine you should start with changing MESSAGES_GREET to MESSAGE_GREET same goes for other ones being written as MESSAGES. These global variables have been changed in time to MESSAGE_XXX instead.

So in your case you must change these lines:

line 118: local playerGreetMessage = MESSAGES_GREET[player:getStorageValue(npcStorage)]
to
line 118: local playerGreetMessage = MESSAGE_GREET[player:getStorageValue(npcStorage)]

and

line 119: local playerGoodbyeMessage = MESSAGES_GOODBYE[player:getStorageValue(npcStorage)]
to
line 119: local playerGoodbyeMessage = MESSAGE_GOODBYE[player:getStorageValue(npcStorage)]

Hope it works for you. Most likely the error message will change which accomplish our goal here

You sure its the solution? because getting same error

 

[Ralumbi]

I didn't say it was the solution. But I know it has been changed.

The best would be that @Itutorial would check further on this since he wrote the code and most likely dealt with similar errors.
Hoping for the best if he would help you fixing your issue. I sadly do not have enough time to figure this out completely by reproducing the error right now.

 

[Itutorial]

So i added array greeting to my npc lib file and forgot to add it in the code possibly. That would be my guess. You should create a table named arrayGreatings = {"hi"}

same with
playerGoodbyeMessage

 

[SixNine]

So i added array greeting to my npc lib file and forgot to add it in the code possibly. That would be my guess. You should create a table named arrayGreatings = {"hi"}

Yea he responds now, but

EDIT: SOLUTION WAS IN THE ORIGINAL THREAD