NPC Bank NPC for TFS 0.3beta

[Moqill]

Good job Gensior. I likes this script!

 

[muttleyxd]

But what about sending cash to **** Sample ??
Anyone can send a lot of cash to Rook Sample, then create characters and have looooooooooooooooooooooooooooooooots of cash.

 

[mamon_2]

But what about sending cash to **** Sample ??
Anyone can send a lot of cash to Rook Sample, then create characters and have looooooooooooooooooooooooooooooooots of cash.

Solution,go to config/config.php line 16, change de rook sample, for another char X.

 

[Pietia]

u can clone cash by that scritp ;]
deposit 5454545454545454545
;]

 

[Jamzitox]

Yeah Nice Gesior TNx

 

[Kayan]

15:37 Bank: Greetings CM Kiel. I'm banker.
15:37 CM Kiel [10]: deposit 50000000000000
15:37 Bank: How much gold you would like to deposit?
15:37 Bank: Would you really like to deposit 50000000000000 gold coins?
15:37 CM Kiel [10]: yes
15:37 Bank: You deposited 50000000000000 gold coins. Now your account balance is 50000000000000 gold coins.
15:37 CM Kiel [10]: balance
15:37 Bank: Your account balance is 50000000000000 gold coins.
15:37 CM Kiel [10]: withdraw 500
15:37 Bank: How much gold you would like to withdraw?
15:37 Bank: Would you really like to withdraw 500 gold coins?
15:37 CM Kiel [10]: yes
15:37 Bank: You withdrawed 500 gold coins. Now your account balance is 49999999999500 gold coins.

hAUhauHAu Dont use.

 

[Gesior.pl]

I forgot about this ooooolllldddd bug with big values in LUA, anyone can update script and fix this bug?

 

[Gesior.pl]

But what about sending cash to **** Sample ??
Anyone can send a lot of cash to Rook Sample, then create characters and have looooooooooooooooooooooooooooooooots of cash.

My acc. maker should not copy bank account balance from sample characters (and of course doesnt copy depot [parcels]) o0
I think about it before post first version of acc. maker (~2 years ago).

u can clone cash by that scritp ;]
deposit 5454545454545454545
;]

Fixed.
Old:

function getCount(msg)
    local ret = -1
    local b, e = string.find(msg, "%d+")
    if b ~= nil and e ~= nil then
       ret = tonumber(string.sub(msg, b, e))
    end
 
    return ret
end

New:

function getCount(msg)
	local ret = -1
	local b, e = string.find(msg, "%d+")
    if b ~= nil and e ~= nil then
       ret = tonumber(string.sub(msg, b, e))
    end
	if ret > 10000000 then
		return 10000000
	end
    return ret
end

13:05 Erg [93]: deposit 545454545454
13:05 Bank: Would you really like to deposit 545454545454 gold coins?
13:05 Erg [93]: yes
13:05 Bank: You deposited 545454545454 gold coins. Now your account balance is 545454545454 gold coins.
13:06 Erg [93]: /reload npc -- fixed function
13:06 Erg [93]: hi
13:06 Bank: Greetings Erg. I'm banker.
13:06 Erg [93]: deposit 545454545454
13:06 Bank: Would you really like to deposit 10000000 gold coins?
13:06 Erg [93]: yes
13:06 Bank: You don't have 10000000 gold coins.

EDIT:
Fixed bug with npc say texts (on 0.3.5 send 2 texts in same time, fixed).

 

[Samme]

Lua Script Error: [Npc interface]
data/npc/scripts/bank.luanCreatureSay

data/npc/scripts/bank.lua:75: attempt to index global 'talk_state' (a number value)
stack traceback:
data/npc/scripts/bank.lua:75: in function 'callback'
data/npc/lib/npcsystem/npchandler.lua:383: in function 'onCreatureSay'
data/npc/scripts/bank.lua:59: in function <data/npc/scripts/bank.lua:59>

get this error, when I say

17:14 Soy Polaco [29]: hi
17:14 Joe: Greetings Soy Polaco. I'm banker.
17:14 Soy Polaco [29]: balance
17:14 Soy Polaco [29]: deposit all
17:15 Soy Polaco [29]: hi
17:15 Soy Polaco [29]: balance
17:17 Joe: Good bye, Soy Polaco!

 

[Gesior.pl]

i dont know why you get this error, but try to change in line 75:

if talk_state[cid] == nil then

with:

if not talk_state[cid] then

what version of tfs do you use?

 

[Samme]

I'm using latest private SVN.

 

[Gesior.pl]

I'm using latest private SVN.

Tell me rev., because I use rev. 2005 (between 0.3.4 and 0.3.5), but latest rev. I downloaded is 2889 (0.3.6 beta). Maybe there are some important changes, but I dont know what can make error like yours.

 

[Samme]

I'm using something around 2718.

Well, the sugestion that you posted don't help.

Its something like that:

When I reload NPCs everything is OK.
- Player talk with banker, everything is OK.
- Player leave and go hunt.
- Player back to the banker to deposit money and then NPC after msg "hi" won't reply if I say "balance" or "deposit" or "withdraw"...

Same error

Lua Script Error: [Npc interface]
data/npc/scripts/bank.luanCreatureSay

data/npc/scripts/bank.lua:76: attempt to index global 'talk_state' (a number value)
stack traceback:
data/npc/scripts/bank.lua:76: in function 'callback'
data/npc/lib/npcsystem/npchandler.lua:390: in function 'onCreatureSay'
data/npc/scripts/bank.lua:60: in function <data/npc/scripts/bank.lua:60>

 

[Samme]

are you going to fix that?

 

[zirokiller]

Bug:

How to fix this? :S

dude thats 0.2? look like 0.3. ........................................

 

[Entral]

does it works for 0.3.5?

 

[Raiden]

this works for 0.2?

 

[frankfarmer]

Works perfectly for 0.3.5 pl1

 

[C00KIE]

@^
tested also.. works 100%
GJ
+rep

 

[Cykotitan]

If you want a decent banker script for 0.2, use the one I made: http://otland.net/f83/0-2-0-fully-working-banker-npc-script-47370/