• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Lua Bug free potions script - TFS 0.X

potinho

Intermediate OT User
Joined
Oct 11, 2009
Messages
1,397
Solutions
17
Reaction score
148
Location
Brazil
Hello guys, I am finishing doing a bug review on my server and the last item is the mana / life / beer fluids script. When I'm running and using the hotkey, my distro gives an error. Could you help me with a functional code? I searched several forums and found nothing.
 
what is your server? and your script? and the error? 🤔
Had an OTX Server 7.72, my script bellow:

Lua:
local ITEM_RUM_FLASK = 5553

local TYPE_EMPTY = 0
local TYPE_WATER = 1
local TYPE_BLOOD = 2
local TYPE_BEER = 3
local TYPE_SLIME = 4
local TYPE_LEMONADE = 5
local TYPE_MILK = 6
local TYPE_MANA_FLUID = 7
local TYPE_LIFE_FLUID = 10
local TYPE_OIL = 11
local TYPE_URINE = 13
local TYPE_COCONUT_MILK = 14
local TYPE_WINE = 15
local TYPE_MUD = 19
local TYPE_FRUIT_JUICE = 21
local TYPE_LAVA = 26
local TYPE_RUM = 27
local TYPE_SWAMP = 28
local TYPE_TEA = 35

local oilLamps = {[2046] = 2044}
local casks = {[1771] = TYPE_WATER, [1772] = TYPE_BEER, [1773] = TYPE_WINE}
local alcoholDrinks = {TYPE_BEER, TYPE_WINE, TYPE_RUM}
local poisonDrinks = {TYPE_SLIME, TYPE_SWAMP}

local drunk = createConditionObject(CONDITION_DRUNK)
setConditionParam(drunk, CONDITION_PARAM_TICKS, 60000)

local poison = createConditionObject(CONDITION_POISON)
setConditionParam(poison, CONDITION_PARAM_DELAYED, true) -- Condition will delay the first damage from when it's added
setConditionParam(poison, CONDITION_PARAM_MINVALUE, -50) -- Minimum damage the condition can do at total
setConditionParam(poison, CONDITION_PARAM_MAXVALUE, -120) -- Maximum damage
setConditionParam(poison, CONDITION_PARAM_STARTVALUE, -5) -- The damage the condition will do on the first hit
setConditionParam(poison, CONDITION_PARAM_TICKINTERVAL, 4000) -- Delay between damages
setConditionParam(poison, CONDITION_PARAM_FORCEUPDATE, true) -- Re-update condition when adding it(ie. min/max value)

local burn = createConditionObject(CONDITION_FIRE)
setConditionParam(burn, CONDITION_PARAM_DELAYED, true) -- Condition will delay the first damage from when it's added
setConditionParam(burn, CONDITION_PARAM_MINVALUE, -70) -- Minimum damage the condition can do at total
setConditionParam(burn, CONDITION_PARAM_MAXVALUE, -150) -- Maximum damage
setConditionParam(burn, CONDITION_PARAM_STARTVALUE, -10) -- The damage the condition will do on the first hit
setConditionParam(burn, CONDITION_PARAM_TICKINTERVAL, 10000) -- Delay between damages
setConditionParam(burn, CONDITION_PARAM_FORCEUPDATE, true) -- Re-update condition when adding it(ie. min/max value)

function onUse(cid, item, fromPosition, itemEx, toPosition)
    if(doComparePositions(getCreaturePosition(cid), toPosition))then
        itemEx.uid = cid
    end

    if(itemEx.uid == cid) then
        if(item.type == TYPE_EMPTY) then
            doPlayerSendCancel(cid, "It is empty.")
            return true
        end

        if(item.type == TYPE_MANA_FLUID) then
            if(not doPlayerAddMana(itemEx.uid, math.random(40, 80))) then
                return false
            end

            doCreatureSay(itemEx.uid, "Aaaah...", TALKTYPE_MONSTER_SAY)
            doSendMagicEffect(toPosition, CONST_ME_MAGIC_BLUE)
        elseif(item.type == TYPE_LIFE_FLUID) then
            if(not doCreatureAddHealth(itemEx.uid, math.random(40, 80))) then
                return false
            end

            doCreatureSay(itemEx.uid, "Aaaah...", TALKTYPE_MONSTER_SAY)
            doSendMagicEffect(toPosition, CONST_ME_MAGIC_BLUE)
        elseif(isInArray(alcoholDrinks, item.type)) then
            if(not doTargetCombatCondition(0, cid, drunk, CONST_ME_NONE)) then
                return false
            end

            doCreatureSay(cid, "Aaah...", TALKTYPE_MONSTER_SAY)
        elseif(isInArray(poisonDrinks, item.type)) then
            if(not doTargetCombatCondition(0, cid, poison, CONST_ME_NONE)) then
                return false
            end

            doCreatureSay(cid, "Urgh!", TALKTYPE_MONSTER_SAY)
        elseif(item.type == TYPE_LAVA) then
            if(not doTargetCombatCondition(0, cid, burn, CONST_ME_NONE)) then
                return false
            end

            doCreatureSay(cid, "Urgh!", TALKTYPE_MONSTER_SAY)
        else
            doCreatureSay(cid, "Gulp.", TALKTYPE_MONSTER_SAY)
        end

        doChangeTypeItem(item.uid, TYPE_EMPTY)
        return true
    end

    if(not isCreature(itemEx.uid)) then
        if(item.type == TYPE_EMPTY) then
            if(isItemFluidContainer(itemEx.itemid) and itemEx.type ~= TYPE_EMPTY) then
                doChangeTypeItem(item.uid, itemEx.type)
                doChangeTypeItem(itemEx.uid, TYPE_EMPTY)
                return true
            end

            local tmp = casks[itemEx.itemid]
            if(tmp == nil) then
                tmp = getFluidSourceType(itemEx.itemid)
            end

            if(tmp) then
                doChangeTypeItem(item.uid, tmp)
                return true
            end

            doPlayerSendCancel(cid, "It is empty.")
            return true
        end

        local tmp = oilLamps[itemEx.itemid]
        if(item.type == TYPE_OIL and tmp ~= nil) then
            doTransformItem(itemEx.uid, tmp)
            doChangeTypeItem(item.uid, TYPE_NONE)
            return true
        end

        if(isItemFluidContainer(itemEx.itemid) and itemEx.type == TYPE_EMPTY) then
            doChangeTypeItem(itemEx.uid, itemEx.type)
            doChangeTypeItem(item.uid, TYPE_EMPTY)
            return true
        end

        if itemEx.uid > 0 and hasProperty(itemEx.uid, CONST_PROP_BLOCKSOLID) then
            return false
end
    end

    if(item.type == TYPE_EMPTY) then
        doPlayerSendCancel(cid, "It is empty.")
        return true
    end

local itemToDecay = doCreateItem(2016, item.type, toPosition)
if itemToDecay and itemToDecay > 0 then
    doDecayItem(itemToDecay)
    doChangeTypeItem(item.uid, TYPE_EMPTY)
end
    return true
end

When im running, console got this error:

[31/3/2021 16:28:23] [Error - Action Interface]
[31/3/2021 16:28:23] data/actions/scripts/liquids/potions.lua:eek:nUse
[31/3/2021 16:28:23] Description:
[31/3/2021 16:28:23] (LuaInterface::luaDoCreateItem) Tile not found

Up
 
I don't see an issue at all in the script.

So I added a check to confirm if there is a ground tile..
Not sure what else to do.

Lua:
local ITEM_RUM_FLASK = 5553

local TYPE_EMPTY = 0
local TYPE_WATER = 1
local TYPE_BLOOD = 2
local TYPE_BEER = 3
local TYPE_SLIME = 4
local TYPE_LEMONADE = 5
local TYPE_MILK = 6
local TYPE_MANA_FLUID = 7
local TYPE_LIFE_FLUID = 10
local TYPE_OIL = 11
local TYPE_URINE = 13
local TYPE_COCONUT_MILK = 14
local TYPE_WINE = 15
local TYPE_MUD = 19
local TYPE_FRUIT_JUICE = 21
local TYPE_LAVA = 26
local TYPE_RUM = 27
local TYPE_SWAMP = 28
local TYPE_TEA = 35

local oilLamps = {[2046] = 2044}
local casks = {[1771] = TYPE_WATER, [1772] = TYPE_BEER, [1773] = TYPE_WINE}
local alcoholDrinks = {TYPE_BEER, TYPE_WINE, TYPE_RUM}
local poisonDrinks = {TYPE_SLIME, TYPE_SWAMP}

local drunk = createConditionObject(CONDITION_DRUNK)
setConditionParam(drunk, CONDITION_PARAM_TICKS, 60000)

local poison = createConditionObject(CONDITION_POISON)
setConditionParam(poison, CONDITION_PARAM_DELAYED, true) -- Condition will delay the first damage from when it's added
setConditionParam(poison, CONDITION_PARAM_MINVALUE, -50) -- Minimum damage the condition can do at total
setConditionParam(poison, CONDITION_PARAM_MAXVALUE, -120) -- Maximum damage
setConditionParam(poison, CONDITION_PARAM_STARTVALUE, -5) -- The damage the condition will do on the first hit
setConditionParam(poison, CONDITION_PARAM_TICKINTERVAL, 4000) -- Delay between damages
setConditionParam(poison, CONDITION_PARAM_FORCEUPDATE, true) -- Re-update condition when adding it(ie. min/max value)

local burn = createConditionObject(CONDITION_FIRE)
setConditionParam(burn, CONDITION_PARAM_DELAYED, true) -- Condition will delay the first damage from when it's added
setConditionParam(burn, CONDITION_PARAM_MINVALUE, -70) -- Minimum damage the condition can do at total
setConditionParam(burn, CONDITION_PARAM_MAXVALUE, -150) -- Maximum damage
setConditionParam(burn, CONDITION_PARAM_STARTVALUE, -10) -- The damage the condition will do on the first hit
setConditionParam(burn, CONDITION_PARAM_TICKINTERVAL, 10000) -- Delay between damages
setConditionParam(burn, CONDITION_PARAM_FORCEUPDATE, true) -- Re-update condition when adding it(ie. min/max value)

function onUse(cid, item, fromPosition, itemEx, toPosition)
	if (doComparePositions(getCreaturePosition(cid), toPosition)) then
		itemEx.uid = cid
	end
	
	if (itemEx.uid == cid) then
		if (item.type == TYPE_EMPTY) then
			doPlayerSendCancel(cid, "It is empty.")
			return true
		end
	
		if (item.type == TYPE_MANA_FLUID) then
			if (not doPlayerAddMana(itemEx.uid, math.random(40, 80))) then
				return false
			end
	
			doCreatureSay(itemEx.uid, "Aaaah...", TALKTYPE_MONSTER_SAY)
			doSendMagicEffect(toPosition, CONST_ME_MAGIC_BLUE)
		elseif (item.type == TYPE_LIFE_FLUID) then
			if (not doCreatureAddHealth(itemEx.uid, math.random(40, 80))) then
				return false
			end
	
			doCreatureSay(itemEx.uid, "Aaaah...", TALKTYPE_MONSTER_SAY)
			doSendMagicEffect(toPosition, CONST_ME_MAGIC_BLUE)
		elseif (isInArray(alcoholDrinks, item.type)) then
			if (not doTargetCombatCondition(0, cid, drunk, CONST_ME_NONE)) then
				return false
			end
	
			doCreatureSay(cid, "Aaah...", TALKTYPE_MONSTER_SAY)
		elseif (isInArray(poisonDrinks, item.type)) then
			if (not doTargetCombatCondition(0, cid, poison, CONST_ME_NONE)) then
				return false
			end
	
			doCreatureSay(cid, "Urgh!", TALKTYPE_MONSTER_SAY)
		elseif (item.type == TYPE_LAVA) then
			if (not doTargetCombatCondition(0, cid, burn, CONST_ME_NONE)) then
				return false
			end
	
			doCreatureSay(cid, "Urgh!", TALKTYPE_MONSTER_SAY)
		else
			doCreatureSay(cid, "Gulp.", TALKTYPE_MONSTER_SAY)
		end
	
		doChangeTypeItem(item.uid, TYPE_EMPTY)
		return true
	end
	
	if (not isCreature(itemEx.uid)) then
		if (item.type == TYPE_EMPTY) then
			if (isItemFluidContainer(itemEx.itemid) and itemEx.type ~= TYPE_EMPTY) then
				doChangeTypeItem(item.uid, itemEx.type)
				doChangeTypeItem(itemEx.uid, TYPE_EMPTY)
				return true
			end
	
			local tmp = casks[itemEx.itemid]
			if (tmp == nil) then
				tmp = getFluidSourceType(itemEx.itemid)
			end
	
			if (tmp) then
				doChangeTypeItem(item.uid, tmp)
				return true
			end
	
			doPlayerSendCancel(cid, "It is empty.")
			return true
		end
	
		local tmp = oilLamps[itemEx.itemid]
		if (item.type == TYPE_OIL and tmp ~= nil) then
			doTransformItem(itemEx.uid, tmp)
			doChangeTypeItem(item.uid, TYPE_NONE)
			return true
		end
	
		if (isItemFluidContainer(itemEx.itemid) and itemEx.type == TYPE_EMPTY) then
			doChangeTypeItem(itemEx.uid, itemEx.type)
			doChangeTypeItem(item.uid, TYPE_EMPTY)
			return true
		end
	
		if itemEx.uid > 0 and hasProperty(itemEx.uid, CONST_PROP_BLOCKSOLID) then
			return false
		end
	end
	
	if (item.type == TYPE_EMPTY) then
		doPlayerSendCancel(cid, "It is empty.")
		return true
	end
	
	local groundTile = getThingFromPos({x = toPosition.x, y = toPosition.y, z = toPosition.z, stackpos = STACKPOS_GROUND})
	if groundTile.itemid == 0 then
		doPlayerSendCancel(cid, "Sorry, not possible.")
		return true
	end
	
	local itemToDecay = doCreateItem(2016, item.type, toPosition)
	if itemToDecay and itemToDecay > 0 then
		doDecayItem(itemToDecay)
		doChangeTypeItem(item.uid, TYPE_EMPTY)
	end
	return true
end
 
Im using OTClient, and using mana fluid when running. Still gotting this error:

[3/4/2021 9:38:29] [Error - Action Interface]
[3/4/2021 9:38:29] data/actions/scripts/liquids/potions.lua:eek:nUse
[3/4/2021 9:38:29] Description:
[3/4/2021 9:38:29] (LuaInterface::luaGetThingFromPosition) Tile not found

up

up

up

up

up
 
Back
Top