OTClient Bug skills OTClient (skills show 0, but not 0)... extended limit

[roriscrave]

Hello everyone, I have the skill limits extended in the source, player can take skill > 255, and it work in old client 100%, because i changed client with a dll.
But if i login with OTClient, it show all skills = 0, why? How can i extended skills in OTclient?

protocolgame.cpp

        if (player->getOperatingSystem() >= CLIENTOS_OTCLIENT_LINUX) {
            playermsg.addByte(std::min<int32_t>(player->getSkillLevel(i), std::numeric_limits<uint16_t>::max()));
        } else {
            playermsg.add<uint16_t>(std::min<int32_t>(player->getSkillLevel(i), std::numeric_limits<uint16_t>::max()));
        }

 

[Error 502]

version?

try with

g_game.enableFeature(GameDoubleSkills);
or
            g_game.enableFeature(GameBaseSkillU16);

 

[roriscrave]

version?

try with

g_game.enableFeature(GameDoubleSkills);
            g_game.enableFeature(GameBaseSkillU16);

OTCv8 and tfs 1.x... i added it but not solved.
When i login my skills stay in 0, when i put some item that have skills atributte, the skill show real, if i remove item, back to 0

 

[Gesior.pl]

Replace in protocolgame.cpp on server:

        if (player->getOperatingSystem() >= CLIENTOS_OTCLIENT_LINUX) {
            playermsg.addByte(std::min<int32_t>(player->getSkillLevel(i), std::numeric_limits<uint16_t>::max()));
        } else {
            playermsg.add<uint16_t>(std::min<int32_t>(player->getSkillLevel(i), std::numeric_limits<uint16_t>::max()));
        }

with:

        playermsg.add<uint16_t>(std::min<int32_t>(player->getSkillLevel(i), std::numeric_limits<uint16_t>::max()));

and enable feature GameDoubleSkills in OTCv8, to make it read 16 bit skill levels:

otcv8-dev/src/client/protocolgameparse.cpp at master · OTCv8/otcv8-dev

OTCv8 Development repository (source code). Contribute to OTCv8/otcv8-dev development by creating an account on GitHub.

github.com

To enable GameDoubleSkills for old protocols in OTCv8, add:

g_game.enableFeature(GameDoubleSkills)

in modules/game_features/features.lua:

otcv8-dev/modules/game_features/features.lua at master · OTCv8/otcv8-dev

OTCv8 Development repository (source code). Contribute to OTCv8/otcv8-dev development by creating an account on GitHub.

github.com

 

[roriscrave]

Solved, added what Gesior saied, and now works fine:

        g_game.enableFeature(GameDoubleMagicLevel)
        g_game.enableFeature(GameDoubleSkills)