Solved Check if monster is summon TFS 1.2

[Moj mistrz]

Hello as the title says, but that's not all and it would be too long for a thread title. Basically I want my script to check whether:

a) attacked monster is a summon
b) if it's a summon, does it belong to me or any member of my party or guild
c) if yes then return YOUMAYNOTATTACKTHISPLAYER

That's the code I've got for now. It checks if my target is in my party or guild, but I have no idea how to write it to check if the summon belong to me or any member of my party/guild.

    if self:isPlayer() and target:isPlayer() then
        local party, guild = self:getParty(), self:getGuild()
        if party or guild then
            local targetParty, targetGuild = target:getParty(), target:getGuild()
            if targetParty and targetParty == party or targetGuild and targetGuild == guild then
                return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
            end
        end
    end

Thanks for any help.

 

[Printer]

if self:isPlayer() and target:isMonster() then
    local master = target:getMaster()
    if master and master:isPlayer() then
        local party, targetParty = self:getParty(), master:getParty()
        if (party ~= nil and targetParty ~= nil) and party == targetParty then
            return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE
        end

        local guild, targetGuild = self:getGuild(), master:getGuild()
        if (guild ~= nil and targetGuild ~= nil) and guild == targetGuild then
            return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE
        end
    end
end

 

[Moj mistrz]

Thanks @Printer , as always great job .

 

[mezuf98]

Hi guys im new here, where can i add this ?

 

[Printer]

Hi guys im new here, where can i add this ?

https://github.com/otland/forgottenserver/blob/master/data/events/scripts/creature.lua#L9

 

[mezuf98]

https://github.com/otland/forgottenserver/blob/master/data/events/scripts/creature.lua#L9

I did this in events/scripts/creature.lua:

function Creature:onTargetCombat(target)
if self:isPlayer() and target:isMonster() then
    local master = target:getMaster()
    if master and master:isPlayer() then
        local party, targetParty = self:getParty(), master:getParty()
        if (party ~= nil and targetParty ~= nil) and party == targetParty then
            return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE
        end

        local guild, targetGuild = self:getGuild(), master:getGuild()
        if (guild ~= nil and targetGuild ~= nil) and guild == targetGuild then
            return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE
        end
    end
end
    return true
end

but i can attack my and party summons...

 

[Printer]

You have to enable the event by change 0 to 1
https://github.com/otland/forgottenserver/blob/master/data/events/events.xml#L6

 

[mezuf98]

You have to enable the event by change 0 to 1
https://github.com/otland/forgottenserver/blob/master/data/events/events.xml#L6

That is it! Thank you Printer.

i have a problem with this too(mounts) https://otland.net/threads/dismount-in-battle-mode.244319/

with you have more time to help me, i will be grateful..

sorry for my english.

 

[tokenzz]

You can always use isSummon() if you can't solve it yourself . It's a function already implemented in the latest version of tfs 1.2

 

[zyzz7omg]

You can always use isSummon() if you can't solve it yourself . It's a function already implemented in the latest version of tfs 1.2

I have a problem with either isSummon() or getMaster() methods.
When, for example, I kill a Necromancer with its summons with a gfb (all die at the same time) the summons count as killed monsters, even if I give the following instruction to the onKill script:

if target:isPlayer() or target:getMaster() or target:isSummon() then
return
end

The other part of the code counts killed monsters, and is counting summons also when it sould not be counting.
I hope I explained myself, if you need more info please let me know.
Cheers
Zyzz

 

[Mateus Robeerto]

I have a problem with either isSummon() or getMaster() methods.
When, for example, I kill a Necromancer with its summons with a gfb (all die at the same time) the summons count as killed monsters, even if I give the following instruction to the onKill script:

if target:isPlayer() or target:getMaster() or target:isSummon() then
return
end

The other part of the code counts killed monsters, and is counting summons also when it sould not be counting.
I hope I explained myself, if you need more info please let me know.
Cheers
Zyzz

if target:isPlayer() or (target:getMaster() ~= nil) or (target:isSummon() == true) then
    return
end

In that code, I noticed that checking if the target is a player, if it has a defined master or if it is an invocation. If any of these conditions are true, the code will return and it will not count the target as a dead monster.