Chest box error

[henkas]

local storage_id = 2545

local random_rewards = {
    [1] = {chest_uid = 1577, reward_id = 14282, reward_count = 1},
    [2] = {chest_uid = 1577, reward_id = 14361, reward_count = 1},
    [3] = {chest_uid = 1577, reward_id = 14358, reward_count = 1},
    [4] = {chest_uid = 1577, reward_id = 14360, reward_count = 1},
}

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    local storage = player:getStorageValue(storage_id)
    if storage > 0 then
        return player:sendTextMessage(MESSAGE_INFO_DESCR, "It is empty.")
    end

    local randoms = {}
    for i = 1, #random_rewards do
        if random_rewards[i].chest_uid == item.uid then
            randoms[#randoms + 1] = random_rewards[i]
        end
    end

    local bag = Game.createItem(1987)
    bag:addItem(reward.reward_id, reward.reward_count)
    local random_num = math.random(1, #randoms)
    bag:addItem(randoms[random_num].reward_id, randoms[random_num].reward_count)

    if player:addItemEx(bag) then
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You have found a bag.")
        player:setStorageValue(storage_id, 1)
    else
        local weight = bag:getWeight()
        player:sendTextMessage(MESSAGE_INFO_DESCR, 'You have found a bag weighing ' .. weight / 100 .. ' oz it\'s too heavy or you do not have enough room.')
    end
    return true
end

TFS 1.2

 

[oen432]

reward.reward_id, reward.reward_count
reward there is no such thing.

 

[henkas]

reward.reward_id, reward.reward_count
reward there is no such thing.

How is there no reward.reward_id and count
bag:addItem(reward.reward_id, reward.reward_count)

 

[oen432]

How is there no reward.reward_id and count
bag:addItem(reward.reward_id, reward.reward_count)

And where did you initialize reward variable?

 

[henkas]

And where did you initialize reward variable?

    local reward
    for i = 1, #random_rewards do
    if random_rewards[i].chest_uid == item.uid then
    reward = random_rewards[i]
    break
    end
    end

?

 

[oen432]

    local reward
    for i = 1, #random_rewards do
    if random_rewards[i].chest_uid == item.uid then
    reward = random_rewards[i]
    break
    end
    end

?

Correct! Good job!

 

[henkas]

Correct! Good job!

Hmmm maybe it solved the error but now i get two items

 

[oen432]

Hmmm maybe it solved the error but now i get two items

Post entire script after changes.

 

[henkas]

Post entire script after changes.

local storage_id = 2545

local random_rewards = {
    [1] = {chest_uid = 1577, reward_id = 14282, reward_count = 1},
    [2] = {chest_uid = 1577, reward_id = 14361, reward_count = 1},
    [3] = {chest_uid = 1577, reward_id = 14358, reward_count = 1},
    [4] = {chest_uid = 1577, reward_id = 14360, reward_count = 1},
}

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    local storage = player:getStorageValue(storage_id)
    if storage > 0 then
        return player:sendTextMessage(MESSAGE_INFO_DESCR, "It is empty.")
    end

    local reward
    for i = 1, #random_rewards do
    if random_rewards[i].chest_uid == item.uid then
    reward = random_rewards[i]
    break
    end
    end

    local randoms = {}
    for i = 1, #random_rewards do
        if random_rewards[i].chest_uid == item.uid then
            randoms[#randoms + 1] = random_rewards[i]
        end
    end

    local bag = Game.createItem(1987)
    bag:addItem(reward.reward_id, reward.reward_count)
    local random_num = math.random(1, #randoms)
    bag:addItem(randoms[random_num].reward_id, randoms[random_num].reward_count)

    if player:addItemEx(bag) then
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You have found a bag.")
        player:setStorageValue(storage_id, 1)
    else
        local weight = bag:getWeight()
        player:sendTextMessage(MESSAGE_INFO_DESCR, 'You have found a bag weighing ' .. weight / 100 .. ' oz it\'s too heavy or you do not have enough room.')
    end
    return true
end

So i tried recreating whole local function then i got different error, if i use two local i get two items, so i cant figure it out they correct way of it

 

[oen432]

Lets start with this array

local random_rewards = {
    [1] = {chest_uid = 1577, reward_id = 14282, reward_count = 1},
    [2] = {chest_uid = 1577, reward_id = 14361, reward_count = 1},
    [3] = {chest_uid = 1577, reward_id = 14358, reward_count = 1},
    [4] = {chest_uid = 1577, reward_id = 14360, reward_count = 1},
}

One chest contains 4 different rewards.

Now our reward variable

local reward
for i = 1, #random_rewards do
    if random_rewards[i].chest_uid == item.uid then
        reward = random_rewards[i]
        break
    end
end

Based on that, first value from random_rewards will be assigned to that reward variable, that's because of break.

Then there are randoms

local randoms = {}
for i = 1, #random_rewards do
    if random_rewards[i].chest_uid == item.uid then
        randoms[#randoms + 1] = random_rewards[i]
    end
end

Right now randoms will be the same as random_rewards but that will change if you add more rewards with different chest_uid.

Now bag and items we put there

local bag = Game.createItem(1987)
bag:addItem(reward.reward_id, reward.reward_count)

This will add 1st item which is the first one from random_rewards.

local random_num = math.random(1, #randoms)
bag:addItem(randoms[random_num].reward_id, randoms[random_num].reward_count)

Now this will add 2nd item but this time it's going to be random.

So you have 2 options. Get rid of reward usage or randoms, whichever you prefer.

Or you can make some chests to give random reward and some to give static reward.
Final script with some cleanup and changes would be like this

local storage_id = 2545

local chests = {
    [1577] = {
        random = true,
        rewards = {
            { id = 14282, count = 1},
            { id = 14361, count = 1},
            { id = 14358, count = 1},
            { id = 14360, count = 1}
        }
    },
    [1578] = {
        random = false,
        reward = { id = 14282, count = 1 }
    }
}

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    local storage = player:getStorageValue(storage_id)
    if storage > 0 then
        return player:sendTextMessage(MESSAGE_INFO_DESCR, "It is empty.")
    end

    local chest = chests[item.uid]
    if chest then
        local bag = Game.createItem(1987)
        if chest.random == true then
            local random_num = math.random(1, #chest.rewards)
            bag:addItem(chest.rewards[random_num].id, chest.rewards[random_num].count)
        else
            bag:addItem(chest.reward.id, chest.reward.count)
        end

        if player:addItemEx(bag) then
            player:sendTextMessage(MESSAGE_INFO_DESCR, "You have found a bag.")
            player:setStorageValue(storage_id, 1)
        else
            local weight = bag:getWeight()
            player:sendTextMessage(MESSAGE_INFO_DESCR, 'You have found a bag weighing ' .. weight / 100 .. ' oz it\'s too heavy or you do not have enough room.')
        end
    end
    return true
end

Let me know if you don't understand something and I'll try to explain.

 

[henkas]

Edit nvm messed up with local. Everything works, thanks for explain it.

local storage_id = 2545

local random_rewards = {
    [1] = {chest_uid = 1577, reward_id = 14282, reward_count = 1},
    [2] = {chest_uid = 1577, reward_id = 14361, reward_count = 1},
    [3] = {chest_uid = 1577, reward_id = 14358, reward_count = 1},
    [4] = {chest_uid = 1577, reward_id = 14360, reward_count = 1},
}

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    local storage = player:getStorageValue(storage_id)
    if storage > 0 then
        return player:sendTextMessage(MESSAGE_INFO_DESCR, "It is empty.")
    end

     local randoms = {}
    for i = 1, #random_rewards do
    if random_rewards[i].chest_uid == item.uid then
        randoms[#randoms + 1] = random_rewards[i]
    end
    end

    local bag = Game.createItem(1987)
    local random_num = math.random(1, #randoms)
    bag:addItem(randoms[random_num].reward_id, randoms[random_num].reward_count)

    if player:addItemEx(bag) then
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You have found a bag.")
        player:setStorageValue(storage_id, 1)
    else
        local weight = bag:getWeight()
        player:sendTextMessage(MESSAGE_INFO_DESCR, 'You have found a bag weighing ' .. weight / 100 .. ' oz it\'s too heavy or you do not have enough room.')
    end
    return true
end