• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Solved Choosie outfit when login Problem!

C

carre

Advanced OT User
Joined
Apr 23, 2013
Messages
881
Solutions
1
Reaction score
157
Location
Sweden
Hello otland

When I create a character from the website.

And login into the game server,choose outfit window not appers.

My tfs is 0.3.7

here is my PROTOCOLGAME.cpp and how can i fix it?
Code: 
////////////////////////////////////////////////////////////////////////
// OpenTibia - an opensource roleplaying game
////////////////////////////////////////////////////////////////////////
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program.  If not, see <http://www.gnu.org/licenses/>.
////////////////////////////////////////////////////////////////////////

#ifndef __PROTOCOLGAME__
#define __PROTOCOLGAME__

#include "otsystem.h"
#include "enums.h"

#include "protocol.h"
#include "creature.h"

class NetworkMessage;
class Player;
class Game;
class House;
class Container;
class Tile;
class Connection;
class Quest;
class Depot;

typedef std::list<std::pair<uint16_t, std::string> > ChannelsList;
typedef boost::shared_ptr<NetworkMessage> NetworkMessage_ptr;
class ProtocolGame : public Protocol
{
    public:
#ifdef __ENABLE_SERVER_DIAGNOSTIC__
        static uint32_t protocolGameCount;
#endif

        ProtocolGame(Connection_ptr connection): Protocol(connection)
        {
#ifdef __ENABLE_SERVER_DIAGNOSTIC__
            protocolGameCount++;
#endif
            player = NULL;
            m_eventConnect = 0;
            m_debugAssertSent = m_acceptPackets = false;
        }
        virtual ~ProtocolGame()
        {
#ifdef __ENABLE_SERVER_DIAGNOSTIC__
            protocolGameCount--;
#endif
        }

        enum {protocolId = 0x0A};
        enum {isSingleSocket = true};
        enum {hasChecksum = true};
        static const char* protocolName() {return "game protocol";}

        bool login(const std::string& name, uint32_t id, const std::string& password,
            OperatingSystem_t operatingSystem, uint16_t version, bool gamemaster);
        bool logout(bool displayEffect, bool forceLogout);

        void setPlayer(Player* p);

    private:
        void disconnectClient(uint8_t error, const char* message);

        std::list<uint32_t> knownCreatureList;
        void checkCreatureAsKnown(uint32_t id, bool& known, uint32_t& removedKnown);

        bool connect(uint32_t playerId, OperatingSystem_t operatingSystem, uint16_t version);
        void disconnect();

        virtual void releaseProtocol();
        virtual void deleteProtocolTask();

        bool canSee(uint16_t x, uint16_t y, uint16_t z) const;
        bool canSee(const Creature*) const;
        bool canSee(const Position& pos) const;

        virtual void onConnect();
        virtual void onRecvFirstMessage(NetworkMessage& msg);

        virtual void parsePacket(NetworkMessage& msg);

        //Parse methods
        void parseLogout(NetworkMessage& msg);
        void parseCancelWalk(NetworkMessage& msg);
        void parseCancelTarget(NetworkMessage& msg);

        void parseReceivePing(NetworkMessage& msg);
        void parseAutoWalk(NetworkMessage& msg);
        void parseMove(NetworkMessage& msg, Direction dir);
        void parseTurn(NetworkMessage& msg, Direction dir);
        void parseCancelMove(NetworkMessage& msg);

        void parseRequestOutfit(NetworkMessage& msg);
        void parseSetOutfit(NetworkMessage& msg);
        void parseSay(NetworkMessage& msg);
        void parseLookAt(NetworkMessage& msg);
        void parseLookInBattleList(NetworkMessage& msg);
        void parseFightModes(NetworkMessage& msg);
        void parseAttack(NetworkMessage& msg);
        void parseFollow(NetworkMessage& msg);

        void parseBugReport(NetworkMessage& msg);
        void parseDebugAssert(NetworkMessage& msg);

        void parseThrow(NetworkMessage& msg);
        void parseUseItemEx(NetworkMessage& msg);
        void parseBattleWindow(NetworkMessage& msg);
        void parseUseItem(NetworkMessage& msg);
        void parseCloseContainer(NetworkMessage& msg);
        void parseUpArrowContainer(NetworkMessage& msg);
        void parseUpdateTile(NetworkMessage& msg);
        void parseUpdateContainer(NetworkMessage& msg);
        void parseTextWindow(NetworkMessage& msg);
        void parseHouseWindow(NetworkMessage& msg);

        void parseLookInShop(NetworkMessage& msg);
        void parsePlayerPurchase(NetworkMessage& msg);
        void parsePlayerSale(NetworkMessage& msg);
        void parseCloseShop(NetworkMessage& msg);

        void parseQuests(NetworkMessage& msg);
        void parseQuestInfo(NetworkMessage& msg);

        void parseInviteToParty(NetworkMessage& msg);
        void parseJoinParty(NetworkMessage& msg);
        void parseRevokePartyInvite(NetworkMessage& msg);
        void parsePassPartyLeadership(NetworkMessage& msg);
        void parseLeaveParty(NetworkMessage& msg);
        void parseSharePartyExperience(NetworkMessage& msg);

        //trade methods
        void parseRequestTrade(NetworkMessage& msg);
        void parseLookInTrade(NetworkMessage& msg);
        void parseAcceptTrade(NetworkMessage& msg);
        void parseCloseTrade();

        //VIP methods
        void parseAddVip(NetworkMessage& msg);
        void parseRemoveVip(NetworkMessage& msg);

        void parseRotateItem(NetworkMessage& msg);

        //Channel tabs
        void parseCreatePrivateChannel(NetworkMessage& msg);
        void parseChannelInvite(NetworkMessage& msg);
        void parseChannelExclude(NetworkMessage& msg);
        void parseGetChannels(NetworkMessage& msg);
        void parseOpenChannel(NetworkMessage& msg);
        void parseOpenPrivate(NetworkMessage& msg);
        void parseCloseChannel(NetworkMessage& msg);
        void parseCloseNpc(NetworkMessage& msg);

        //rule violation
        void parseViolationReport(NetworkMessage& msg);

        //Send functions
        void sendChannelMessage(std::string author, std::string text, MessageClasses type, uint16_t channel);
        void sendClosePrivate(uint16_t channelId);
        void sendCreatePrivateChannel(uint16_t channelId, const std::string& channelName);
        void sendChannelsDialog(const ChannelsList& channels);
        void sendChannel(uint16_t channelId, const std::string& channelName);
        void sendOpenPrivateChannel(const std::string& receiver);
        void sendIcons(int32_t icons);
        void sendFYIBox(const std::string& message);

        void sendDistanceShoot(const Position& from, const Position& to, uint8_t type);
        void sendMagicEffect(const Position& pos, uint8_t type);
        void sendAnimatedText(const Position& pos, uint8_t color, std::string text);
        void sendCreatureHealth(const Creature* creature);
        void sendSkills();
        void sendPing();
        void sendCreatureTurn(const Creature* creature, int16_t stackpos);
        void sendCreatureSay(const Creature* creature, MessageClasses type, const std::string& text, Position* pos, uint32_t statementId);
        void sendCreatureChannelSay(const Creature* creature, MessageClasses type, const std::string& text, uint16_t channelId, uint32_t statementId);

        void sendCancel(const std::string& message);
        void sendCancelWalk();
        void sendChangeSpeed(const Creature* creature, uint32_t speed);
        void sendCancelTarget();
        void sendCreatureOutfit(const Creature* creature, const Outfit_t& outfit);
        void sendStats();
        void sendTextMessage(MessageClasses mclass, const std::string& message);
        void sendStatsMessage(MessageClasses mclass, const std::string& message,
            Position pos, MessageDetails* details = NULL);
        void sendReLoginWindow();

        void sendTutorial(uint8_t tutorialId);
        void sendAddMarker(const Position& pos, MapMarks_t markType, const std::string& desc);

        void sendCreatureSkull(const Creature* creature);
        void sendCreatureShield(const Creature* creature);
        void sendCreatureEmblem(const Creature* creature) {reloadCreature(creature);}
        void sendCreatureWalkthrough(const Creature* creature, bool walkthrough);

        void sendShop(Npc* npc, const ShopInfoList& shop);
        void sendCloseShop();
        void sendGoods(const ShopInfoList& shop);
        void sendTradeItemRequest(const Player* _player, const Item* item, bool ack);
        void sendCloseTrade();

        void sendTextWindow(uint32_t windowTextId, Item* item, uint16_t maxLen, bool canWrite);
        void sendHouseWindow(uint32_t windowTextId, House* house, uint32_t listId, const std::string& text);

        void sendOutfitWindow();
        void sendQuests();
        void sendQuestInfo(Quest* quest);

        void sendVIPLogIn(uint32_t guid);
        void sendVIPLogOut(uint32_t guid);
        void sendVIP(uint32_t guid, const std::string& name, bool online);

        void sendCreatureLight(const Creature* creature);
        void sendWorldLight(const LightInfo& lightInfo);

        void sendCreatureSquare(const Creature* creature, uint8_t color);

        //tiles
        void sendAddTileItem(const Tile* tile, const Position& pos, uint32_t stackpos, const Item* item);
        void sendUpdateTileItem(const Tile* tile, const Position& pos, uint32_t stackpos, const Item* item);
        void sendRemoveTileItem(const Tile* tile, const Position& pos, uint32_t stackpos);
        void sendUpdateTile(const Tile* tile, const Position& pos);

        void sendAddCreature(const Creature* creature, const Position& pos, uint32_t stackpos);
        void sendRemoveCreature(const Creature* creature, const Position& pos, uint32_t stackpos);
        void sendMoveCreature(const Creature* creature, const Tile* newTile, const Position& newPos, uint32_t newStackPos,
            const Tile* oldTile, const Position& oldPos, uint32_t oldStackpos, bool teleport);

        //containers
        void sendAddContainerItem(uint8_t cid, const Item* item);
        void sendUpdateContainerItem(uint8_t cid, uint8_t slot, const Item* item);
        void sendRemoveContainerItem(uint8_t cid, uint8_t slot);

        void sendContainer(uint32_t cid, const Container* container, bool hasParent);
        void sendCloseContainer(uint32_t cid);

        //inventory
        void sendAddInventoryItem(slots_t slot, const Item* item);
        void sendUpdateInventoryItem(slots_t slot, const Item* item);
        void sendRemoveInventoryItem(slots_t slot);

        // help functions
        void reloadCreature(const Creature* creature);

        //translate a tile to clientreadable format
        void GetTileDescription(const Tile* tile, NetworkMessage_ptr msg);

        //translate a floor to clientreadable format
        void GetFloorDescription(NetworkMessage_ptr msg, int32_t x, int32_t y, int32_t z,
            int32_t width, int32_t height, int32_t offset, int32_t& skip);

        //translate a map area to clientreadable format
        void GetMapDescription(int32_t x, int32_t y, int32_t z,
            int32_t width, int32_t height, NetworkMessage_ptr msg);

        void AddMapDescription(NetworkMessage_ptr msg, const Position& pos);
        void AddTextMessage(NetworkMessage_ptr msg, MessageClasses mclass, const std::string& message,
            Position* pos = NULL, MessageDetails* details = NULL);
        void AddAnimatedText(NetworkMessage_ptr msg, const Position& pos,
            uint8_t color, const std::string& text);
        void AddMagicEffect(NetworkMessage_ptr msg, const Position& pos, uint8_t type);
        void AddDistanceShoot(NetworkMessage_ptr msg, const Position& from, const Position& to, uint8_t type);
        void AddCreature(NetworkMessage_ptr msg, const Creature* creature, bool known, uint32_t remove);
        void AddPlayerStats(NetworkMessage_ptr msg);
        void AddCreatureSpeak(NetworkMessage_ptr msg, const Creature* creature, MessageClasses type,
            std::string text, uint16_t channelId, Position* pos, uint32_t statementId);
        void AddCreatureHealth(NetworkMessage_ptr msg, const Creature* creature);
        void AddCreatureOutfit(NetworkMessage_ptr msg, const Creature* creature, const Outfit_t& outfit, bool outfitWindow = false);
        void AddPlayerSkills(NetworkMessage_ptr msg);
        void AddWorldLight(NetworkMessage_ptr msg, const LightInfo& lightInfo);
        void AddCreatureLight(NetworkMessage_ptr msg, const Creature* creature);

        //tiles
        void AddTileItem(NetworkMessage_ptr msg, const Position& pos, uint32_t stackpos, const Item* item);
        void AddTileCreature(NetworkMessage_ptr msg, const Position& pos, uint32_t stackpos, const Creature* creature);
        void UpdateTileItem(NetworkMessage_ptr msg, const Position& pos, uint32_t stackpos, const Item* item);
        void RemoveTileItem(NetworkMessage_ptr msg, const Position& pos, uint32_t stackpos);

        void MoveUpCreature(NetworkMessage_ptr msg, const Creature* creature,
            const Position& newPos, const Position& oldPos, uint32_t oldStackpos);
        void MoveDownCreature(NetworkMessage_ptr msg, const Creature* creature,
            const Position& newPos, const Position& oldPos, uint32_t oldStackpos);

        //container
        void AddContainerItem(NetworkMessage_ptr msg, uint8_t cid, const Item* item);
        void UpdateContainerItem(NetworkMessage_ptr msg, uint8_t cid, uint8_t slot, const Item* item);
        void RemoveContainerItem(NetworkMessage_ptr msg, uint8_t cid, uint8_t slot);

        //inventory
        void AddInventoryItem(NetworkMessage_ptr msg, slots_t slot, const Item* item);
        void UpdateInventoryItem(NetworkMessage_ptr msg, slots_t slot, const Item* item);
        void RemoveInventoryItem(NetworkMessage_ptr msg, slots_t slot);

        //shop
        void AddShopItem(NetworkMessage_ptr msg, const ShopInfo& item);

        void parseExtendedOpcode(NetworkMessage& msg);
        void sendExtendedOpcode(uint8_t opcode, const std::string& buffer);

        #define addGameTask(f, ...) addGameTaskInternal(0, boost::bind(f, &g_game, __VA_ARGS__))
        #define addGameTaskTimed(delay, f, ...) addGameTaskInternal(delay, boost::bind(f, &g_game, __VA_ARGS__))
        template<class FunctionType>
        void addGameTaskInternal(uint32_t delay, const FunctionType&);

        friend class Player;
        Player* player;

        uint32_t m_eventConnect, m_maxSizeCount, m_packetCount, m_packetTime;
        bool m_debugAssertSent, m_acceptPackets;
};
#endif
 
Last edited:
Solution
Infernum
has nothing to do with protocolgame or sources
it's likely your website sets lastLogin to greater than 0 when you create a character, so getLastLoginSaved(cid) (or whatever it's called in 0.x) returns > 0 (it has to be <= 0 for the outfit window to show)
Sort by date Sort by votes
has nothing to do with protocolgame or sources
it's likely your website sets lastLogin to greater than 0 when you create a character, so getLastLoginSaved(cid) (or whatever it's called in 0.x) returns > 0 (it has to be <= 0 for the outfit window to show)
 
Upvote 0 Downvote
Solution
Solved in discord! :)

Everyone got the same problem paste this in login. Lua

Remove the old one and paste this.


Code: 
local accountManager = getPlayerAccountManager(cid)
if(accountManager == MANAGER_NONE) then
    local lastLogin, str = getPlayerLastLoginSaved(cid), config.loginMessage
    if getCreatureStorage(cid, storagehere) > 0 then -- Here it checks if the player has the storage (choose one by yourself)
        doPlayerSendTextMessage(cid, MESSAGE_STATUS_DEFAULT, str)
        str = "Your last visit was on " .. os.date("%a %b %d %X %Y", lastLogin) .. "."
    else
        str = str .. " Please choose your outfit."
        doPlayerSendOutfitWindow(cid)
        doCreatureSetStorage(cid,  storagehere, 1) -- Here it sets the storage so the player doesn't get the window every time (use the same storage here)
    end
 
Upvote 0 Downvote
carre said:
Solved in discord! :)

Everyone got the same problem paste this in login. Lua

Remove the old one and paste this.


Code: 
local accountManager = getPlayerAccountManager(cid)
if(accountManager == MANAGER_NONE) then
    local lastLogin, str = getPlayerLastLoginSaved(cid), config.loginMessage
    if getCreatureStorage(cid, storagehere) > 0 then -- Here it checks if the player has the storage (choose one by yourself)
        doPlayerSendTextMessage(cid, MESSAGE_STATUS_DEFAULT, str)
        str = "Your last visit was on " .. os.date("%a %b %d %X %Y", lastLogin) .. "."
    else
        str = str .. " Please choose your outfit."
        doPlayerSendOutfitWindow(cid)
        doCreatureSetStorage(cid,  storagehere, 1) -- Here it sets the storage so the player doesn't get the window every time (use the same storage here)
    end
Click to expand...
nononononononononononononoNO
You literally have it in your script already.
You don't need a storage value for this.
Look.
Lua: 
local accountManager = getPlayerAccountManager(cid)
if(accountManager == MANAGER_NONE) then
    local lastLogin, str = getPlayerLastLoginSaved(cid), config.loginMessage
    if lastLogin > 0 then
        doPlayerSendTextMessage(cid, MESSAGE_STATUS_DEFAULT, str)
        str = "Your last visit was on " .. os.date("%a %b %d %X %Y", lastLogin) .. "."
    else
        str = str .. " Please choose your outfit."
        doPlayerSendOutfitWindow(cid)
    end
Vulcan_ said:
has nothing to do with protocolgame or sources
it's likely your website sets lastLogin to greater than 0 when you create a character, so getLastLoginSaved(cid) (or whatever it's called in 0.x) returns > 0 (it has to be <= 0 for the outfit window to show)
Click to expand...
He told you the answer already, right here.
 
Upvote 0 Downvote
Xikini said:
nononononononononononononoNO
You literally have it in your script already.
You don't need a storage value for this.
Look.
Lua: 
local accountManager = getPlayerAccountManager(cid)
if(accountManager == MANAGER_NONE) then
    local lastLogin, str = getPlayerLastLoginSaved(cid), config.loginMessage
    if lastLogin > 0 then
        doPlayerSendTextMessage(cid, MESSAGE_STATUS_DEFAULT, str)
        str = "Your last visit was on " .. os.date("%a %b %d %X %Y", lastLogin) .. "."
    else
        str = str .. " Please choose your outfit."
        doPlayerSendOutfitWindow(cid)
    end

He told you the answer already, right here.
Click to expand...
True, but didn't understand of his answer.
 
Upvote 0 Downvote

Similar threads

SixNine
  • Solved
TFS 1.2 sendMoveCreature NETWORKMESSAGE crash requires 187696 bytes
Replies
6
Views
418
SixNine
SixNine
johnsamir
  • Question
Market system tfs 1.5 protocol 8.6
Replies
0
Views
200
johnsamir
johnsamir
johnsamir
  • Question
TFS 1.X+ market system
Replies
1
Views
398
johnsamir
johnsamir
E
  • Question
tfs 1.4.2 basespeed bug
Replies
0
Views
237
edddaaan
E
Murilo35
  • Solved
C++ TFS 1.0 - v8.6 Remove Player Respawn Block
Replies
2
Views
313
Murilo35
Murilo35
F
  • Question
TFS 1.X+ fix + 9 stack pos error in compilation
Replies
0
Views
272
ForgottenNot
F
johnsamir
  • Question
TFS 1.X+ [TFS-1.4 - 8.6]Cast system screen problem
Replies
5
Views
300
johnsamir
johnsamir
Lopaskurwa
  • Question
TFS 1.2 Parase new walk crashing server
Replies
3
Views
412
Lopaskurwa
Lopaskurwa
Derlexy
  • Question
TFS 1.X+ Error in "ProtocolGame::AddPlayerStats"
Replies
4
Views
527
Derlexy
Derlexy
Back
Top